Gentoo Archives: gentoo-commits

From: "Alfredo Tupone (tupone)" <tupone@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in games-emulation/gxmame/files: gxmame-0.35_beta2-ovflfix.patch
Date: Wed, 01 Dec 2010 10:07:03
Message-Id: 20101201100653.1C04020054@flycatcher.gentoo.org
1 tupone 10/12/01 10:06:53
2
3 Added: gxmame-0.35_beta2-ovflfix.patch
4 Log:
5 Fix buffer overflow. Bug #325281
6
7 (Portage version: 2.1.9.25/cvs/Linux i686)
8
9 Revision Changes Path
10 1.1 games-emulation/gxmame/files/gxmame-0.35_beta2-ovflfix.patch
11
12 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/games-emulation/gxmame/files/gxmame-0.35_beta2-ovflfix.patch?rev=1.1&view=markup
13 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/games-emulation/gxmame/files/gxmame-0.35_beta2-ovflfix.patch?rev=1.1&content-type=text/plain
14
15 Index: gxmame-0.35_beta2-ovflfix.patch
16 ===================================================================
17 --- src/options.c.old 2010-12-01 10:48:45.000000000 +0100
18 +++ src/options.c 2010-12-01 10:53:55.000000000 +0100
19 @@ -4245,7 +4245,7 @@
20 case XMAME_EXEC_SVGAFX:
21 target->fxgkeepaspect = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (fxgkeepaspect_checkbutton));
22 used_text = gtk_editable_get_chars (GTK_EDITABLE (fx_entry), 0, -1);
23 - strncpy (target->resolution, used_text, 20);
24 + strncpy (target->resolution, used_text, sizeof(target->resolution));
25 g_free (used_text);
26 break;
27
28 @@ -4330,7 +4330,7 @@
29 }
30
31 used_text = gtk_editable_get_chars (GTK_EDITABLE (soundfile_entry), 0, -1);
32 - strncpy (target->soundfile, used_text, 50);
33 + strncpy (target->soundfile, used_text, sizeof(target->soundfile));
34 g_free (used_text);
35
36 target->timer = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (timer_checkbutton));
37 @@ -4465,7 +4465,7 @@
38 target->skip_disclaimer = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (disclaimer_checkbutton));
39 target->skip_gameinfo = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (gameinfo_checkbutton));
40 used_text = gtk_editable_get_chars (GTK_EDITABLE (debug_size_combo_entry), 0, -1);
41 - strncpy (target->debug_size, used_text, 20);
42 + strncpy (target->debug_size, used_text, sizeof(target->debug_size));
43 g_free (used_text);
44 target->use_additional_options = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (additional_options_checkbutton));
45 /* here I'm using directly the additional option because I don't know its length */