1 |
commit: ab6630af6804d8e79e3a3f6ab31b5abb8a6f6d9c |
2 |
Author: zongyu <zzy2529420793 <AT> gmail <DOT> com> |
3 |
AuthorDate: Tue Aug 18 03:20:45 2020 +0000 |
4 |
Commit: Miroslav Šulc <fordfrog <AT> gentoo <DOT> org> |
5 |
CommitDate: Tue Aug 18 08:05:21 2020 +0000 |
6 |
URL: https://gitweb.gentoo.org/proj/java-ebuilder.git/commit/?id=ab6630af |
7 |
|
8 |
improve the coding style of ebuild |
9 |
|
10 |
Signed-off-by: zongyu <zzy2529420793 <AT> gmail.com> |
11 |
|
12 |
.../gentoo/java/ebuilder/maven/MavenEbuilder.java | 107 ++++++++++----------- |
13 |
1 file changed, 53 insertions(+), 54 deletions(-) |
14 |
|
15 |
diff --git a/src/main/java/org/gentoo/java/ebuilder/maven/MavenEbuilder.java b/src/main/java/org/gentoo/java/ebuilder/maven/MavenEbuilder.java |
16 |
index bfedb68..b16a64e 100644 |
17 |
--- a/src/main/java/org/gentoo/java/ebuilder/maven/MavenEbuilder.java |
18 |
+++ b/src/main/java/org/gentoo/java/ebuilder/maven/MavenEbuilder.java |
19 |
@@ -31,14 +31,6 @@ public class MavenEbuilder { |
20 |
private static final String defaultHomepage |
21 |
= "https://wiki.gentoo.org/wiki/No_homepage"; |
22 |
|
23 |
- /** |
24 |
- * The extra dependency for framework "pkgdiff" |
25 |
- */ |
26 |
- private static final String dependencyForPkgdiff |
27 |
- = "\n\t\tamd64? (\n\t\t\tdev-util/pkgdiff" |
28 |
- + "\n\t\t\tdev-util/japi-compliance-checker" |
29 |
- + "\n\t\t)"; |
30 |
- |
31 |
/** |
32 |
* EAPI version. |
33 |
*/ |
34 |
@@ -389,7 +381,9 @@ public class MavenEbuilder { |
35 |
|
36 |
dependencies.stream().filter((dependency) |
37 |
-> (dependency.getSystemDependency() != null |
38 |
- && !result.contains(dependency.getSystemDependency()))). |
39 |
+ && !result.contains(dependency.getSystemDependency()) |
40 |
+ && (determineTestingFrameworkByDependency(dependency) == null |
41 |
+ || type != "test"))). |
42 |
forEach((dependency) -> { |
43 |
result.add(dependency.getSystemDependency()); |
44 |
}); |
45 |
@@ -555,26 +549,39 @@ public class MavenEbuilder { |
46 |
writer.println("\tapp-arch/unzip"); |
47 |
} |
48 |
|
49 |
- if (config.hasBinjarUri() && (hasCDepend || !compileDependencies.isEmpty())) { |
50 |
- writer.println("\t!binary? ("); |
51 |
- } |
52 |
- |
53 |
- if (hasCDepend) { |
54 |
- writer.println("\t${CDEPEND}"); |
55 |
- } |
56 |
+ if (config.hasBinjarUri()) { |
57 |
+ if (hasCDepend && compileDependencies.isEmpty()) { |
58 |
+ writer.println("\t!binary? ( ${CDEPEND} )"); |
59 |
+ } else if (!compileDependencies.isEmpty()) { |
60 |
+ writer.println("\t!binary? ("); |
61 |
+ |
62 |
+ if (hasCDepend) { |
63 |
+ writer.println("\t\t${CDEPEND}"); |
64 |
+ } |
65 |
+ |
66 |
+ if (!compileDependencies.isEmpty()) { |
67 |
+ compileDependencies.stream().forEach((dependency) -> { |
68 |
+ writer.print("\t\t"); |
69 |
+ writer.println(dependency); |
70 |
+ }); |
71 |
+ } |
72 |
|
73 |
- if (!compileDependencies.isEmpty()) { |
74 |
- compileDependencies.stream().forEach((dependency) -> { |
75 |
- writer.print('\t'); |
76 |
- writer.println(dependency); |
77 |
- }); |
78 |
- } |
79 |
+ writer.println("\t)"); |
80 |
+ } |
81 |
+ } else { |
82 |
+ if (hasCDepend) { |
83 |
+ writer.println("\t${CDEPEND}"); |
84 |
+ } |
85 |
|
86 |
- if (config.hasBinjarUri() && (hasCDepend || !compileDependencies.isEmpty())) { |
87 |
- writer.println("\t)"); |
88 |
+ if (!compileDependencies.isEmpty()) { |
89 |
+ compileDependencies.stream().forEach((dependency) -> { |
90 |
+ writer.print('\t'); |
91 |
+ writer.println(dependency); |
92 |
+ }); |
93 |
+ } |
94 |
} |
95 |
|
96 |
- if (!testDependencies.isEmpty() || config.hasBinjarUri()) { |
97 |
+ if (!testDependencies.isEmpty()) { |
98 |
writer.println("\ttest? ("); |
99 |
|
100 |
testDependencies.stream().forEach((dependency) -> { |
101 |
@@ -582,11 +589,6 @@ public class MavenEbuilder { |
102 |
writer.println(dependency); |
103 |
}); |
104 |
|
105 |
- // TODO: is it necessary to check whether amd64 is inside KEYWORDS? |
106 |
- if (config.hasBinjarUri()) { |
107 |
- writer.println(dependencyForPkgdiff); |
108 |
- } |
109 |
- |
110 |
writer.println("\t)"); |
111 |
} |
112 |
|
113 |
@@ -611,7 +613,7 @@ public class MavenEbuilder { |
114 |
writer.println(":*"); |
115 |
|
116 |
if (hasCDepend) { |
117 |
- writer.print("${CDEPEND}"); |
118 |
+ writer.print("\t${CDEPEND}"); |
119 |
} |
120 |
|
121 |
if (!runtimeDependencies.isEmpty()) { |
122 |
@@ -700,6 +702,26 @@ public class MavenEbuilder { |
123 |
} |
124 |
|
125 |
writer.println('"'); |
126 |
+ |
127 |
+ // write MAVEN_ID ahead of DESCRIPTION |
128 |
+ writer.print("MAVEN_ID=\""); |
129 |
+ writer.print(mavenProject.getGroupId()); |
130 |
+ writer.print(':'); |
131 |
+ writer.print(mavenProject.getArtifactId()); |
132 |
+ writer.print(':'); |
133 |
+ writer.print(mavenProject.getVersion()); |
134 |
+ writer.println('"'); |
135 |
+ |
136 |
+ // write testing framworks, so java-pkg-simple.eclass can deal with it |
137 |
+ final String testingFramework |
138 |
+ = determineTestingFramework(mavenProject, config); |
139 |
+ |
140 |
+ if (testingFramework != null) { |
141 |
+ writer.print("JAVA_TESTING_FRAMEWORKS=\""); |
142 |
+ writer.print(testingFramework); |
143 |
+ writer.println('"'); |
144 |
+ } |
145 |
+ |
146 |
writer.println(); |
147 |
writer.print("inherit java-pkg-2 java-pkg-simple"); |
148 |
|
149 |
@@ -750,16 +772,6 @@ public class MavenEbuilder { |
150 |
final MavenProject mavenProject, final PrintWriter writer) { |
151 |
writer.println(); |
152 |
|
153 |
- // write MAVEN_ID ahead of DESCRIPTION, |
154 |
- // becase defaultDescription need ${MAVEN_ID} |
155 |
- writer.print("MAVEN_ID=\""); |
156 |
- writer.print(mavenProject.getGroupId()); |
157 |
- writer.print(':'); |
158 |
- writer.print(mavenProject.getArtifactId()); |
159 |
- writer.print(':'); |
160 |
- writer.print(mavenProject.getVersion()); |
161 |
- writer.println('"'); |
162 |
- |
163 |
writer.print("DESCRIPTION=\""); |
164 |
|
165 |
if (mavenProject.getDescription() != null) { |
166 |
@@ -895,21 +907,8 @@ public class MavenEbuilder { |
167 |
writer.println("JAVA_BINJAR_FILENAME=\"${P}-bin.jar\""); |
168 |
} |
169 |
|
170 |
- final String testingFramework |
171 |
- = determineTestingFramework(mavenProject, config); |
172 |
boolean firstTestVar = true; |
173 |
|
174 |
- if (testingFramework != null) { |
175 |
- if (firstTestVar) { |
176 |
- writer.println(); |
177 |
- firstTestVar = false; |
178 |
- } |
179 |
- |
180 |
- writer.print("JAVA_TESTING_FRAMEWORKS=\""); |
181 |
- writer.print(testingFramework); |
182 |
- writer.println('"'); |
183 |
- } |
184 |
- |
185 |
if (!mavenProject.getTestDependencies().isEmpty()) { |
186 |
if (firstTestVar) { |
187 |
writer.println(); |