Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-misc/kio-gdrive/files/, kde-misc/kio-gdrive/
Date: Tue, 04 Aug 2020 06:37:28
Message-Id: 1596523033.4f9e042497f5e60bb4aedcffe66267db6c1aa8ae.asturm@gentoo
1 commit: 4f9e042497f5e60bb4aedcffe66267db6c1aa8ae
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Tue Aug 4 06:37:13 2020 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Tue Aug 4 06:37:13 2020 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f9e0424
7
8 kde-misc/kio-gdrive: Drop 1.2.7-r1
9
10 Package-Manager: Portage-3.0.1, Repoman-2.3.23
11 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
12
13 kde-misc/kio-gdrive/Manifest | 1 -
14 .../kio-gdrive-1.2.6-refresh-credentials.patch | 101 ---------------------
15 kde-misc/kio-gdrive/kio-gdrive-1.2.7-r1.ebuild | 52 -----------
16 3 files changed, 154 deletions(-)
17
18 diff --git a/kde-misc/kio-gdrive/Manifest b/kde-misc/kio-gdrive/Manifest
19 index c218e2fc2e0..85b22238440 100644
20 --- a/kde-misc/kio-gdrive/Manifest
21 +++ b/kde-misc/kio-gdrive/Manifest
22 @@ -1,2 +1 @@
23 -DIST kio-gdrive-1.2.7.tar.xz 46748 BLAKE2B 308c7d8d55c4eef175e2ef6030f1fbcdb59fdc6cd33f6c0bd5c35efe7bd21cf7f6cf7293b355f30b7b05effae79b91e357cc5a93ed866db850953f392bd65e0f SHA512 f1eedad2cd244e38f6cdf397e9488cb7f31fe7c4b17825f3b0882ff46f7f62f087e7b2bc59db434b4a55641920b8b03f3dec6adf7031ccc2277c7a0b166f9c80
24 DIST kio-gdrive-1.3.0.tar.xz 51668 BLAKE2B a5c9bc347e5b40998449b613e8ad73c362d82d2486a1e91527f84acc5473d603b3cca422bd7c67cff28e49b08803904fdf752bec742bae752e868b8a84321684 SHA512 b0a6be2b59512d3faf6c677c6f3ffdcc9a38fff3a41d0bc6a29566008d7da3ab524fb189ddd219308a8ac8244fbed67c01da480e8193ed0aeb815fe64d72988a
25
26 diff --git a/kde-misc/kio-gdrive/files/kio-gdrive-1.2.6-refresh-credentials.patch b/kde-misc/kio-gdrive/files/kio-gdrive-1.2.6-refresh-credentials.patch
27 deleted file mode 100644
28 index 2d595882786..00000000000
29 --- a/kde-misc/kio-gdrive/files/kio-gdrive-1.2.6-refresh-credentials.patch
30 +++ /dev/null
31 @@ -1,101 +0,0 @@
32 -From 4ded388b2b2672f5f7fb953a0150a69fcfaa7cb0 Mon Sep 17 00:00:00 2001
33 -From: David Barchiesi <david@×××××××.si>
34 -Date: Mon, 8 Jul 2019 09:54:08 +0200
35 -Subject: Re get Google credentials from KAccounts when a refresh is needed.
36 -
37 -Summary: Currently, when the Google access token in use expires, the KIO slave silently ignores refreshing the token (only 'not implemented' gets logged) and fails all subsequent api requests. This patch prevents the slave from breaking by requesting new credentials from KAccounts.
38 -
39 -Test Plan: Open a Google Drive folder in Dolphin, wait until accounts token needs a refresh, open another Google Drive folder. The folder loads because a new access token was requested.
40 -
41 -Reviewers: elvisangelaccio
42 -
43 -Reviewed By: elvisangelaccio
44 -
45 -Subscribers: mck182, elvisangelaccio
46 -
47 -Differential Revision: https://phabricator.kde.org/D22009
48 ----
49 - src/kaccountsmanager.cpp | 45 ++++++++++++++++++++++++++++++++-------------
50 - src/kaccountsmanager.h | 2 ++
51 - 2 files changed, 34 insertions(+), 13 deletions(-)
52 -
53 -diff --git a/src/kaccountsmanager.cpp b/src/kaccountsmanager.cpp
54 -index 08272df..dc35852 100644
55 ---- a/src/kaccountsmanager.cpp
56 -+++ b/src/kaccountsmanager.cpp
57 -@@ -85,8 +85,19 @@ AccountPtr KAccountsManager::createAccount()
58 -
59 - AccountPtr KAccountsManager::refreshAccount(const AccountPtr &account)
60 - {
61 -- Q_UNUSED(account)
62 -- qCWarning(GDRIVE) << Q_FUNC_INFO << "not implemented.";
63 -+ const QString accountName = account->accountName();
64 -+ for (auto it = m_accounts.constBegin(); it != m_accounts.constEnd(); ++it) {
65 -+ if (it.value()->accountName() != accountName) {
66 -+ continue;
67 -+ }
68 -+
69 -+ const auto id = it.key();
70 -+ qCDebug(GDRIVE) << "Refreshing" << accountName;
71 -+ auto gapiAccount = getAccountCredentials(id, accountName);
72 -+ m_accounts.insert(id, gapiAccount);
73 -+ return gapiAccount;
74 -+ }
75 -+
76 - return {};
77 - }
78 -
79 -@@ -143,19 +154,27 @@ void KAccountsManager::loadAccounts()
80 - }
81 - qCDebug(GDRIVE) << account->displayName() << "supports gdrive!";
82 -
83 -- auto job = new GetCredentialsJob(id, nullptr);
84 -- job->exec();
85 -+ auto gapiAccount = getAccountCredentials(id, account->displayName());
86 -+ m_accounts.insert(id, gapiAccount);
87 -+ }
88 -+ }
89 -+}
90 -
91 -- auto gapiAccount = AccountPtr(new Account(account->displayName(),
92 -- job->credentialsData().value(QStringLiteral("AccessToken")).toString(),
93 -- job->credentialsData().value(QStringLiteral("RefreshToken")).toString()));
94 -+AccountPtr KAccountsManager::getAccountCredentials(Accounts::AccountId id, const QString& displayName)
95 -+{
96 -+ auto job = new GetCredentialsJob(id, nullptr);
97 -+ job->exec();
98 -
99 -- const auto scopes = job->credentialsData().value(QStringLiteral("Scope")).toStringList();
100 -- for (const auto &scope : scopes) {
101 -- gapiAccount->addScope(QUrl::fromUserInput(scope));
102 -- }
103 -+ auto gapiAccount = AccountPtr(new Account(displayName,
104 -+ job->credentialsData().value(QStringLiteral("AccessToken")).toString(),
105 -+ job->credentialsData().value(QStringLiteral("RefreshToken")).toString()));
106 -
107 -- m_accounts.insert(id, gapiAccount);
108 -- }
109 -+ const auto scopes = job->credentialsData().value(QStringLiteral("Scope")).toStringList();
110 -+ for (const auto &scope : scopes) {
111 -+ gapiAccount->addScope(QUrl::fromUserInput(scope));
112 - }
113 -+
114 -+ qCDebug(GDRIVE) << "Got account credentials for:" << gapiAccount->accountName() << ", accessToken:" << gapiAccount->accessToken() << ", refreshToken:" << gapiAccount->refreshToken();
115 -+
116 -+ return gapiAccount;
117 - }
118 -diff --git a/src/kaccountsmanager.h b/src/kaccountsmanager.h
119 -index 235d11a..d2dbc43 100644
120 ---- a/src/kaccountsmanager.h
121 -+++ b/src/kaccountsmanager.h
122 -@@ -40,6 +40,8 @@ public:
123 - private:
124 - void loadAccounts();
125 -
126 -+ KGAPI2::AccountPtr getAccountCredentials(Accounts::AccountId id, const QString& displayName);
127 -+
128 - QMap<Accounts::AccountId, KGAPI2::AccountPtr> m_accounts;
129 - };
130 -
131 ---
132 -cgit v1.1
133
134 diff --git a/kde-misc/kio-gdrive/kio-gdrive-1.2.7-r1.ebuild b/kde-misc/kio-gdrive/kio-gdrive-1.2.7-r1.ebuild
135 deleted file mode 100644
136 index e7eb5ed98d4..00000000000
137 --- a/kde-misc/kio-gdrive/kio-gdrive-1.2.7-r1.ebuild
138 +++ /dev/null
139 @@ -1,52 +0,0 @@
140 -# Copyright 1999-2020 Gentoo Authors
141 -# Distributed under the terms of the GNU General Public License v2
142 -
143 -EAPI=7
144 -
145 -ECM_HANDBOOK="forceoptional"
146 -ECM_TEST="optional"
147 -KFMIN=5.60.0
148 -QTMIN=5.12.3
149 -inherit ecm kde.org
150 -
151 -DESCRIPTION="KIO Slave for Google Drive service"
152 -HOMEPAGE="https://phabricator.kde.org/project/profile/72/"
153 -
154 -if [[ ${KDE_BUILD_TYPE} != live ]] ; then
155 - SRC_URI="mirror://kde/stable/${PN}/${PV}/src/${P}.tar.xz"
156 - KEYWORDS="amd64 ~arm64 x86"
157 -fi
158 -
159 -LICENSE="GPL-2+"
160 -SLOT="5"
161 -IUSE="+kaccounts"
162 -
163 -BDEPEND="dev-util/intltool"
164 -COMMON_DEPEND="
165 - >=dev-qt/qtwidgets-${QTMIN}:5
166 - =kde-apps/libkgapi-19.12*:5
167 - >=kde-frameworks/kcoreaddons-${KFMIN}:5
168 - >=kde-frameworks/ki18n-${KFMIN}:5
169 - >=kde-frameworks/kio-${KFMIN}:5
170 - >=kde-frameworks/knotifications-${KFMIN}:5
171 - kaccounts? ( =kde-apps/kaccounts-integration-19.12*:5 )
172 - !kaccounts? ( dev-libs/qtkeychain:=[qt5(+)] )
173 -"
174 -DEPEND="${COMMON_DEPEND}
175 - >=dev-qt/qtgui-${QTMIN}:5
176 - >=dev-qt/qtnetwork-${QTMIN}:5
177 -"
178 -RDEPEND="${COMMON_DEPEND}
179 - kaccounts? ( >=kde-apps/kaccounts-providers-19.08.0:5 )
180 -"
181 -
182 -DOCS=( README.md )
183 -
184 -PATCHES=( "${FILESDIR}"/${PN}-1.2.6-refresh-credentials.patch )
185 -
186 -src_configure() {
187 - local mycmakeargs=(
188 - $(cmake_use_find_package kaccounts KAccounts)
189 - )
190 - ecm_src_configure
191 -}