Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/kio/files/, kde-frameworks/kio/
Date: Sat, 16 May 2020 09:08:28
Message-Id: 1589620084.3b0b1117d4dae8c28dd3e0913e188841784b5e42.asturm@gentoo
1 commit: 3b0b1117d4dae8c28dd3e0913e188841784b5e42
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sat May 16 09:06:26 2020 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sat May 16 09:08:04 2020 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b0b1117
7
8 kde-frameworks/kio: Drop 5.70.0-r1
9
10 Package-Manager: Portage-2.3.99, Repoman-2.3.22
11 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
12
13 kde-frameworks/kio/Manifest | 1 -
14 .../kio/files/kio-5.70.0-fix-run-in-terminal.patch | 89 --------------------
15 kde-frameworks/kio/kio-5.70.0-r1.ebuild | 96 ----------------------
16 3 files changed, 186 deletions(-)
17
18 diff --git a/kde-frameworks/kio/Manifest b/kde-frameworks/kio/Manifest
19 index c9a070ae5bc..ee406225294 100644
20 --- a/kde-frameworks/kio/Manifest
21 +++ b/kde-frameworks/kio/Manifest
22 @@ -1,3 +1,2 @@
23 DIST kio-5.67.0.tar.xz 3223032 BLAKE2B 297ebb3f12282951e85edc4eb9869ff3b6fd9536aa312f32ab7403337bb13a142c37edc03ae2295fe55cc935d6952c70e0efda95a3fcc280709e6ef33c30ea04 SHA512 baf1e6abc6ae1ffa4010245a79cb676787217d365fb033f620a9da293565ec267186afaac08791104cead3ce5c87d3a76ec89b796355361b326b16f044691d72
24 -DIST kio-5.70.0.tar.xz 3200704 BLAKE2B 23540865ab0310fb3564cfcc445602aab46c8cdbc3b1d40e9428e13a46f9e3795a1fca853028226cb9e3313ef3d22a5347a9cfc9b058e1959bf4dbf861b0792f SHA512 80e8e8bcd49c09228c9a439f97aecca784880b852eeb82c84ec44868de44d2b0c5a63a4d220e6c2f2c264b7e87fe0d5b639f652b1f50c9fe1b1b941b366d929a
25 DIST kio-5.70.1.tar.xz 3200752 BLAKE2B cc56ee412cb647c8921a36c3e47747640d5574444630f70887401c69ca1a367205adf4d7cd45b721abd103efcb1265c956654fce2dfc5b3fe6241413c51f1b88 SHA512 12287f330e8e7b9ac9c0ff24c1f8f980fbd338ce3f341d8005d6dc6e3acdf96da07adeea693b3361909819d8814192503e8d2c93ca9b9958d985f0d09f202661
26
27 diff --git a/kde-frameworks/kio/files/kio-5.70.0-fix-run-in-terminal.patch b/kde-frameworks/kio/files/kio-5.70.0-fix-run-in-terminal.patch
28 deleted file mode 100644
29 index 4b9b8bf5817..00000000000
30 --- a/kde-frameworks/kio/files/kio-5.70.0-fix-run-in-terminal.patch
31 +++ /dev/null
32 @@ -1,89 +0,0 @@
33 -From 6452a34cf01d03d3167b38bc28a2fe8e13569021 Mon Sep 17 00:00:00 2001
34 -From: Jonathan Marten <jjm@×××××××××××.uk>
35 -Date: Thu, 14 May 2020 19:17:54 +0100
36 -Subject: Fix service file specifying 'Run in terminal' giving an error code
37 - 100
38 -
39 -Happens because KIO::DesktopExecParser::resultingArguments() prepends
40 -the terminal application to the command line. If this is a relative path,
41 -as it is most likely to be (and will be in the default 'konsole' case),
42 -the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered
43 -and the job aborts with an error.
44 -
45 -Expand the specified terminal executable into a full path in resultingArguments(),
46 -and return an error immediately if it cannot be found. This full terminal path
47 -is not relative for the KProcessRunner::KProcessRunner() check and does not fail.
48 -
49 -Check that resultingArguments() is not empty (an error return) before accessing
50 -the first word of the command, so that it does not assert if the list is empty.
51 -Also only call resultingArguments() once.
52 -
53 -BUG: 421374
54 -FIXED-IN: 5.71
55 -
56 -Differential Revision: https://phabricator.kde.org/D29738
57 ----
58 - src/core/desktopexecparser.cpp | 10 +++++++++-
59 - src/gui/kprocessrunner.cpp | 17 +++++++++--------
60 - 2 files changed, 18 insertions(+), 9 deletions(-)
61 -
62 -diff --git a/src/core/desktopexecparser.cpp b/src/core/desktopexecparser.cpp
63 -index a3b5219..fcf83d9 100644
64 ---- a/src/core/desktopexecparser.cpp
65 -+++ b/src/core/desktopexecparser.cpp
66 -@@ -421,7 +421,15 @@ QStringList KIO::DesktopExecParser::resultingArguments() const
67 - if (d->service.terminal()) {
68 - KConfigGroup cg(KSharedConfig::openConfig(), "General");
69 - QString terminal = cg.readPathEntry("TerminalApplication", QStringLiteral("konsole"));
70 -- if (terminal == QLatin1String("konsole")) {
71 -+ const bool isKonsole = (terminal == QLatin1String("konsole"));
72 -+
73 -+ QString terminalPath = QStandardPaths::findExecutable(terminal);
74 -+ if (terminalPath.isEmpty()) {
75 -+ qCWarning(KIO_CORE) << "Terminal" << terminal << "not found, service" << d->service.name();
76 -+ return QStringList();
77 -+ }
78 -+ terminal = terminalPath;
79 -+ if (isKonsole) {
80 - if (!d->service.workingDirectory().isEmpty()) {
81 - terminal += QLatin1String(" --workdir ") + KShell::quoteArg(d->service.workingDirectory());
82 - }
83 -diff --git a/src/gui/kprocessrunner.cpp b/src/gui/kprocessrunner.cpp
84 -index a4701a7..cc57b54 100644
85 ---- a/src/gui/kprocessrunner.cpp
86 -+++ b/src/gui/kprocessrunner.cpp
87 -@@ -88,9 +88,17 @@ KProcessRunner::KProcessRunner(const KService::Ptr &service, const QList<QUrl> &
88 - emitDelayedError(i18n("The desktop entry file\n%1\nis not valid.", service->entryPath()));
89 - return;
90 - }
91 -+
92 - KIO::DesktopExecParser execParser(*service, urls);
93 -+ execParser.setUrlsAreTempFiles(flags & KIO::ApplicationLauncherJob::DeleteTemporaryFiles);
94 -+ execParser.setSuggestedFileName(suggestedFileName);
95 -+ const QStringList args = execParser.resultingArguments();
96 -+ if (args.isEmpty()) {
97 -+ emitDelayedError(i18n("Error processing Exec field in %1", service->entryPath()));
98 -+ return;
99 -+ }
100 -
101 -- const QString realExecutable = execParser.resultingArguments().at(0);
102 -+ const QString realExecutable = args.at(0);
103 - // realExecutable is a full path if DesktopExecParser was able to locate it. Otherwise it's still relative, which is a bad sign.
104 - if (QDir::isRelativePath(realExecutable) || !QFileInfo(realExecutable).isExecutable()) {
105 - // Does it really not exist, or is it non-executable? (bug #415567)
106 -@@ -103,13 +111,6 @@ KProcessRunner::KProcessRunner(const KService::Ptr &service, const QList<QUrl> &
107 - return;
108 - }
109 -
110 -- execParser.setUrlsAreTempFiles(flags & KIO::ApplicationLauncherJob::DeleteTemporaryFiles);
111 -- execParser.setSuggestedFileName(suggestedFileName);
112 -- const QStringList args = execParser.resultingArguments();
113 -- if (args.isEmpty()) {
114 -- emitDelayedError(i18n("Error processing Exec field in %1", service->entryPath()));
115 -- return;
116 -- }
117 - //qDebug() << "KProcess args=" << args;
118 - *m_process << args;
119 -
120 ---
121 -cgit v1.1
122
123 diff --git a/kde-frameworks/kio/kio-5.70.0-r1.ebuild b/kde-frameworks/kio/kio-5.70.0-r1.ebuild
124 deleted file mode 100644
125 index c95390be6b2..00000000000
126 --- a/kde-frameworks/kio/kio-5.70.0-r1.ebuild
127 +++ /dev/null
128 @@ -1,96 +0,0 @@
129 -# Copyright 1999-2020 Gentoo Authors
130 -# Distributed under the terms of the GNU General Public License v2
131 -
132 -EAPI=7
133 -
134 -ECM_DESIGNERPLUGIN="true"
135 -ECM_TEST="forceoptional"
136 -PVCUT=$(ver_cut 1-2)
137 -QTMIN=5.12.3
138 -VIRTUALX_REQUIRED="test"
139 -inherit ecm kde.org xdg-utils
140 -
141 -DESCRIPTION="Framework providing transparent file and data management"
142 -LICENSE="LGPL-2+"
143 -KEYWORDS="~amd64 ~arm ~arm64 ~ppc64 ~x86"
144 -IUSE="acl +handbook kerberos +kwallet X"
145 -
146 -# drop qtnetwork subslot operator when QT_MINIMAL >= 5.15.0
147 -RDEPEND="
148 - dev-libs/libxml2
149 - dev-libs/libxslt
150 - >=dev-qt/qtdbus-${QTMIN}:5
151 - >=dev-qt/qtdeclarative-${QTMIN}:5
152 - >=dev-qt/qtgui-${QTMIN}:5
153 - >=dev-qt/qtnetwork-${QTMIN}:5=[ssl]
154 - >=dev-qt/qtwidgets-${QTMIN}:5
155 - >=dev-qt/qtxml-${QTMIN}:5
156 - =kde-frameworks/kauth-${PVCUT}*:5
157 - =kde-frameworks/karchive-${PVCUT}*:5
158 - =kde-frameworks/kbookmarks-${PVCUT}*:5
159 - =kde-frameworks/kcodecs-${PVCUT}*:5
160 - =kde-frameworks/kcompletion-${PVCUT}*:5
161 - =kde-frameworks/kconfig-${PVCUT}*:5
162 - =kde-frameworks/kconfigwidgets-${PVCUT}*:5
163 - =kde-frameworks/kcoreaddons-${PVCUT}*:5
164 - =kde-frameworks/kcrash-${PVCUT}*:5
165 - =kde-frameworks/kdbusaddons-${PVCUT}*:5
166 - =kde-frameworks/ki18n-${PVCUT}*:5
167 - =kde-frameworks/kiconthemes-${PVCUT}*:5
168 - =kde-frameworks/kitemviews-${PVCUT}*:5
169 - =kde-frameworks/kjobwidgets-${PVCUT}*:5
170 - =kde-frameworks/knotifications-${PVCUT}*:5
171 - =kde-frameworks/kservice-${PVCUT}*:5
172 - =kde-frameworks/ktextwidgets-${PVCUT}*:5
173 - =kde-frameworks/kwidgetsaddons-${PVCUT}*:5
174 - =kde-frameworks/kwindowsystem-${PVCUT}*:5
175 - =kde-frameworks/kxmlgui-${PVCUT}*:5
176 - =kde-frameworks/solid-${PVCUT}*:5
177 - acl? (
178 - sys-apps/attr
179 - virtual/acl
180 - )
181 - handbook? ( =kde-frameworks/kdoctools-${PVCUT}*:5 )
182 - kerberos? ( virtual/krb5 )
183 - kwallet? ( =kde-frameworks/kwallet-${PVCUT}*:5 )
184 - X? ( >=dev-qt/qtx11extras-${QTMIN}:5 )
185 -"
186 -DEPEND="${RDEPEND}
187 - >=dev-qt/qtconcurrent-${QTMIN}:5
188 - test? ( sys-libs/zlib )
189 - X? (
190 - x11-base/xorg-proto
191 - x11-libs/libX11
192 - x11-libs/libXrender
193 - )
194 -"
195 -PDEPEND="
196 - >=kde-frameworks/kded-${PVCUT}:5
197 -"
198 -
199 -# tests hang
200 -RESTRICT+=" test"
201 -
202 -PATCHES=( "${FILESDIR}"/${P}-fix-run-in-terminal.patch )
203 -
204 -src_configure() {
205 - local mycmakeargs=(
206 - $(cmake_use_find_package acl ACL)
207 - $(cmake_use_find_package handbook KF5DocTools)
208 - $(cmake_use_find_package kerberos GSSAPI)
209 - $(cmake_use_find_package kwallet KF5Wallet)
210 - $(cmake_use_find_package X X11)
211 - )
212 -
213 - ecm_src_configure
214 -}
215 -
216 -pkg_postinst() {
217 - ecm_pkg_postinst
218 - xdg_desktop_database_update
219 -}
220 -
221 -pkg_postrm() {
222 - ecm_pkg_postrm
223 - xdg_desktop_database_update
224 -}