Gentoo Archives: gentoo-commits

From: "Michal Gorny (mgorny)" <mgorny@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog distutils-r1.eclass
Date: Thu, 01 Aug 2013 13:02:35
Message-Id: 20130801130232.ACE4021710@flycatcher.gentoo.org
1 mgorny 13/08/01 13:02:32
2
3 Modified: ChangeLog distutils-r1.eclass
4 Log:
5 Shout QA warnings when _all() phases do not call the default impls. Bug #478442.
6
7 Revision Changes Path
8 1.909 eclass/ChangeLog
9
10 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.909&view=markup
11 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.909&content-type=text/plain
12 diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?r1=1.908&r2=1.909
13
14 Index: ChangeLog
15 ===================================================================
16 RCS file: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v
17 retrieving revision 1.908
18 retrieving revision 1.909
19 diff -u -r1.908 -r1.909
20 --- ChangeLog 1 Aug 2013 12:49:42 -0000 1.908
21 +++ ChangeLog 1 Aug 2013 13:02:32 -0000 1.909
22 @@ -1,6 +1,10 @@
23 # ChangeLog for eclass directory
24 # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
25 -# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.908 2013/08/01 12:49:42 mgorny Exp $
26 +# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.909 2013/08/01 13:02:32 mgorny Exp $
27 +
28 + 01 Aug 2013; Michał Górny <mgorny@g.o> distutils-r1.eclass:
29 + Shout QA warnings when _all() phases do not call the default impls. Bug
30 + #478442.
31
32 01 Aug 2013; Michał Górny <mgorny@g.o> python-any-r1.eclass:
33 python-any-r1: bail out on invalid PYTHON_COMPAT.
34
35
36
37 1.74 eclass/distutils-r1.eclass
38
39 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/distutils-r1.eclass?rev=1.74&view=markup
40 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/distutils-r1.eclass?rev=1.74&content-type=text/plain
41 diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/distutils-r1.eclass?r1=1.73&r2=1.74
42
43 Index: distutils-r1.eclass
44 ===================================================================
45 RCS file: /var/cvsroot/gentoo-x86/eclass/distutils-r1.eclass,v
46 retrieving revision 1.73
47 retrieving revision 1.74
48 diff -u -r1.73 -r1.74
49 --- distutils-r1.eclass 21 Jul 2013 19:00:56 -0000 1.73
50 +++ distutils-r1.eclass 1 Aug 2013 13:02:32 -0000 1.74
51 @@ -1,6 +1,6 @@
52 # Copyright 1999-2013 Gentoo Foundation
53 # Distributed under the terms of the GNU General Public License v2
54 -# $Header: /var/cvsroot/gentoo-x86/eclass/distutils-r1.eclass,v 1.73 2013/07/21 19:00:56 mgorny Exp $
55 +# $Header: /var/cvsroot/gentoo-x86/eclass/distutils-r1.eclass,v 1.74 2013/08/01 13:02:32 mgorny Exp $
56
57 # @ECLASS: distutils-r1
58 # @MAINTAINER:
59 @@ -344,6 +344,8 @@
60 # create source copies for each implementation
61 python_copy_sources
62 fi
63 +
64 + _DISTUTILS_DEFAULT_CALLED=1
65 }
66
67 # @FUNCTION: distutils-r1_python_prepare
68 @@ -494,6 +496,8 @@
69 doins -r "${EXAMPLES[@]}"
70 docompress -x "${INSDESTTREE}"
71 fi
72 +
73 + _DISTUTILS_DEFAULT_CALLED=1
74 }
75
76 # @FUNCTION: distutils-r1_run_phase
77 @@ -586,6 +590,8 @@
78 distutils-r1_src_prepare() {
79 debug-print-function ${FUNCNAME} "${@}"
80
81 + local _DISTUTILS_DEFAULT_CALLED
82 +
83 # common preparations
84 if declare -f python_prepare_all >/dev/null; then
85 python_prepare_all
86 @@ -593,6 +599,10 @@
87 distutils-r1_python_prepare_all
88 fi
89
90 + if [[ ! ${_DISTUTILS_DEFAULT_CALLED} ]]; then
91 + eqawarn "QA warning: python_prepare_all() didn't call distutils-r1_python_prepare_all"
92 + fi
93 +
94 if declare -f python_prepare >/dev/null; then
95 _distutils-r1_run_foreach_impl python_prepare
96 fi
97 @@ -643,11 +653,17 @@
98 _distutils-r1_run_foreach_impl distutils-r1_python_install
99 fi
100
101 + local _DISTUTILS_DEFAULT_CALLED
102 +
103 if declare -f python_install_all >/dev/null; then
104 _distutils-r1_run_common_phase python_install_all
105 else
106 _distutils-r1_run_common_phase distutils-r1_python_install_all
107 fi
108 +
109 + if [[ ! ${_DISTUTILS_DEFAULT_CALLED} ]]; then
110 + eqawarn "QA warning: python_install_all() didn't call distutils-r1_python_install_all"
111 + fi
112 }
113
114 _DISTUTILS_R1=1