| 1 |
commit: 249ecdadd63b2b743d670f2776fe976d22e8808c |
| 2 |
Author: Michał Górny <mgorny <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Wed Aug 30 08:58:36 2017 +0000 |
| 4 |
Commit: Michał Górny <mgorny <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Thu Aug 31 14:06:14 2017 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=249ecdad |
| 7 |
|
| 8 |
ebuild.sh: Explicitly ban get_libdir in global scope |
| 9 |
|
| 10 |
The value of get_libdir depends on the profile, and so it is not useful |
| 11 |
for dependency calculations. Furthermore, it seems that Portage does |
| 12 |
not handle defining it in global scope well due to EAPI checking magic. |
| 13 |
Ban it completely where it is defined as EAPI function to let developers |
| 14 |
catch their mistakes early rather than see them as 'command not found' |
| 15 |
errors during dependency calculation / cache updates. |
| 16 |
|
| 17 |
Bug: https://bugs.gentoo.org/629010 |
| 18 |
Closes: https://github.com/gentoo/portage/pull/197 |
| 19 |
Reviewed-by: Zac Medico <zmedico <AT> gentoo.org> |
| 20 |
|
| 21 |
bin/ebuild.sh | 1 + |
| 22 |
1 file changed, 1 insertion(+) |
| 23 |
|
| 24 |
diff --git a/bin/ebuild.sh b/bin/ebuild.sh |
| 25 |
index a400ef72e..f1ac3f278 100755 |
| 26 |
--- a/bin/ebuild.sh |
| 27 |
+++ b/bin/ebuild.sh |
| 28 |
@@ -66,6 +66,7 @@ else |
| 29 |
use useq usev use_with use_enable" |
| 30 |
___eapi_has_usex && funcs+=" usex" |
| 31 |
___eapi_has_in_iuse && funcs+=" in_iuse" |
| 32 |
+ ___eapi_has_get_libdir && funcs+=" get_libdir" |
| 33 |
# These functions die because calls to them during the "depend" phase |
| 34 |
# are considered to be severe QA violations. |
| 35 |
funcs+=" best_version has_version portageq" |
Archives