1 |
commit: 65217c376e5339336f01073b3312fed51654cdaf |
2 |
Author: Thomas Bracht Laumann Jespersen <t <AT> laumann <DOT> xyz> |
3 |
AuthorDate: Wed Mar 30 20:48:59 2022 +0000 |
4 |
Commit: Sam James <sam <AT> gentoo <DOT> org> |
5 |
CommitDate: Thu Apr 7 02:21:39 2022 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65217c37 |
7 |
|
8 |
media-libs/openjpeg: Fix segfault, security bug 832007 |
9 |
|
10 |
See: https://github.com/uclouvain/openjpeg/commit/0afbdcf3e6d0d2bd2e16a0c4d513ee3cf86e460d |
11 |
Bug: https://bugs.gentoo.org/832007 |
12 |
Signed-off-by: Thomas Bracht Laumann Jespersen <t <AT> laumann.xyz> |
13 |
Closes: https://github.com/gentoo/gentoo/pull/24822 |
14 |
Signed-off-by: Sam James <sam <AT> gentoo.org> |
15 |
|
16 |
.../files/openjpeg-2.4.0-r2-fix-segfault.patch | 17 +++ |
17 |
media-libs/openjpeg/openjpeg-2.4.0-r2.ebuild | 140 +++++++++++++++++++++ |
18 |
2 files changed, 157 insertions(+) |
19 |
|
20 |
diff --git a/media-libs/openjpeg/files/openjpeg-2.4.0-r2-fix-segfault.patch b/media-libs/openjpeg/files/openjpeg-2.4.0-r2-fix-segfault.patch |
21 |
new file mode 100644 |
22 |
index 000000000000..86e1c1fe39cc |
23 |
--- /dev/null |
24 |
+++ b/media-libs/openjpeg/files/openjpeg-2.4.0-r2-fix-segfault.patch |
25 |
@@ -0,0 +1,17 @@ |
26 |
+Upstream: https://github.com/uclouvain/openjpeg/commit/0afbdcf3e6d0d2bd2e16a0c4d513ee3cf86e460d |
27 |
+From: xiaoxiaoafeifei <lliangliang2007@×××.com> |
28 |
+Date: Wed, 14 Jul 2021 09:35:13 +0800 |
29 |
+Subject: [PATCH] Fix segfault in src/bin/jp2/opj_decompress.c due to |
30 |
+ uninitialized pointer (fixes #1368) (#1369) |
31 |
+ |
32 |
+--- a/src/bin/jp2/opj_decompress.c |
33 |
++++ b/src/bin/jp2/opj_decompress.c |
34 |
+@@ -1356,7 +1356,7 @@ int main(int argc, char **argv) |
35 |
+ int it_image; |
36 |
+ num_images = get_num_images(img_fol.imgdirpath); |
37 |
+ |
38 |
+- dirptr = (dircnt_t*)malloc(sizeof(dircnt_t)); |
39 |
++ dirptr = (dircnt_t*)calloc(1, sizeof(dircnt_t)); |
40 |
+ if (!dirptr) { |
41 |
+ destroy_parameters(¶meters); |
42 |
+ return EXIT_FAILURE; |
43 |
|
44 |
diff --git a/media-libs/openjpeg/openjpeg-2.4.0-r2.ebuild b/media-libs/openjpeg/openjpeg-2.4.0-r2.ebuild |
45 |
new file mode 100644 |
46 |
index 000000000000..90e97e2e3bce |
47 |
--- /dev/null |
48 |
+++ b/media-libs/openjpeg/openjpeg-2.4.0-r2.ebuild |
49 |
@@ -0,0 +1,140 @@ |
50 |
+# Copyright 1999-2022 Gentoo Authors |
51 |
+# Distributed under the terms of the GNU General Public License v2 |
52 |
+ |
53 |
+EAPI=7 |
54 |
+ |
55 |
+CMAKE_ECLASS=cmake |
56 |
+inherit cmake-multilib flag-o-matic |
57 |
+ |
58 |
+# Make sure that test data are not newer than release; |
59 |
+# otherwise we will see "Found-But-No-Test" test failures! |
60 |
+MY_TESTDATA_COMMIT="cd724fb1f93e6af41ebc68c4904f4bf2a4cd1e60" |
61 |
+ |
62 |
+DESCRIPTION="Open-source JPEG 2000 library" |
63 |
+HOMEPAGE="https://www.openjpeg.org" |
64 |
+SRC_URI="https://github.com/uclouvain/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz |
65 |
+ test? ( https://github.com/uclouvain/openjpeg-data/archive/${MY_TESTDATA_COMMIT}.tar.gz -> ${PN}-data_20201130.tar.gz )" |
66 |
+ |
67 |
+LICENSE="BSD-2" |
68 |
+SLOT="2/7" # based on SONAME |
69 |
+KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~riscv ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" |
70 |
+IUSE="doc static-libs test" |
71 |
+RESTRICT="!test? ( test )" |
72 |
+ |
73 |
+RDEPEND=" |
74 |
+ media-libs/lcms:2 |
75 |
+ media-libs/libpng:0= |
76 |
+ media-libs/tiff:0 |
77 |
+ sys-libs/zlib:=" |
78 |
+DEPEND="${RDEPEND}" |
79 |
+BDEPEND=" |
80 |
+ doc? ( app-doc/doxygen )" |
81 |
+ |
82 |
+DOCS=( AUTHORS.md CHANGELOG.md NEWS.md README.md THANKS.md ) |
83 |
+ |
84 |
+PATCHES=( |
85 |
+ "${FILESDIR}/${PN}-2.4.0-r1-gnuinstalldirs.patch" # bug 667150 |
86 |
+ "${FILESDIR}/${PN}-2.4.0-fix-r2-segfault.patch" # bug 832007 |
87 |
+) |
88 |
+ |
89 |
+src_prepare() { |
90 |
+ if use test; then |
91 |
+ mv "${WORKDIR}"/openjpeg-data-${MY_TESTDATA_COMMIT} "${WORKDIR}"/data || |
92 |
+ die "Failed to rename test data" |
93 |
+ fi |
94 |
+ |
95 |
+ cmake_src_prepare |
96 |
+} |
97 |
+ |
98 |
+multilib_src_configure() { |
99 |
+ local mycmakeargs=( |
100 |
+ -DBUILD_PKGCONFIG_FILES=ON # always build pkgconfig files, bug #539834 |
101 |
+ -DBUILD_TESTING="$(multilib_native_usex test)" |
102 |
+ -DBUILD_DOC=$(multilib_native_usex doc ON OFF) |
103 |
+ -DBUILD_CODEC=$(multilib_is_native_abi && echo ON || echo OFF) |
104 |
+ -DBUILD_STATIC_LIBS=$(usex static-libs) |
105 |
+ ) |
106 |
+ |
107 |
+ # Cheat a little bit and force disabling fixed point magic |
108 |
+ # The test suite is extremely fragile to small changes |
109 |
+ # bug 715130, bug 715422 |
110 |
+ # https://github.com/uclouvain/openjpeg/issues/1017 |
111 |
+ multilib_is_native_abi && use test && append-cflags "-ffp-contract=off" |
112 |
+ |
113 |
+ cmake_src_configure |
114 |
+} |
115 |
+ |
116 |
+multilib_src_test() { |
117 |
+ if ! multilib_is_native_abi ; then |
118 |
+ elog "Cannot run tests for non-multilib abi." |
119 |
+ return 0 |
120 |
+ fi |
121 |
+ |
122 |
+ local myctestargs= |
123 |
+ |
124 |
+ pushd "${BUILD_DIR}" > /dev/null || die |
125 |
+ [[ -e CTestTestfile.cmake ]] || die "Test suite not available! Check source!" |
126 |
+ |
127 |
+ [[ -n ${TEST_VERBOSE} ]] && myctestargs+=( --extra-verbose --output-on-failure ) |
128 |
+ |
129 |
+ echo ctest "${myctestargs[@]}" "$@" |
130 |
+ if ctest "${myctestargs[@]}" "$@" ; then |
131 |
+ einfo "Tests succeeded." |
132 |
+ popd > /dev/null || die |
133 |
+ return 0 |
134 |
+ else |
135 |
+ local FAILEDTEST_LOG="${BUILD_DIR}/Testing/Temporary/LastTestsFailed.log" |
136 |
+ |
137 |
+ if [[ ! -f "${FAILEDTEST_LOG}" ]] ; then |
138 |
+ # Should never happen |
139 |
+ die "Cannot analyze test failures: LastTestsFailed.log is missing!" |
140 |
+ fi |
141 |
+ |
142 |
+ echo "" |
143 |
+ einfo "Note: Upstream is maintaining a list of known test failures." |
144 |
+ einfo "We will now compare our test results against this list and sort out any known failure." |
145 |
+ |
146 |
+ local KNOWN_FAILURES_LIST="${T}/known_failures_compiled.txt" |
147 |
+ cat "${S}/tools/travis-ci/knownfailures-all.txt" > "${KNOWN_FAILURES_LIST}" || die |
148 |
+ |
149 |
+ local ARCH_SPECIFIC_FAILURES= |
150 |
+ if use amd64 ; then |
151 |
+ ARCH_SPECIFIC_FAILURES="$(find "${S}/tools/travis-ci/" -name 'knownfailures-*x86_64*.txt' -print0 | sort -z | tail -z -n 1 | tr -d '\0')" |
152 |
+ elif use x86 || use arm || use arm64; then |
153 |
+ ARCH_SPECIFIC_FAILURES="$(find "${S}/tools/travis-ci/" -name 'knownfailures-*i386*.txt' -print0 | sort -z | tail -z -n 1 | tr -d '\0')" |
154 |
+ fi |
155 |
+ |
156 |
+ if [[ -f "${ARCH_SPECIFIC_FAILURES}" ]] ; then |
157 |
+ einfo "Adding architecture specific failures (${ARCH_SPECIFIC_FAILURES}) to known failures list ..." |
158 |
+ cat "${ARCH_SPECIFIC_FAILURES}" >> "${KNOWN_FAILURES_LIST}" || die |
159 |
+ fi |
160 |
+ |
161 |
+ # Logic copied from $S/tools/travis-ci/run.sh |
162 |
+ local FAILEDTEST= |
163 |
+ local FAILURES_LOG="${BUILD_DIR}/Testing/Temporary/failures.txt" |
164 |
+ local HAS_UNKNOWN_TEST_FAILURES=0 |
165 |
+ |
166 |
+ echo "" |
167 |
+ |
168 |
+ awk -F: '{ print $2 }' "${FAILEDTEST_LOG}" > "${FAILURES_LOG}" |
169 |
+ while read FAILEDTEST; do |
170 |
+ # is this failure known? |
171 |
+ if grep -x "${FAILEDTEST}" "${KNOWN_FAILURES_LIST}" > /dev/null; then |
172 |
+ ewarn "Test '${FAILEDTEST}' is known to fail, ignoring ..." |
173 |
+ continue |
174 |
+ fi |
175 |
+ |
176 |
+ eerror "New/unknown test failure found: '${FAILEDTEST}'" |
177 |
+ HAS_UNKNOWN_TEST_FAILURES=1 |
178 |
+ done < "${FAILURES_LOG}" |
179 |
+ |
180 |
+ if [[ ${HAS_UNKNOWN_TEST_FAILURES} -ne 0 ]]; then |
181 |
+ die "Test suite failed. New/unknown test failure(s) found!" |
182 |
+ else |
183 |
+ echo "" |
184 |
+ einfo "Test suite passed. No new/unknown test failure(s) found!" |
185 |
+ fi |
186 |
+ |
187 |
+ return 0 |
188 |
+ fi |
189 |
+} |