[gentoo-commits] gentoo-x86 commit in dev-cpp/threadpool/files: threadpool-0.2.5-memleak.patch

[Robin H. Johnson (robbat2)]

robbat2     12/09/29 23:14:38

  Added:                threadpool-0.2.5-memleak.patch
  Log:
  Initial commit. Ebuild by Robin H. Johnson <robbat2@g.o>.
  
  (Portage version: 2.2.0_alpha121/cvs/Linux x86_64)

Revision  Changes    Path
1.1                  dev-cpp/threadpool/files/threadpool-0.2.5-memleak.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-cpp/threadpool/files/threadpool-0.2.5-memleak.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-cpp/threadpool/files/threadpool-0.2.5-memleak.patch?rev=1.1&content-type=text/plain

Index: threadpool-0.2.5-memleak.patch
===================================================================
Fix memleak due circular references blocking garbage collection.

http://www.cplusplus.com/forum/general/56971/ provides a testcase for a memory
leak with the threadpool due to shared_ptr usage.

I really needed threadpool to work for me, so I traced & fixed it as best as
possible. When the threadpool is being destroyed, your threads should have
terminated already. Do so deliberately if not done yet, so that they free the
memory.

Signed-off-by: Robin H. Johnson <robbat2@g.o>

--- threadpool-0_2_5-src/threadpool/boost/threadpool/detail/pool_core.hpp	2012-09-27 22:33:21.098626892 -0700
+++ threadpool-0_2_5-src/threadpool/boost/threadpool/detail/pool_core.hpp	2012-09-27 22:51:12.291997839 -0700
@@ -150,6 +150,7 @@
     /// Destructor.
     ~pool_core()
     {
+		terminate_all_workers(true);
     }
 
     /*! Gets the size controller which manages the number of threads in the pool.