Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/kde:master commit in: kde-apps/okular/, kde-apps/okular/files/
Date: Sun, 19 Aug 2018 19:42:53
Message-Id: 1534707736.43a315f7f04b4111d6f8577c1606c0eefcb63f04.asturm@gentoo
1 commit: 43a315f7f04b4111d6f8577c1606c0eefcb63f04
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sun Aug 19 19:42:16 2018 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sun Aug 19 19:42:16 2018 +0000
6 URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=43a315f7
7
8 kde-apps/okular: Fix USE=-test for okular-9999
9
10 Closes: https://bugs.gentoo.org/664020
11 Package-Manager: Portage-2.3.47, Repoman-2.3.10
12
13 ...ular-tests.patch => okular-18.08.0-tests.patch} | 0
14 kde-apps/okular/files/okular-tests.patch | 119 +++------------------
15 kde-apps/okular/okular-18.08.0.ebuild | 2 +-
16 kde-apps/okular/okular-18.08.49.9999.ebuild | 2 +-
17 kde-apps/okular/okular-9999.ebuild | 5 +-
18 5 files changed, 18 insertions(+), 110 deletions(-)
19
20 diff --git a/kde-apps/okular/files/okular-tests.patch b/kde-apps/okular/files/okular-18.08.0-tests.patch
21 similarity index 100%
22 copy from kde-apps/okular/files/okular-tests.patch
23 copy to kde-apps/okular/files/okular-18.08.0-tests.patch
24
25 diff --git a/kde-apps/okular/files/okular-tests.patch b/kde-apps/okular/files/okular-tests.patch
26 index 0e2cdaecd4..2b61715050 100644
27 --- a/kde-apps/okular/files/okular-tests.patch
28 +++ b/kde-apps/okular/files/okular-tests.patch
29 @@ -1,112 +1,17 @@
30 -From 5f093fa9798ad30cda115cea573d18296696a0a9 Mon Sep 17 00:00:00 2001
31 -From: Andreas Sturmlechner <andreas.sturmlechner@×××××.com>
32 -Date: Thu, 12 Oct 2017 14:09:09 +0200
33 -Subject: [PATCH] Move tests into existing (auto)tests subdirectories
34 -
35 ----
36 - generators/chm/CMakeLists.txt | 12 +++---------
37 - generators/chm/autotests/CMakeLists.txt | 8 ++++++++
38 - generators/chm/autotests/chmgeneratortest.cpp | 2 +-
39 - generators/kimgio/CMakeLists.txt | 6 +-----
40 - generators/kimgio/tests/CMakeLists.txt | 5 +++++
41 - generators/kimgio/tests/kimgiotest.cpp | 2 +-
42 - 6 files changed, 19 insertions(+), 16 deletions(-)
43 - create mode 100644 generators/chm/autotests/CMakeLists.txt
44 - create mode 100644 generators/kimgio/tests/CMakeLists.txt
45 -
46 -diff --git a/generators/chm/CMakeLists.txt b/generators/chm/CMakeLists.txt
47 -index 9d82b9394..b3a33afe4 100644
48 ---- a/generators/chm/CMakeLists.txt
49 -+++ b/generators/chm/CMakeLists.txt
50 -@@ -30,15 +30,9 @@ set(okularGenerator_chmlib_SRCS
51 - okular_add_generator(okularGenerator_chmlib ${okularGenerator_chmlib_SRCS})
52 - target_link_libraries(okularGenerator_chmlib okularcore ${CHM_LIBRARY} ${LIBZIP_LIBRARY} KF5::KHtml)
53 +--- a/generators/epub/CMakeLists.txt 2018-08-19 21:34:51.151645090 +0200
54 ++++ b/generators/epub/CMakeLists.txt 2018-08-19 21:36:28.771109586 +0200
55 +@@ -23,12 +23,13 @@
56 +
57 + ########### autotests ###############
58
59 --########### autotests ###############
60 --
61 --add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
62 --ecm_add_test(autotests/chmgeneratortest.cpp
63 -- TEST_NAME "chmgeneratortest"
64 -- LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore
65 --)
66 --
67 --target_compile_definitions(chmgeneratortest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_chmlib>")
68 +if(BUILD_TESTING)
69 -+ add_subdirectory(autotests)
70 + add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
71 + ecm_add_test(autotests/epubgeneratortest.cpp
72 + TEST_NAME "epubgeneratortest"
73 + LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore
74 + )
75 +-
76 +endif()
77
78 ########### install files ###############
79 - install( FILES okularChm.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
80 -diff --git a/generators/chm/autotests/CMakeLists.txt b/generators/chm/autotests/CMakeLists.txt
81 -new file mode 100644
82 -index 000000000..59753ca45
83 ---- /dev/null
84 -+++ b/generators/chm/autotests/CMakeLists.txt
85 -@@ -0,0 +1,8 @@
86 -+add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/../" )
87 -+
88 -+ecm_add_test(chmgeneratortest.cpp
89 -+ TEST_NAME "chmgeneratortest"
90 -+ LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore
91 -+)
92 -+
93 -+target_compile_definitions(chmgeneratortest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_chmlib>")
94 -diff --git a/generators/chm/autotests/chmgeneratortest.cpp b/generators/chm/autotests/chmgeneratortest.cpp
95 -index 6b0b8efc7..25fd6631a 100644
96 ---- a/generators/chm/autotests/chmgeneratortest.cpp
97 -+++ b/generators/chm/autotests/chmgeneratortest.cpp
98 -@@ -34,7 +34,7 @@ void ChmGeneratorTest::initTestCase()
99 - {
100 - Okular::SettingsCore::instance( QStringLiteral("ChmGeneratorTest") );
101 - m_document = new Okular::Document( 0 );
102 -- const QString testFile = QStringLiteral(KDESRCDIR "autotests/data/test.chm");
103 -+ const QString testFile = QStringLiteral(KDESRCDIR "data/test.chm");
104 - QMimeDatabase db;
105 - const QMimeType mime = db.mimeTypeForFile( testFile );
106 - QCOMPARE( m_document->openDocument(testFile, QUrl(), mime), Okular::Document::OpenSuccess );
107 -diff --git a/generators/kimgio/CMakeLists.txt b/generators/kimgio/CMakeLists.txt
108 -index b8cac76df..49f893bc1 100644
109 ---- a/generators/kimgio/CMakeLists.txt
110 -+++ b/generators/kimgio/CMakeLists.txt
111 -@@ -13,13 +13,9 @@ okular_add_generator(okularGenerator_kimgio generator_kimgio.cpp)
112 - target_link_libraries(okularGenerator_kimgio okularcore KF5::KExiv2 KF5::I18n)
113 -
114 - if(BUILD_TESTING)
115 -- add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
116 -- set( kimgiotest_SRCS tests/kimgiotest.cpp ${CMAKE_SOURCE_DIR}/ui/pagepainter.cpp ${CMAKE_SOURCE_DIR}/ui/guiutils.cpp ${CMAKE_SOURCE_DIR}/ui/debug_ui.cpp )
117 -- ecm_add_test(${kimgiotest_SRCS} TEST_NAME "kimgiotest" LINK_LIBRARIES okularcore okularpart Qt5::Svg Qt5::Test)
118 -- target_compile_definitions(kimgiotest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_kimgio>")
119 -+ add_subdirectory(tests)
120 - endif()
121 -
122 --
123 - ########### install files ###############
124 - install( FILES okularKimgio.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
125 - install( PROGRAMS okularApplication_kimgio.desktop org.kde.mobile.okular_kimgio.desktop DESTINATION ${KDE_INSTALL_APPDIR} )
126 -diff --git a/generators/kimgio/tests/CMakeLists.txt b/generators/kimgio/tests/CMakeLists.txt
127 -new file mode 100644
128 -index 000000000..f31bf3fe8
129 ---- /dev/null
130 -+++ b/generators/kimgio/tests/CMakeLists.txt
131 -@@ -0,0 +1,5 @@
132 -+add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/../" )
133 -+
134 -+set( kimgiotest_SRCS kimgiotest.cpp ${CMAKE_SOURCE_DIR}/ui/pagepainter.cpp ${CMAKE_SOURCE_DIR}/ui/guiutils.cpp ${CMAKE_SOURCE_DIR}/ui/debug_ui.cpp )
135 -+ecm_add_test(${kimgiotest_SRCS} TEST_NAME "kimgiotest" LINK_LIBRARIES okularcore okularpart Qt5::Svg Qt5::Test)
136 -+target_compile_definitions(kimgiotest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_kimgio>")
137 -diff --git a/generators/kimgio/tests/kimgiotest.cpp b/generators/kimgio/tests/kimgiotest.cpp
138 -index b3039a6bb..78608df9d 100644
139 ---- a/generators/kimgio/tests/kimgiotest.cpp
140 -+++ b/generators/kimgio/tests/kimgiotest.cpp
141 -@@ -9,7 +9,7 @@
142 -
143 -
144 - #include "../generator_kimgio.h"
145 --#include "../../settings_core.h"
146 -+#include "../../../settings_core.h"
147 -
148 - #include <core/observer.h>
149 - #include <core/page.h>
150 ---
151 -2.14.2
152 -
153 + install( FILES okularEPub.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
154
155 diff --git a/kde-apps/okular/okular-18.08.0.ebuild b/kde-apps/okular/okular-18.08.0.ebuild
156 index 3b0a59ddda..e7c417affc 100644
157 --- a/kde-apps/okular/okular-18.08.0.ebuild
158 +++ b/kde-apps/okular/okular-18.08.0.ebuild
159 @@ -64,7 +64,7 @@ RDEPEND="${DEPEND}
160 )
161 "
162
163 -PATCHES=( "${FILESDIR}/${PN}-tests.patch" )
164 +PATCHES=( "${FILESDIR}/${P}-tests.patch" )
165
166 src_prepare() {
167 kde5_src_prepare
168
169 diff --git a/kde-apps/okular/okular-18.08.49.9999.ebuild b/kde-apps/okular/okular-18.08.49.9999.ebuild
170 index eca8cfddbc..fe034479f4 100644
171 --- a/kde-apps/okular/okular-18.08.49.9999.ebuild
172 +++ b/kde-apps/okular/okular-18.08.49.9999.ebuild
173 @@ -64,7 +64,7 @@ RDEPEND="${DEPEND}
174 )
175 "
176
177 -PATCHES=( "${FILESDIR}/${PN}-tests.patch" )
178 +PATCHES=( "${FILESDIR}/${PN}-18.08.0-tests.patch" )
179
180 src_prepare() {
181 kde5_src_prepare
182
183 diff --git a/kde-apps/okular/okular-9999.ebuild b/kde-apps/okular/okular-9999.ebuild
184 index eca8cfddbc..4eaf510647 100644
185 --- a/kde-apps/okular/okular-9999.ebuild
186 +++ b/kde-apps/okular/okular-9999.ebuild
187 @@ -64,7 +64,10 @@ RDEPEND="${DEPEND}
188 )
189 "
190
191 -PATCHES=( "${FILESDIR}/${PN}-tests.patch" )
192 +PATCHES=(
193 + "${FILESDIR}/${PN}-18.08.0-tests.patch"
194 + "${FILESDIR}/${PN}-tests.patch"
195 +)
196
197 src_prepare() {
198 kde5_src_prepare