Gentoo Archives: gentoo-commits

From: Mart Raudsepp <leio@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: gnome-base/nautilus/files/, gnome-base/nautilus/
Date: Mon, 23 Dec 2019 21:34:37
Message-Id: 1577136527.483f64af56223e4b899c9468f6f51a22ad11b17e.leio@gentoo
1 commit: 483f64af56223e4b899c9468f6f51a22ad11b17e
2 Author: Mart Raudsepp <leio <AT> gentoo <DOT> org>
3 AuthorDate: Mon Dec 23 21:28:47 2019 +0000
4 Commit: Mart Raudsepp <leio <AT> gentoo <DOT> org>
5 CommitDate: Mon Dec 23 21:28:47 2019 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=483f64af
7
8 gnome-base/nautilus: remove old
9
10 Package-Manager: Portage-2.3.79, Repoman-2.3.12
11 Signed-off-by: Mart Raudsepp <leio <AT> gentoo.org>
12
13 gnome-base/nautilus/Manifest | 1 -
14 .../nautilus/files/3.30.5-CVE-2019-11461.patch | 30 ------
15 .../nautilus/files/3.30.5-seccomp-sparc32.patch | 27 -----
16 .../files/3.30.5-thumbnailer-updates.patch | 113 ---------------------
17 .../files/3.30.5-thumbnailer-updates2.patch | 46 ---------
18 gnome-base/nautilus/nautilus-3.30.5-r1.ebuild | 106 -------------------
19 6 files changed, 323 deletions(-)
20
21 diff --git a/gnome-base/nautilus/Manifest b/gnome-base/nautilus/Manifest
22 index f39a559f56c..c27e9f9b5a9 100644
23 --- a/gnome-base/nautilus/Manifest
24 +++ b/gnome-base/nautilus/Manifest
25 @@ -1,2 +1 @@
26 -DIST nautilus-3.30.5.tar.xz 3254344 BLAKE2B 64da158ee661fc259a14f890bf6ad343f720245df6b9475ff047993570ea4e7234723eb242f057bc85b7ea95d38a99b5c2f5d546e982a3e3e32b7fc75cabb786 SHA512 e38a8bb380460d902e4ec6219d0e147a4245e790b18fb18ab9474ec2ae002a971243c6b09b8fec267e65c7ecc7bb1217191c4f5cb9547b3b9d5b0793068103cf
27 DIST nautilus-3.32.3.tar.xz 3197820 BLAKE2B 28140210a855fe62faba4f0833067a81c4d8f71c0cc870ba4fdcc016754b01df003e45f636836f67cced8515aba8c8fb7922de788a14bfe0f0cc4518010aed5f SHA512 f19710f02bd91edb2d2f6cb8f46be6bebea3edfed14a07612444d5990533bafd032b604d65533727eb377b574d6bd4c82dbe11894d85ad254ee1473b683c4392
28
29 diff --git a/gnome-base/nautilus/files/3.30.5-CVE-2019-11461.patch b/gnome-base/nautilus/files/3.30.5-CVE-2019-11461.patch
30 deleted file mode 100644
31 index 6c2d061123f..00000000000
32 --- a/gnome-base/nautilus/files/3.30.5-CVE-2019-11461.patch
33 +++ /dev/null
34 @@ -1,30 +0,0 @@
35 -From 83949ed5800ec99953f5ee8d2bf8b90a69daa850 Mon Sep 17 00:00:00 2001
36 -From: Michael Catanzaro <mcatanzaro@××××××.com>
37 -Date: Sat, 13 Apr 2019 13:57:36 -0500
38 -Subject: [PATCH] thumbnailer: fix incomplete TIOCSTI filtering
39 -
40 -Fixes #112
41 -
42 -See also: https://github.com/flatpak/flatpak/issues/2782
43 ----
44 - libgnome-desktop/gnome-desktop-thumbnail-script.c | 2 +-
45 - 1 file changed, 1 insertion(+), 1 deletion(-)
46 -
47 -leio: Adjusted to apply to nautilus copy
48 -
49 -diff --git a/libgnome-desktop/gnome-desktop-thumbnail-script.c b/libgnome-desktop/gnome-desktop-thumbnail-script.c
50 -index 9468b51c..3b3d1ea9 100644
51 ---- a/src/gnome-desktop/gnome-desktop-thumbnail-script.c
52 -+++ b/src/gnome-desktop/gnome-desktop-thumbnail-script.c
53 -@@ -343,7 +343,7 @@ setup_seccomp (GPtrArray *argv_array,
54 - {SCMP_SYS (clone), &SCMP_A0 (SCMP_CMP_MASKED_EQ, CLONE_NEWUSER, CLONE_NEWUSER)},
55 -
56 - /* Don't allow faking input to the controlling tty (CVE-2017-5226) */
57 -- {SCMP_SYS (ioctl), &SCMP_A1(SCMP_CMP_EQ, (int)TIOCSTI)},
58 -+ {SCMP_SYS (ioctl), &SCMP_A1(SCMP_CMP_MASKED_EQ, 0xFFFFFFFFu, (int)TIOCSTI)},
59 - };
60 -
61 - struct
62 ---
63 -2.20.1
64 -
65
66 diff --git a/gnome-base/nautilus/files/3.30.5-seccomp-sparc32.patch b/gnome-base/nautilus/files/3.30.5-seccomp-sparc32.patch
67 deleted file mode 100644
68 index f67695b7f1d..00000000000
69 --- a/gnome-base/nautilus/files/3.30.5-seccomp-sparc32.patch
70 +++ /dev/null
71 @@ -1,27 +0,0 @@
72 -From 3b0fd7dd26fa5af0b310650b2974d800ace80802 Mon Sep 17 00:00:00 2001
73 -From: Mart Raudsepp <leio@g.o>
74 -Date: Fri, 15 Feb 2019 21:34:34 +0200
75 -Subject: [PATCH 2/2] meson.build: Add 32-bit sparc to seccomp unsupported list
76 -
77 -32-bit sparc doesn't support seccomp either.
78 -
79 -(cherry picked from commit 44b49e6ca02add9592abac03a8578b9eea1a5088)
80 ----
81 - meson.build | 1 +
82 - 1 file changed, 1 insertion(+)
83 -
84 -diff --git a/meson.build b/meson.build
85 -index 50479f5f0..91915b31a 100644
86 ---- a/meson.build
87 -+++ b/meson.build
88 -@@ -72,6 +72,7 @@ unsupported_cpus = [
89 - 'parisc',
90 - 'parisc64',
91 - 'sh4',
92 -+ 'sparc',
93 - 'sparc64',
94 - ]
95 - system_supports_seccomp = host_system == 'linux'
96 ---
97 -2.17.0
98 -
99
100 diff --git a/gnome-base/nautilus/files/3.30.5-thumbnailer-updates.patch b/gnome-base/nautilus/files/3.30.5-thumbnailer-updates.patch
101 deleted file mode 100644
102 index 84d0bfc1d5a..00000000000
103 --- a/gnome-base/nautilus/files/3.30.5-thumbnailer-updates.patch
104 +++ /dev/null
105 @@ -1,113 +0,0 @@
106 -From 2e36d4bacc3cffebe62161adc375bb9ec64099f5 Mon Sep 17 00:00:00 2001
107 -From: Timothy OBrien <obrien.timothy.a@×××××.com>
108 -Date: Fri, 18 Jan 2019 19:42:46 +1100
109 -Subject: [PATCH 1/2] gnome-desktop: update to latest version of upstream
110 - thumbnail code
111 -
112 -The thumbnail code in gnome-desktop had recent bug fixes that needed to be carried across to the Nautilus implementation. Issues for the three related upstream fixes can be found at: https://gitlab.gnome.org/GNOME/gnome-desktop/issues/4 | https://gitlab.gnome.org/GNOME/gnome-desktop/issues/89 | https://gitlab.gnome.org/GNOME/gnome-desktop/issues/87
113 -
114 -This patch includes the latest thumbnail code from the gnome-desktop repository to include the fixes.
115 -
116 -Fixes #836
117 -
118 -(cherry picked from commit e88b2dc8783833c4263ad5d84567a67dbc7bc6de)
119 ----
120 - .../gnome-desktop-thumbnail-script.c | 54 +++++++++++++++++--
121 - src/gnome-desktop/gnome-desktop-thumbnail.c | 4 +-
122 - 2 files changed, 52 insertions(+), 6 deletions(-)
123 -
124 -diff --git a/src/gnome-desktop/gnome-desktop-thumbnail-script.c b/src/gnome-desktop/gnome-desktop-thumbnail-script.c
125 -index 14e2fed3a..525766388 100644
126 ---- a/src/gnome-desktop/gnome-desktop-thumbnail-script.c
127 -+++ b/src/gnome-desktop/gnome-desktop-thumbnail-script.c
128 -@@ -506,22 +506,68 @@ setup_seccomp (GPtrArray *argv_array,
129 - #endif
130 -
131 - #ifdef HAVE_BWRAP
132 -+static gboolean
133 -+path_is_usrmerged (const char *dir)
134 -+{
135 -+ /* does /dir point to /usr/dir? */
136 -+ g_autofree char *target = NULL;
137 -+ GStatBuf stat_buf_src, stat_buf_target;
138 -+
139 -+ if (g_stat (dir, &stat_buf_src) < 0)
140 -+ return FALSE;
141 -+
142 -+ target = g_strdup_printf ("/usr/%s", dir);
143 -+
144 -+ if (g_stat (target, &stat_buf_target) < 0)
145 -+ return FALSE;
146 -+
147 -+ return (stat_buf_src.st_dev == stat_buf_target.st_dev) &&
148 -+ (stat_buf_src.st_ino == stat_buf_target.st_ino);
149 -+}
150 -+
151 - static gboolean
152 - add_bwrap (GPtrArray *array,
153 - ScriptExec *script)
154 - {
155 -+ const char * const usrmerged_dirs[] = { "bin", "lib64", "lib", "sbin" };
156 -+ int i;
157 -+
158 - g_return_val_if_fail (script->outdir != NULL, FALSE);
159 - g_return_val_if_fail (script->s_infile != NULL, FALSE);
160 -
161 - add_args (array,
162 - "bwrap",
163 - "--ro-bind", "/usr", "/usr",
164 -- "--ro-bind", "/lib", "/lib",
165 -- "--ro-bind", "/lib64", "/lib64",
166 -+ "--ro-bind", "/etc/ld.so.cache", "/etc/ld.so.cache",
167 -+ NULL);
168 -+
169 -+ /* These directories might be symlinks into /usr/... */
170 -+ for (i = 0; i < G_N_ELEMENTS (usrmerged_dirs); i++)
171 -+ {
172 -+ g_autofree char *absolute_dir = g_strdup_printf ("/%s", usrmerged_dirs[i]);
173 -+
174 -+ if (!g_file_test (absolute_dir, G_FILE_TEST_EXISTS))
175 -+ continue;
176 -+
177 -+ if (path_is_usrmerged (absolute_dir))
178 -+ {
179 -+ g_autofree char *symlink_target = g_strdup_printf ("/usr/%s", absolute_dir);
180 -+
181 -+ add_args (array,
182 -+ "--symlink", symlink_target, absolute_dir,
183 -+ NULL);
184 -+ }
185 -+ else
186 -+ {
187 -+ add_args (array,
188 -+ "--ro-bind", absolute_dir, absolute_dir,
189 -+ NULL);
190 -+ }
191 -+ }
192 -+
193 -+ add_args (array,
194 - "--proc", "/proc",
195 - "--dev", "/dev",
196 -- "--symlink", "usr/bin", "/bin",
197 -- "--symlink", "usr/sbin", "/sbin",
198 - "--chdir", "/",
199 - "--setenv", "GIO_USE_VFS", "local",
200 - "--unshare-all",
201 -diff --git a/src/gnome-desktop/gnome-desktop-thumbnail.c b/src/gnome-desktop/gnome-desktop-thumbnail.c
202 -index b31bad58d..f48fd461a 100644
203 ---- a/src/gnome-desktop/gnome-desktop-thumbnail.c
204 -+++ b/src/gnome-desktop/gnome-desktop-thumbnail.c
205 -@@ -967,8 +967,8 @@ get_preview_thumbnail (const char *uri,
206 - if (file_info == NULL)
207 - return NULL;
208 -
209 -- object = g_file_info_get_attribute_object (file_info,
210 -- G_FILE_ATTRIBUTE_PREVIEW_ICON);
211 -+ object = g_object_ref (g_file_info_get_attribute_object (file_info,
212 -+ G_FILE_ATTRIBUTE_PREVIEW_ICON));
213 - g_object_unref (file_info);
214 -
215 - if (!object)
216 ---
217 -2.17.0
218 -
219
220 diff --git a/gnome-base/nautilus/files/3.30.5-thumbnailer-updates2.patch b/gnome-base/nautilus/files/3.30.5-thumbnailer-updates2.patch
221 deleted file mode 100644
222 index 884deb42091..00000000000
223 --- a/gnome-base/nautilus/files/3.30.5-thumbnailer-updates2.patch
224 +++ /dev/null
225 @@ -1,46 +0,0 @@
226 -From 87aa2520989bafbd861a03a32d6fdb0d2620faf5 Mon Sep 17 00:00:00 2001
227 -From: Mart Raudsepp <leio@g.o>
228 -Date: Mon, 11 Mar 2019 23:23:11 +0200
229 -Subject: [PATCH] Sync gnome-desktop code
230 -
231 -Brings in fontconfig cache bind mount and a small memory fix; cache path hardcoded to Gentoo for now
232 ----
233 - src/gnome-desktop/gnome-desktop-thumbnail-script.c | 4 ++++
234 - src/gnome-desktop/gnome-desktop-thumbnail.c | 6 ++++--
235 - 2 files changed, 8 insertions(+), 2 deletions(-)
236 -
237 -diff --git a/src/gnome-desktop/gnome-desktop-thumbnail-script.c b/src/gnome-desktop/gnome-desktop-thumbnail-script.c
238 -index 525766388..0331cb3c7 100644
239 ---- a/src/gnome-desktop/gnome-desktop-thumbnail-script.c
240 -+++ b/src/gnome-desktop/gnome-desktop-thumbnail-script.c
241 -@@ -565,6 +565,10 @@ add_bwrap (GPtrArray *array,
242 - }
243 - }
244 -
245 -+ /* fontconfig cache if necessary */
246 -+ if (!g_str_has_prefix ("/var/cache/fontconfig", "/usr/"))
247 -+ add_args (array, "--ro-bind-try", "/var/cache/fontconfig", "/var/cache/fontconfig", NULL);
248 -+
249 - add_args (array,
250 - "--proc", "/proc",
251 - "--dev", "/dev",
252 -diff --git a/src/gnome-desktop/gnome-desktop-thumbnail.c b/src/gnome-desktop/gnome-desktop-thumbnail.c
253 -index f48fd461a..566fbeb84 100644
254 ---- a/src/gnome-desktop/gnome-desktop-thumbnail.c
255 -+++ b/src/gnome-desktop/gnome-desktop-thumbnail.c
256 -@@ -967,8 +967,10 @@ get_preview_thumbnail (const char *uri,
257 - if (file_info == NULL)
258 - return NULL;
259 -
260 -- object = g_object_ref (g_file_info_get_attribute_object (file_info,
261 -- G_FILE_ATTRIBUTE_PREVIEW_ICON));
262 -+ object = g_file_info_get_attribute_object (file_info,
263 -+ G_FILE_ATTRIBUTE_PREVIEW_ICON);
264 -+ if (object)
265 -+ g_object_ref (object);
266 - g_object_unref (file_info);
267 -
268 - if (!object)
269 ---
270 -2.17.0
271 -
272
273 diff --git a/gnome-base/nautilus/nautilus-3.30.5-r1.ebuild b/gnome-base/nautilus/nautilus-3.30.5-r1.ebuild
274 deleted file mode 100644
275 index cdb86ae3328..00000000000
276 --- a/gnome-base/nautilus/nautilus-3.30.5-r1.ebuild
277 +++ /dev/null
278 @@ -1,106 +0,0 @@
279 -# Copyright 1999-2019 Gentoo Authors
280 -# Distributed under the terms of the GNU General Public License v2
281 -
282 -EAPI=6
283 -
284 -inherit gnome.org gnome2-utils meson readme.gentoo-r1 virtualx xdg
285 -
286 -DESCRIPTION="Default file manager for the GNOME desktop"
287 -HOMEPAGE="https://wiki.gnome.org/Apps/Nautilus"
288 -
289 -LICENSE="GPL-3+ LGPL-2.1+"
290 -SLOT="0"
291 -IUSE="gnome gtk-doc +introspection packagekit +previewer seccomp selinux sendto"
292 -
293 -KEYWORDS="~alpha amd64 ~arm arm64 ~ia64 ~ppc ~ppc64 ~sparc x86 ~amd64-linux ~x86-linux"
294 -
295 -COMMON_DEPEND="
296 - >=dev-libs/glib-2.55.1:2
297 - >=media-libs/gexiv2-0.10.0
298 - >=app-arch/gnome-autoar-0.2.1
299 - gnome-base/gsettings-desktop-schemas
300 - >=x11-libs/gtk+-3.22.27:3[X,introspection?]
301 - seccomp? ( sys-libs/libseccomp )
302 - >=x11-libs/pango-1.28.3
303 - selinux? ( >=sys-libs/libselinux-2.0 )
304 - >=app-misc/tracker-2.0:=
305 - x11-libs/libX11
306 - >=dev-libs/libxml2-2.7.8:2
307 - introspection? ( >=dev-libs/gobject-introspection-1.54:= )
308 -"
309 -DEPEND="${COMMON_DEPEND}
310 - >=dev-util/gdbus-codegen-2.51.2
311 - dev-util/glib-utils
312 - gtk-doc? (
313 - >=dev-util/gtk-doc-1.10
314 - app-text/docbook-xml-dtd:4.1.2 )
315 - >=sys-devel/gettext-0.19.8
316 - virtual/pkgconfig
317 - x11-base/xorg-proto
318 -"
319 -RDEPEND="${COMMON_DEPEND}
320 - packagekit? ( app-admin/packagekit-base )
321 - seccomp? ( >=sys-apps/bubblewrap-0.3.1 )
322 - sendto? ( !<gnome-extra/nautilus-sendto-3.0.1 )
323 -"
324 -
325 -PDEPEND="
326 - gnome? ( x11-themes/adwaita-icon-theme )
327 - previewer? ( >=gnome-extra/sushi-0.1.9 )
328 - sendto? ( >=gnome-extra/nautilus-sendto-3.0.1 )
329 - >=gnome-base/gvfs-1.14[gtk(+)]
330 -" # Need gvfs[gtk] for recent:/// support; always built (without USE=gtk) since gvfs-1.34
331 -
332 -PATCHES=(
333 - "${FILESDIR}"/${PV}-docs-build.patch # Always install pregenerated manpage, keeping docs option for gtk-doc
334 - "${FILESDIR}"/${PV}-thumbnailer-updates{,2}.patch # syncs with gnome-desktop; fixes the ld.so.cache for us
335 - "${FILESDIR}"/${PV}-seccomp-sparc32.patch # 32-bit sparc doesn't have seccomp either
336 - "${FILESDIR}"/${PV}-CVE-2019-11461.patch
337 -)
338 -
339 -src_prepare() {
340 - if use previewer; then
341 - DOC_CONTENTS="nautilus uses gnome-extra/sushi to preview media files.
342 - To activate the previewer, select a file and press space; to
343 - close the previewer, press space again."
344 - fi
345 - xdg_src_prepare
346 -}
347 -
348 -src_configure() {
349 - local emesonargs=(
350 - $(meson_use gtk-doc docs)
351 - -Dextensions=true # image file properties, sendto support
352 - $(meson_use introspection)
353 - $(meson_use packagekit)
354 - $(meson_use selinux)
355 - -Dprofiling=false
356 - -Dtests=$(usex test all none)
357 - )
358 - meson_src_configure
359 -}
360 -
361 -src_install() {
362 - use previewer && readme.gentoo_create_doc
363 - meson_src_install
364 -}
365 -
366 -src_test() {
367 - virtx meson_src_test
368 -}
369 -
370 -pkg_postinst() {
371 - xdg_pkg_postinst
372 - gnome2_schemas_update
373 -
374 - if use previewer; then
375 - readme.gentoo_print_elog
376 - else
377 - elog "To preview media files, emerge nautilus with USE=previewer"
378 - fi
379 -}
380 -
381 -pkg_postrm() {
382 - xdg_pkg_postrm
383 - gnome2_schemas_update
384 -}