1 |
commit: 9df4995d2d5ddf1fa053e266a0636c1eb3784afc |
2 |
Author: Jakov Smolić <jsmolic <AT> gentoo <DOT> org> |
3 |
AuthorDate: Tue Oct 5 06:48:47 2021 +0000 |
4 |
Commit: Jakov Smolić <jsmolic <AT> gentoo <DOT> org> |
5 |
CommitDate: Tue Oct 5 07:36:49 2021 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9df4995d |
7 |
|
8 |
mail-client/trojita: treeclean |
9 |
|
10 |
Bug: https://bugs.gentoo.org/685750 |
11 |
Bug: https://bugs.gentoo.org/808528 |
12 |
Signed-off-by: Jakov Smolić <jsmolic <AT> gentoo.org> |
13 |
|
14 |
mail-client/trojita/Manifest | 1 - |
15 |
.../trojita/files/trojita-0.7-CVE-2019-10734.patch | 104 ----------- |
16 |
.../trojita/files/trojita-0.7-CVE-2020-15047.patch | 82 -------- |
17 |
.../trojita/files/trojita-0.7-cmake-cxx11.patch | 66 ------- |
18 |
.../files/trojita-0.7-crash-w-attachments.patch | 68 ------- |
19 |
.../files/trojita-0.7-desktop-spec-namespace.patch | 57 ------ |
20 |
.../trojita/files/trojita-0.7-gpg-tests.patch | 27 --- |
21 |
mail-client/trojita/files/trojita-0.7-gpgme.patch | 34 ---- |
22 |
.../trojita/files/trojita-0.7-metainfo.patch | 26 --- |
23 |
.../trojita/files/trojita-0.7-qt-5.11b3.patch | 207 --------------------- |
24 |
.../trojita/files/trojita-0.7-qt-5.13.patch | 37 ---- |
25 |
.../trojita/files/trojita-0.7-qt-5.15.patch | 28 --- |
26 |
mail-client/trojita/metadata.xml | 23 --- |
27 |
mail-client/trojita/trojita-0.7-r6.ebuild | 90 --------- |
28 |
mail-client/trojita/trojita-9999.ebuild | 81 -------- |
29 |
profiles/package.mask | 5 - |
30 |
16 files changed, 936 deletions(-) |
31 |
|
32 |
diff --git a/mail-client/trojita/Manifest b/mail-client/trojita/Manifest |
33 |
deleted file mode 100644 |
34 |
index 3d815f73deb..00000000000 |
35 |
--- a/mail-client/trojita/Manifest |
36 |
+++ /dev/null |
37 |
@@ -1 +0,0 @@ |
38 |
-DIST trojita-0.7.tar.xz 1038212 BLAKE2B 92dfb01fc1849d04958fd26ea731835c7287d5a6989d8e0c97c6679ce8f1c9f33a0f67c3f293fc85188e9d289c0dddee9847f4151b6f64396f3de86635b11f32 SHA512 fe4d9316f97d913619f27d24a5023c3d8dd4a6b9fb058651be12c67188f394aa8cbb60c7593e5eb28fc12fc883b76deeeb5f4f631edd255fdec4c5862c9a91c8 |
39 |
|
40 |
diff --git a/mail-client/trojita/files/trojita-0.7-CVE-2019-10734.patch b/mail-client/trojita/files/trojita-0.7-CVE-2019-10734.patch |
41 |
deleted file mode 100644 |
42 |
index d52edb042ad..00000000000 |
43 |
--- a/mail-client/trojita/files/trojita-0.7-CVE-2019-10734.patch |
44 |
+++ /dev/null |
45 |
@@ -1,104 +0,0 @@ |
46 |
-From 8db7f450d52539b4c72ee968384911b6813ad1e7 Mon Sep 17 00:00:00 2001 |
47 |
-From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= <jkt@×××.org> |
48 |
-Date: Thu, 25 Jun 2020 21:39:34 +0200 |
49 |
-Subject: [PATCH] Prevent a possible decryption oracle attack |
50 |
-MIME-Version: 1.0 |
51 |
-Content-Type: text/plain; charset=UTF-8 |
52 |
-Content-Transfer-Encoding: 8bit |
53 |
- |
54 |
-Thanks to Jens Mueller (Ruhr-Uni Bochum and FH Münster) for reporting |
55 |
-this. The gist is that an attacker can embed arbitrary ciphertext into |
56 |
-their messages. Trojita decrypts that, and when we hit reply, the |
57 |
-original *cleartext* gets quoted and put into a reply for the attacker |
58 |
-to see. |
59 |
- |
60 |
-Fix this by not quoting any plaintext which originated in an encrypted |
61 |
-message. That's pretty draconian, but hey, it works and we never came up |
62 |
-with any better patch. Also, given that Trojita does not encrypt |
63 |
-outgoing messages yet, this is probably also a conservative thing to do. |
64 |
- |
65 |
-Change-Id: I84c45b9e707eb7c99eb7183c6ef59ef41cd62c43 |
66 |
-CVE: CVE-2019-10734 |
67 |
-BUG: 404697 |
68 |
---- |
69 |
- src/Cryptography/GpgMe++.cpp | 2 ++ |
70 |
- src/Gui/MessageView.cpp | 9 ++++++++- |
71 |
- src/Gui/PartWidget.cpp | 8 ++++++++ |
72 |
- src/Imap/Model/ItemRoles.h | 2 +- |
73 |
- 4 files changed, 19 insertions(+), 2 deletions(-) |
74 |
- |
75 |
-diff --git a/src/Cryptography/GpgMe++.cpp b/src/Cryptography/GpgMe++.cpp |
76 |
-index e012f603..716b8aff 100644 |
77 |
---- a/src/Cryptography/GpgMe++.cpp |
78 |
-+++ b/src/Cryptography/GpgMe++.cpp |
79 |
-@@ -267,6 +267,8 @@ QVariant GpgMePart::data(int role) const |
80 |
- switch (role) { |
81 |
- case Imap::Mailbox::RolePartSignatureVerifySupported: |
82 |
- return m_wasSigned; |
83 |
-+ case RolePartDecryptionSupported: |
84 |
-+ return m_isAllegedlyEncrypted; |
85 |
- case RolePartCryptoNotFinishedYet: |
86 |
- return m_waitingForData || |
87 |
- (m_crypto.valid() && |
88 |
-diff --git a/src/Gui/MessageView.cpp b/src/Gui/MessageView.cpp |
89 |
-index 7d649308..c95e0878 100644 |
90 |
---- a/src/Gui/MessageView.cpp |
91 |
-+++ b/src/Gui/MessageView.cpp |
92 |
-@@ -354,7 +354,6 @@ bool MessageView::eventFilter(QObject *object, QEvent *event) |
93 |
- QString MessageView::quoteText() const |
94 |
- { |
95 |
- if (auto w = bodyWidget()) { |
96 |
-- QStringList quote = Composer::quoteText(w->quoteMe().split(QLatin1Char('\n'))); |
97 |
- const Imap::Message::Envelope &e = message.data(Imap::Mailbox::RoleMessageEnvelope).value<Imap::Message::Envelope>(); |
98 |
- QString sender; |
99 |
- if (!e.from.isEmpty()) |
100 |
-@@ -362,6 +361,14 @@ QString MessageView::quoteText() const |
101 |
- if (e.from.isEmpty()) |
102 |
- sender = tr("you"); |
103 |
- |
104 |
-+ if (messageModel->index(0, 0) /* fake message root */.child(0, 0) /* first MIME part */.data(Imap::Mailbox::RolePartDecryptionSupported).toBool()) { |
105 |
-+ // This is just an UX improvement shortcut: real filtering for CVE-2019-10734 is in |
106 |
-+ // MultipartSignedEncryptedWidget::quoteMe(). |
107 |
-+ // That is required because the encrypted part might not be the root part of the message. |
108 |
-+ return tr("On %1, %2 sent an encrypted message:\n> ...\n\n").arg(e.date.toLocalTime().toString(Qt::SystemLocaleLongDate), sender); |
109 |
-+ } |
110 |
-+ |
111 |
-+ QStringList quote = Composer::quoteText(w->quoteMe().split(QLatin1Char('\n'))); |
112 |
- // One extra newline at the end of the quoted text to separate the response |
113 |
- quote << QString(); |
114 |
- |
115 |
-diff --git a/src/Gui/PartWidget.cpp b/src/Gui/PartWidget.cpp |
116 |
-index bb27604d..96eff338 100644 |
117 |
---- a/src/Gui/PartWidget.cpp |
118 |
-+++ b/src/Gui/PartWidget.cpp |
119 |
-@@ -378,6 +378,14 @@ void MultipartSignedEncryptedWidget::updateStatusIndicator() |
120 |
- |
121 |
- QString MultipartSignedEncryptedWidget::quoteMe() const |
122 |
- { |
123 |
-+ if (m_partIndex.data(Imap::Mailbox::RolePartDecryptionSupported).toBool()) { |
124 |
-+ // See CVE-2019-10734, the point is not to leak cleartext from encrypted content. Even when Trojita starts supporting |
125 |
-+ // encryption of outgoing mail, we will have to check whether the encrypted cleartext is from the same sender, whether |
126 |
-+ // it matches the list of recipients (which is dynamic and can be set later on), etc etc. |
127 |
-+ // TL;DR, this is a can of worms. |
128 |
-+ return tr("[Encrypted message]"); |
129 |
-+ } |
130 |
-+ |
131 |
- return quoteMeHelper(children()); |
132 |
- } |
133 |
- |
134 |
-diff --git a/src/Imap/Model/ItemRoles.h b/src/Imap/Model/ItemRoles.h |
135 |
-index 4588d4d0..00adb3bb 100644 |
136 |
---- a/src/Imap/Model/ItemRoles.h |
137 |
-+++ b/src/Imap/Model/ItemRoles.h |
138 |
-@@ -193,7 +193,7 @@ enum { |
139 |
- RolePartSignatureVerifySupported, |
140 |
- /** @short Is the format of this particular multipart/encrypted supported and recognized? |
141 |
- |
142 |
-- See RolePartSignatureVerifySupported, this is an equivalent. |
143 |
-+ If true, this message part represents content of an encrypted message that Trojita can attempt to decrypt. |
144 |
- */ |
145 |
- RolePartDecryptionSupported, |
146 |
- /** @short Is there any point in waiting longer? |
147 |
--- |
148 |
-GitLab |
149 |
- |
150 |
|
151 |
diff --git a/mail-client/trojita/files/trojita-0.7-CVE-2020-15047.patch b/mail-client/trojita/files/trojita-0.7-CVE-2020-15047.patch |
152 |
deleted file mode 100644 |
153 |
index 44f1a5dab01..00000000000 |
154 |
--- a/mail-client/trojita/files/trojita-0.7-CVE-2020-15047.patch |
155 |
+++ /dev/null |
156 |
@@ -1,82 +0,0 @@ |
157 |
-From 77ddd5d44f2bf4155d0c9b6f7d05f01713b32d5d Mon Sep 17 00:00:00 2001 |
158 |
-From: Jan Kundrát <jkt@×××.org> |
159 |
-Date: Thu, 25 Jun 2020 11:30:51 +0200 |
160 |
-Subject: [PATCH] SMTP: Do not ignore TLS errors |
161 |
- |
162 |
-This fixes a CVE-2020-15047 (category: CWE-295). Since commit 0083eea5ed |
163 |
-which added initial, experimental support for SMTP message submission, |
164 |
-we have apparently never implemented proper SSL/TLS error handling, and |
165 |
-the code has ever since just kept silently ignoring any certificate |
166 |
-verification errors. As a result, Trojita was susceptible to a MITM |
167 |
-attack when sending e-mails. The information leaked include user's |
168 |
-authentication details, including the password, and the content of sent |
169 |
-messages. |
170 |
- |
171 |
-Sorry for this :(. |
172 |
- |
173 |
-Now, this patch re-enabes proper TLS error handling. It was not possible |
174 |
-to directly re-use our code for TLS key pinning which we are using for |
175 |
-IMAP connections. In the Qt TLS code, the decision to accept or not |
176 |
-accept a TLS connection is a blocking one, so the IMAP code relies upon |
177 |
-the protocol state machine (i.e., another layer) for deciding whether to |
178 |
-use or not to use the just-established TLS connection. Implementing an |
179 |
-equivalent code in the SMTP library would be nice, but this hot-fix has |
180 |
-a priority. As a result, SMTP connections to hosts with, e.g., |
181 |
-self-signed TLS certs, are no longer possible. Let's hope that this is |
182 |
-not a practical problem with Lets Encrypt anymore. |
183 |
- |
184 |
-Thanks to Damian Poddebniak for reporting this bug. |
185 |
- |
186 |
-Change-Id: Icd6bbb2b0fb3e45159fc9699ebd07ab84262fe37 |
187 |
-CVE: CVE-2020-15047 |
188 |
-BUG: 423453 |
189 |
---- |
190 |
- |
191 |
-diff --git a/src/MSA/SMTP.cpp b/src/MSA/SMTP.cpp |
192 |
-index 3a05451..ac1eefc 100644 |
193 |
---- a/src/MSA/SMTP.cpp |
194 |
-+++ b/src/MSA/SMTP.cpp |
195 |
-@@ -21,6 +21,7 @@ |
196 |
- along with this program. If not, see <http://www.gnu.org/licenses/>. |
197 |
- */ |
198 |
- #include "SMTP.h" |
199 |
-+#include "UiUtils/Formatting.h" |
200 |
- |
201 |
- namespace MSA |
202 |
- { |
203 |
-@@ -32,8 +33,8 @@ |
204 |
- user(user), failed(false), isWaitingForPassword(false), sendingMode(MODE_SMTP_INVALID) |
205 |
- { |
206 |
- qwwSmtp = new QwwSmtpClient(this); |
207 |
-- // FIXME: handle SSL errors properly |
208 |
-- connect(qwwSmtp, &QwwSmtpClient::sslErrors, qwwSmtp, &QwwSmtpClient::ignoreSslErrors); |
209 |
-+ // FIXME: handle SSL errors in the same way as we handle IMAP TLS errors, with key pinning, etc. |
210 |
-+ connect(qwwSmtp, &QwwSmtpClient::sslErrors, this, &SMTP::handleSslErrors); |
211 |
- connect(qwwSmtp, &QwwSmtpClient::connected, this, &AbstractMSA::sending); |
212 |
- connect(qwwSmtp, &QwwSmtpClient::done, this, &SMTP::handleDone); |
213 |
- connect(qwwSmtp, &QwwSmtpClient::socketError, this, &SMTP::handleError); |
214 |
-@@ -78,6 +79,12 @@ |
215 |
- emit error(msg); |
216 |
- } |
217 |
- |
218 |
-+void SMTP::handleSslErrors(const QList<QSslError>& errors) |
219 |
-+{ |
220 |
-+ auto msg = UiUtils::Formatting::sslErrorsToHtml(errors); |
221 |
-+ emit error(tr("<p>Cannot send message due to an SSL/TLS error</p>\n%1").arg(msg)); |
222 |
-+} |
223 |
-+ |
224 |
- void SMTP::setPassword(const QString &password) |
225 |
- { |
226 |
- pass = password; |
227 |
-diff --git a/src/MSA/SMTP.h b/src/MSA/SMTP.h |
228 |
-index 453407d..913bb87 100644 |
229 |
---- a/src/MSA/SMTP.h |
230 |
-+++ b/src/MSA/SMTP.h |
231 |
-@@ -43,6 +43,7 @@ |
232 |
- virtual void setPassword(const QString &password); |
233 |
- void handleDone(bool ok); |
234 |
- void handleError(QAbstractSocket::SocketError err, const QString &msg); |
235 |
-+ void handleSslErrors(const QList<QSslError>& errors); |
236 |
- private: |
237 |
- QwwSmtpClient *qwwSmtp; |
238 |
- QString host; |
239 |
|
240 |
diff --git a/mail-client/trojita/files/trojita-0.7-cmake-cxx11.patch b/mail-client/trojita/files/trojita-0.7-cmake-cxx11.patch |
241 |
deleted file mode 100644 |
242 |
index 71ab15950b8..00000000000 |
243 |
--- a/mail-client/trojita/files/trojita-0.7-cmake-cxx11.patch |
244 |
+++ /dev/null |
245 |
@@ -1,66 +0,0 @@ |
246 |
-From e2e35bfda75a2f4950408c93ede72fabfe86360e Mon Sep 17 00:00:00 2001 |
247 |
-From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= <jkt@×××.org> |
248 |
-Date: Wed, 19 Oct 2016 22:15:16 +0200 |
249 |
-Subject: [PATCH] cmake: Speed up cmake by using native features for enforcing |
250 |
- C++11 |
251 |
- |
252 |
-This saves about 8 seconds in my (limited) testing with a 2016-era |
253 |
-laptop with plenty of RAM and a fast SSD. |
254 |
- |
255 |
-We still attempt to support ancient pre-3.1 CMake by adding that blurb |
256 |
-into CXXFLAGS, maybe it even works. |
257 |
- |
258 |
-I should probably start tracking time I spend supporting old |
259 |
-environments and evaluate whether this is worth the effort. Once we are |
260 |
-ready to distribute flatpaks/appimages/whatevers, I suspect that my life |
261 |
-will become much easier. |
262 |
- |
263 |
-Change-Id: Ibbbe3d8440a7d29ef27440a99938d313bfe9699f |
264 |
---- |
265 |
- CMakeLists.txt | 26 ++-- |
266 |
- 24 files changed, 8 insertions(+), 468 deletions(-) |
267 |
- |
268 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
269 |
-index 9393b19c..92a682f7 100644 |
270 |
---- a/CMakeLists.txt |
271 |
-+++ b/CMakeLists.txt |
272 |
-@@ -18,6 +18,14 @@ if(POLICY CMP0043) |
273 |
- cmake_policy(SET CMP0043 OLD) |
274 |
- endif() |
275 |
- |
276 |
-+if(CMAKE_VERSION VERSION_LESS "3.1") |
277 |
-+ # If you aren't using and old Linux with an old GCC and old CMake, please just upgrade. |
278 |
-+ set(CMAKE_CXX_FLAGS "--std=c++11 ${CMAKE_CXX_FLAGS}") |
279 |
-+else() |
280 |
-+ set(CMAKE_CXX_STANDARD 11) |
281 |
-+ set(CMAKE_CXX_STANDARD_REQUIRED ON) |
282 |
-+endif() |
283 |
-+ |
284 |
- # Set a default build type if none was specified. This was shamelessly stolen |
285 |
- # from VTK's cmake setup because these guys produce both CMake and a project that |
286 |
- # manipulates this variable, and the web is full of posts where people say that |
287 |
-@@ -34,24 +42,6 @@ endif() |
288 |
- |
289 |
- set(CMAKE_POSITION_INDEPENDENT_CODE ON) |
290 |
- |
291 |
--include(FindCXXFeatures) |
292 |
--if(NOT CXXFeatures_auto_FOUND) |
293 |
-- message(SEND_ERROR "Your compiler doesn't support C++11's auto") |
294 |
--endif() |
295 |
--if(NOT CXXFeatures_static_assert_FOUND) |
296 |
-- message(SEND_ERROR "Your compiler doesn't support C++11's static_assert") |
297 |
--endif() |
298 |
--if(NOT CXXFeatures_alignof_FOUND) |
299 |
-- message(SEND_ERROR "Your compiler doesn't support C++11's alignof") |
300 |
--endif() |
301 |
--if(NOT CXXFeatures_nullptr_FOUND) |
302 |
-- message(SEND_ERROR "Your compiler doesn't support C++11's nullptr") |
303 |
--endif() |
304 |
--if(NOT CXXFeatures_lambda_FOUND) |
305 |
-- message(SEND_ERROR "Your compiler doesn't support C++11's lambda functions") |
306 |
--endif() |
307 |
--set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX11_COMPILER_FLAGS}") |
308 |
-- |
309 |
- include(TrojitaOption) |
310 |
- |
311 |
- trojita_option(WITH_DESKTOP "Build desktop version" ON) |
312 |
|
313 |
diff --git a/mail-client/trojita/files/trojita-0.7-crash-w-attachments.patch b/mail-client/trojita/files/trojita-0.7-crash-w-attachments.patch |
314 |
deleted file mode 100644 |
315 |
index 38d11316e5e..00000000000 |
316 |
--- a/mail-client/trojita/files/trojita-0.7-crash-w-attachments.patch |
317 |
+++ /dev/null |
318 |
@@ -1,68 +0,0 @@ |
319 |
-From cf2364b80fa8ae844df8350cd5833d47cce235f2 Mon Sep 17 00:00:00 2001 |
320 |
-From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= <jkt@×××.org> |
321 |
-Date: Mon, 9 Mar 2020 08:24:48 -0700 |
322 |
-Subject: [PATCH] Fix possible crash when downloading attachments |
323 |
- |
324 |
-Turns out we've been happily deleting network replies from the |
325 |
-QNetworkReply::finished(). That was never a good thing to do, but it did |
326 |
-not use to crash with older Qt. Now it does. |
327 |
- |
328 |
-After changing to deleteLater(), there's a window for |
329 |
-already-deregistered replies to generate events, therefore the assert |
330 |
-has to go, too, otherwise Bad Things happen: |
331 |
- |
332 |
- (gdb) bt |
333 |
- #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 |
334 |
- #1 0x00007ffff16bdcd2 in __GI_abort () at abort.c:89 |
335 |
- #2 0x00007ffff2400bcb in qt_message_fatal (context=..., message=<synthetic pointer>...) at /var/tmp/portage/dev-qt/qtcore-5.13.9999/work/qtcore-5.13.9999/src/corelib/global/qlogging.cpp:1904 |
336 |
- #3 QMessageLogger::fatal (this=this@entry=0x7fffffffc990, msg=msg@entry=0x7ffff2690b10 "ASSERT: \"%s\" in file %s, line %d") at /var/tmp/portage/dev-qt/qtcore-5.13.9999/work/qtcore-5.13.9999/src/corelib/global/qlogging.cpp:888 |
337 |
- #4 0x00007ffff23fff7c in qt_assert (assertion=assertion@entry=0x5555558451d7 "reply", file=file@entry=0x555555841a38 "/home/jkt/work/prog/trojita/src/Imap/Network/FileDownloadManager.cpp", line=line@entry=142) |
338 |
- at /var/tmp/portage/dev-qt/qtcore-5.13.9999/work/qtcore-5.13.9999/src/corelib/global/qglobal.cpp:3247 |
339 |
- #5 0x00005555555da840 in Imap::Network::FileDownloadManager::onPartDataTransfered (this=0x555556a20990) |
340 |
- #6 0x00007ffff25f1bdf in QtPrivate::QSlotObjectBase::call (a=0x7fffffffcaa0, r=0x555556a20990, this=0x5555569f99c0) at ../../include/QtCore/../../../qtcore-5.13.9999/src/corelib/kernel/qobjectdefs_impl.h:394 |
341 |
- #7 QMetaObject::activate(QObject*, int, int, void**) () at /var/tmp/portage/dev-qt/qtcore-5.13.9999/work/qtcore-5.13.9999/src/corelib/kernel/qobject.cpp:3787 |
342 |
- #8 0x00007ffff25f20b7 in QMetaObject::activate (sender=sender@entry=0x555556a21370, m=m@entry=0x7ffff3f96b00 <QNetworkReply::staticMetaObject>, local_signal_index=local_signal_index@entry=1, argv=argv@entry=0x0) |
343 |
- at /var/tmp/portage/dev-qt/qtcore-5.13.9999/work/qtcore-5.13.9999/src/corelib/kernel/qobject.cpp:3658 |
344 |
- #9 0x00007ffff3d3cbf3 in QNetworkReply::finished (this=this@entry=0x555556a21370) at .moc/moc_qnetworkreply.cpp:385 |
345 |
- #10 0x0000555555709485 in Imap::Network::MsgPartNetworkReply::slotMyDataChanged() () at /home/jkt/work/prog/trojita/src/Imap/Network/MsgPartNetworkReply.cpp:112 |
346 |
- |
347 |
-BUG: 417697 |
348 |
-Reported-by: Stefan de Konink <stefan@××××××.de> |
349 |
-Change-Id: I79f340c5a471430a14474472513d0a055c7238d6 |
350 |
---- |
351 |
- src/Imap/Network/FileDownloadManager.cpp | 10 ++++++---- |
352 |
- 1 file changed, 6 insertions(+), 4 deletions(-) |
353 |
- |
354 |
-diff --git a/src/Imap/Network/FileDownloadManager.cpp b/src/Imap/Network/FileDownloadManager.cpp |
355 |
-index 16b6c8df..c3f72176 100644 |
356 |
---- a/src/Imap/Network/FileDownloadManager.cpp |
357 |
-+++ b/src/Imap/Network/FileDownloadManager.cpp |
358 |
-@@ -139,7 +139,9 @@ void FileDownloadManager::downloadMessage() |
359 |
- |
360 |
- void FileDownloadManager::onPartDataTransfered() |
361 |
- { |
362 |
-- Q_ASSERT(reply); |
363 |
-+ if (!reply) { |
364 |
-+ return; |
365 |
-+ } |
366 |
- if (reply->error() == QNetworkReply::NoError) { |
367 |
- if (!saving.open(QIODevice::WriteOnly)) { |
368 |
- emit transferError(saving.errorString()); |
369 |
-@@ -192,11 +194,11 @@ void FileDownloadManager::onCombinerTransferError(const QString &message) |
370 |
- |
371 |
- void FileDownloadManager::deleteReply(QNetworkReply *reply) |
372 |
- { |
373 |
-- if (reply == this->reply) { |
374 |
-+ if (reply && reply == this->reply) { |
375 |
- if (!saved) |
376 |
- onPartDataTransfered(); |
377 |
-- delete reply; |
378 |
-- this->reply = 0; |
379 |
-+ reply->deleteLater(); |
380 |
-+ this->reply = nullptr; |
381 |
- } |
382 |
- } |
383 |
- |
384 |
--- |
385 |
-GitLab |
386 |
- |
387 |
|
388 |
diff --git a/mail-client/trojita/files/trojita-0.7-desktop-spec-namespace.patch b/mail-client/trojita/files/trojita-0.7-desktop-spec-namespace.patch |
389 |
deleted file mode 100644 |
390 |
index 27ffe2c1ad0..00000000000 |
391 |
--- a/mail-client/trojita/files/trojita-0.7-desktop-spec-namespace.patch |
392 |
+++ /dev/null |
393 |
@@ -1,57 +0,0 @@ |
394 |
-From d080f7855707634867593163e7d20ac85694f5be Mon Sep 17 00:00:00 2001 |
395 |
-From: Luigi Toscano <luigi.toscano@×××××××.it> |
396 |
-Date: Mon, 3 Oct 2016 22:29:22 +0200 |
397 |
-Subject: [PATCH] Add namespace to desktop and appdata files |
398 |
- |
399 |
-Add the organization namespace to the desktop and then appdata files, |
400 |
-according the Desktop Entry specification. |
401 |
- |
402 |
-Change-Id: I4c400ef0f120c3f549c0e19b4e74550cc8b54be8 |
403 |
---- |
404 |
- CMakeLists.txt | 6 +++--- |
405 |
- .../{trojita.appdata.xml => org.kde.trojita.appdata.xml} | 2 +- |
406 |
- src/Gui/{trojita.desktop => org.kde.trojita.desktop} | 0 |
407 |
- 3 files changed, 4 insertions(+), 4 deletions(-) |
408 |
- rename src/Gui/{trojita.appdata.xml => org.kde.trojita.appdata.xml} (99%) |
409 |
- rename src/Gui/{trojita.desktop => org.kde.trojita.desktop} (100%) |
410 |
- |
411 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
412 |
-index da40ddb3..d242eda0 100644 |
413 |
---- a/CMakeLists.txt |
414 |
-+++ b/CMakeLists.txt |
415 |
-@@ -728,10 +728,10 @@ if(WITH_ABOOKADDRESSBOOK_PLUGIN) |
416 |
- endif() |
417 |
- |
418 |
- if(WITH_DESKTOP) |
419 |
-- copy_desktop_file_without_cruft("${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/trojita.desktop" "${CMAKE_CURRENT_BINARY_DIR}/trojita-DesktopGui.desktop") |
420 |
-+ copy_desktop_file_without_cruft("${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/org.kde.trojita.desktop" "${CMAKE_CURRENT_BINARY_DIR}/org.kde.trojita-DesktopGui.desktop") |
421 |
- install(TARGETS trojita RUNTIME DESTINATION bin) |
422 |
-- install(FILES ${CMAKE_CURRENT_BINARY_DIR}/trojita-DesktopGui.desktop DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/applications/" RENAME trojita.desktop) |
423 |
-- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/trojita.appdata.xml DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/appdata/") |
424 |
-+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.trojita-DesktopGui.desktop DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/applications/" RENAME org.kde.trojita.desktop) |
425 |
-+ install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/org.kde.trojita.appdata.xml DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/appdata/") |
426 |
- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/icons/trojita.png DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor/32x32/apps/") |
427 |
- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/icons/trojita.svg DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor/scalable/apps/") |
428 |
- endif() |
429 |
-diff --git a/src/Gui/trojita.appdata.xml b/src/Gui/org.kde.trojita.appdata.xml |
430 |
-similarity index 99% |
431 |
-rename from src/Gui/trojita.appdata.xml |
432 |
-rename to src/Gui/org.kde.trojita.appdata.xml |
433 |
-index 39548041..04f9873c 100644 |
434 |
---- a/src/Gui/trojita.appdata.xml |
435 |
-+++ b/src/Gui/org.kde.trojita.appdata.xml |
436 |
-@@ -1,6 +1,6 @@ |
437 |
- <?xml version="1.0" encoding="utf-8"?> |
438 |
- <component type="desktop"> |
439 |
-- <id>trojita.desktop</id> |
440 |
-+ <id>org.kde.trojita.desktop</id> |
441 |
- <metadata_license>CC0-1.0</metadata_license> |
442 |
- <project_license>GPL-2.0+</project_license> |
443 |
- <name>Trojitá</name> |
444 |
-diff --git a/src/Gui/trojita.desktop b/src/Gui/org.kde.trojita.desktop |
445 |
-similarity index 100% |
446 |
-rename from src/Gui/trojita.desktop |
447 |
-rename to src/Gui/org.kde.trojita.desktop |
448 |
--- |
449 |
-GitLab |
450 |
- |
451 |
|
452 |
diff --git a/mail-client/trojita/files/trojita-0.7-gpg-tests.patch b/mail-client/trojita/files/trojita-0.7-gpg-tests.patch |
453 |
deleted file mode 100644 |
454 |
index db41ee577e8..00000000000 |
455 |
--- a/mail-client/trojita/files/trojita-0.7-gpg-tests.patch |
456 |
+++ /dev/null |
457 |
@@ -1,27 +0,0 @@ |
458 |
-commit be8fd5831afa0a04f14cd6206e6576f03ee59558 |
459 |
-Author: Amaury Pouly <amaury.pouly@×××××.com> |
460 |
-Date: Sat Sep 17 16:40:46 2016 +0100 |
461 |
- |
462 |
- Fix GPG test |
463 |
- |
464 |
- At least GnuPG, when run with both --fingerprint and --with-colons will output |
465 |
- the fingerprint of the public key and the subkey. The command below will thus |
466 |
- output two fingerprints and the delete command will fail because it cannot |
467 |
- find the second fingerprint (which is a subkey and not a public key). It seems |
468 |
- that a safe approach is to consider only the first fingerprint line. |
469 |
- |
470 |
- Change-Id: I4c6aa79e4473bca146aa087728a5652d91586a81 |
471 |
- |
472 |
-diff --git a/tests/Cryptography/keygen.sh b/tests/Cryptography/keygen.sh |
473 |
-index c94c0ab..98c69ca 100755 |
474 |
---- a/tests/Cryptography/keygen.sh |
475 |
-+++ b/tests/Cryptography/keygen.sh |
476 |
-@@ -115,7 +115,7 @@ $TAIL" > crypto_test_data.h |
477 |
- echo -n "key *\nexpire\nseconds=1\nsave\n" | ${GPG} --no-tty --quiet --command-fd 0 --edit-key "expired@×××××××××××××××××××.net" |
478 |
- |
479 |
- # extract fingerprint of key to be deleted |
480 |
--FINGERPRINT="$(${GPG} --quiet --no-tty --list-keys --with-colons --fingerprint unknown@×××××××××××××××××××.net | grep fpr | cut -d : -f 10)" |
481 |
-+FINGERPRINT="$(${GPG} --quiet --no-tty --list-keys --with-colons --fingerprint unknown@×××××××××××××××××××.net | grep fpr | head -n 1 | cut -d : -f 10)" |
482 |
- |
483 |
- # delete key |
484 |
- yes | DISPLAY="" ${GPG} --quiet --batch --no-tty --delete-secret-and-public-key --yes --command-fd 0 --passphrase-fd 0 "${FINGERPRINT}" |
485 |
|
486 |
diff --git a/mail-client/trojita/files/trojita-0.7-gpgme.patch b/mail-client/trojita/files/trojita-0.7-gpgme.patch |
487 |
deleted file mode 100644 |
488 |
index 2a7a6d5e708..00000000000 |
489 |
--- a/mail-client/trojita/files/trojita-0.7-gpgme.patch |
490 |
+++ /dev/null |
491 |
@@ -1,34 +0,0 @@ |
492 |
-commit 1978d0a12d2cb4886c5612d6a50b145f409d815c |
493 |
-Author: Andreas Sturmlechner <andreas.sturmlechner@×××××.com> |
494 |
-Date: Wed Oct 26 22:42:47 2016 +0200 |
495 |
- |
496 |
- Switch from KF5Gpgmepp to Gpgmepp |
497 |
- |
498 |
- Gpgmepp is part of GpgME since 1.7.0. |
499 |
- |
500 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
501 |
-index edf3e79..6993d2e 100644 |
502 |
---- a/CMakeLists.txt |
503 |
-+++ b/CMakeLists.txt |
504 |
-@@ -84,7 +84,7 @@ trojita_plugin_option(WITH_QTKEYCHAIN_PLUGIN "Build Qtkeychain password plugin" |
505 |
- trojita_find_package(Git "" "" "" "") |
506 |
- |
507 |
- trojita_find_package(Mimetic "" "http://www.codesink.org/mimetic_mime_library.html" "C++ MIME Library" "Required for client-side MIME parsing" WITH_MIMETIC) |
508 |
--trojita_find_package(KF5Gpgmepp "" "https://quickgit.kde.org/?p=gpgmepp.git" "C++ bindings for gpgme" "Needed for encrypted/signed e-mails" WITH_GPGMEPP) |
509 |
-+trojita_find_package(QGpgme 1.8.0 "http://www.gnupg.org" "Qt5/C++ bindings for GpgME" "Needed for encrypted/signed e-mails" WITH_GPGMEPP) |
510 |
- trojita_option(WITH_CRYPTO_MESSAGES "Enable support for encrypted messages" AUTO "WITH_MIMETIC;WITH_GPGMEPP") |
511 |
- |
512 |
- if(WIN32) |
513 |
-@@ -615,11 +615,7 @@ if(WITH_MIMETIC) |
514 |
- endif() |
515 |
- if(WITH_CRYPTO_MESSAGES) |
516 |
- if(WITH_GPGMEPP) |
517 |
-- if (WIN32) |
518 |
-- target_link_libraries(Cryptography KF5::Gpgmepp KF5::QGpgme) |
519 |
-- else() |
520 |
-- target_link_libraries(Cryptography KF5::Gpgmepp-pthread KF5::QGpgme) |
521 |
-- endif() |
522 |
-+ target_link_libraries(Cryptography QGpgme) |
523 |
- endif() |
524 |
- endif() |
525 |
- |
526 |
|
527 |
diff --git a/mail-client/trojita/files/trojita-0.7-metainfo.patch b/mail-client/trojita/files/trojita-0.7-metainfo.patch |
528 |
deleted file mode 100644 |
529 |
index 705fe714376..00000000000 |
530 |
--- a/mail-client/trojita/files/trojita-0.7-metainfo.patch |
531 |
+++ /dev/null |
532 |
@@ -1,26 +0,0 @@ |
533 |
-From 4706896bbc3d7d9189a64117b75c01399b5271b9 Mon Sep 17 00:00:00 2001 |
534 |
-From: Luigi Toscano <luigi.toscano@×××××××.it> |
535 |
-Date: Mon, 3 Oct 2016 22:30:22 +0200 |
536 |
-Subject: [PATCH] Use the new directory for metadata (metainfo) files |
537 |
- |
538 |
-Change-Id: I06d721c6e082166fc303435b39e42c9f358ecca9 |
539 |
---- |
540 |
- CMakeLists.txt | 2 +- |
541 |
- 1 file changed, 1 insertion(+), 1 deletion(-) |
542 |
- |
543 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
544 |
-index d242eda0..9393b19c 100644 |
545 |
---- a/CMakeLists.txt |
546 |
-+++ b/CMakeLists.txt |
547 |
-@@ -731,7 +731,7 @@ if(WITH_DESKTOP) |
548 |
- copy_desktop_file_without_cruft("${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/org.kde.trojita.desktop" "${CMAKE_CURRENT_BINARY_DIR}/org.kde.trojita-DesktopGui.desktop") |
549 |
- install(TARGETS trojita RUNTIME DESTINATION bin) |
550 |
- install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.trojita-DesktopGui.desktop DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/applications/" RENAME org.kde.trojita.desktop) |
551 |
-- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/org.kde.trojita.appdata.xml DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/appdata/") |
552 |
-+ install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/Gui/org.kde.trojita.appdata.xml DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/metainfo/") |
553 |
- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/icons/trojita.png DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor/32x32/apps/") |
554 |
- install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/icons/trojita.svg DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor/scalable/apps/") |
555 |
- endif() |
556 |
--- |
557 |
-GitLab |
558 |
- |
559 |
|
560 |
diff --git a/mail-client/trojita/files/trojita-0.7-qt-5.11b3.patch b/mail-client/trojita/files/trojita-0.7-qt-5.11b3.patch |
561 |
deleted file mode 100644 |
562 |
index 32d1a021972..00000000000 |
563 |
--- a/mail-client/trojita/files/trojita-0.7-qt-5.11b3.patch |
564 |
+++ /dev/null |
565 |
@@ -1,207 +0,0 @@ |
566 |
-From 7a9f7e0629aa28ffafc4433bbdf43a011754d7c3 Mon Sep 17 00:00:00 2001 |
567 |
-From: Andreas Sturmlechner <asturm@g.o> |
568 |
-Date: Wed, 18 Apr 2018 18:53:23 +0200 |
569 |
-Subject: [PATCH] Fix build with Qt 5.11_beta3 (dropping qt5_use_modules) |
570 |
- |
571 |
---- |
572 |
- CMakeLists.txt | 1 - |
573 |
- cmake/TrojitaOption.cmake | 2 +- |
574 |
- 2 files changed, 1 insertion(+), 2 deletions(-) |
575 |
- |
576 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
577 |
-index 3a882370..781e576b 100644 |
578 |
---- a/CMakeLists.txt |
579 |
-+++ b/CMakeLists.txt |
580 |
-@@ -1,7 +1,6 @@ |
581 |
- project(trojita) |
582 |
- set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake) |
583 |
- |
584 |
--# Qt5's qt5_use_modules need 2.8.9+ |
585 |
- # On win32, we need QtMain linking, which means 2.8.11+ |
586 |
- # EL7 ships 2.8.11, Debian 8 ships 3.0.2, and Ubuntu 14.04 LTS has 2.8.12 |
587 |
- cmake_minimum_required(VERSION 2.8.11) |
588 |
-diff --git a/cmake/TrojitaOption.cmake b/cmake/TrojitaOption.cmake |
589 |
-index ed99e952..8ac6b6be 100644 |
590 |
---- a/cmake/TrojitaOption.cmake |
591 |
-+++ b/cmake/TrojitaOption.cmake |
592 |
-@@ -100,7 +100,7 @@ macro(trojita_add_plugin target type) |
593 |
- set_property(TARGET ${target} APPEND PROPERTY COMPILE_DEFINITIONS BUILD_PLUGIN) |
594 |
- target_link_libraries(${target} Plugins) |
595 |
- if (WITH_QT5) |
596 |
-- qt5_use_modules(${target} Core) |
597 |
-+ target_link_libraries(${target} Qt5::Core) |
598 |
- else() |
599 |
- target_link_libraries(${target} ${QT_QTCORE_LIBRARY}) |
600 |
- endif() |
601 |
--- |
602 |
-2.17.0 |
603 |
- |
604 |
-From 94adf1d2e3e2d4a9e0c59fa9423ae711cf55c6fa Mon Sep 17 00:00:00 2001 |
605 |
-From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= <jkt@×××.org> |
606 |
-Date: Wed, 19 Oct 2016 21:58:57 +0200 |
607 |
-Subject: [PATCH] cmake: do not use qt5_use_modules |
608 |
- |
609 |
-...because the documentation suggests going with imported targets and |
610 |
-target_link_libraries. |
611 |
- |
612 |
-Change-Id: I403d40d0b0ac8d88cadb011c2c2a643221f15daf |
613 |
---- |
614 |
- CMakeLists.txt | 42 ++++++++++++++++-------------------------- |
615 |
- 1 file changed, 16 insertions(+), 26 deletions(-) |
616 |
- |
617 |
-diff --git a/CMakeLists.txt b/CMakeLists.txt |
618 |
-index 92a682f7..f0d395d6 100644 |
619 |
---- a/CMakeLists.txt |
620 |
-+++ b/CMakeLists.txt |
621 |
-@@ -552,13 +552,13 @@ set_source_files_properties(${version_files} |
622 |
- add_library(Common STATIC ${libCommon_SOURCES}) |
623 |
- set_property(TARGET Common APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
624 |
- add_dependencies(Common version) |
625 |
--qt5_use_modules(Common Core Network) |
626 |
-+target_link_libraries(Common Qt5::Network) |
627 |
- |
628 |
- add_library(AppVersion STATIC ${libAppVersion_SOURCES}) |
629 |
- set_property(TARGET AppVersion APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
630 |
- add_dependencies(AppVersion version) |
631 |
- target_link_libraries(AppVersion Common) |
632 |
--qt5_use_modules(AppVersion Core) |
633 |
-+target_link_libraries(AppVersion Qt5::Core) |
634 |
- |
635 |
- if(WITH_SHARED_PLUGINS) |
636 |
- add_library(Plugins SHARED ${libPlugins_SOURCES}) |
637 |
-@@ -569,12 +569,11 @@ else() |
638 |
- endif() |
639 |
- set_target_properties(Plugins PROPERTIES OUTPUT_NAME trojita_plugins) |
640 |
- set_property(TARGET Plugins APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
641 |
--qt5_use_modules(Plugins Core) |
642 |
-+target_link_libraries(Plugins Qt5::Core) |
643 |
- |
644 |
- add_library(UiUtils STATIC ${libUiUtils_SOURCES}) |
645 |
- set_property(TARGET UiUtils APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
646 |
--target_link_libraries(UiUtils Plugins Common) |
647 |
--qt5_use_modules(UiUtils Core Gui Network) |
648 |
-+target_link_libraries(UiUtils Plugins Common Qt5::Gui) |
649 |
- |
650 |
- add_library(Streams STATIC ${libStreams_SOURCES}) |
651 |
- set_property(TARGET Streams APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
652 |
-@@ -582,36 +581,32 @@ if(WITH_ZLIB) |
653 |
- set_property(TARGET Streams APPEND PROPERTY INCLUDE_DIRECTORIES ${ZLIB_INCLUDE_DIR}) |
654 |
- target_link_libraries(Streams ${ZLIB_LIBRARIES}) |
655 |
- endif() |
656 |
--qt5_use_modules(Streams Network) |
657 |
-+target_link_libraries(Streams Qt5::Network) |
658 |
- |
659 |
- add_library(IPC STATIC ${libIPC_SOURCES}) |
660 |
- set_property(TARGET IPC APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
661 |
- if(WITH_DBUS) |
662 |
-- qt5_use_modules(IPC DBus Widgets) |
663 |
-+ target_link_libraries(IPC Qt5::DBus Qt5::Widgets) |
664 |
- else() |
665 |
-- qt5_use_modules(IPC Core) |
666 |
-+ target_link_libraries(IPC Qt5::Core) |
667 |
- endif() |
668 |
- |
669 |
- add_library(qwwsmtpclient STATIC ${libqwwsmtpclient_SOURCES}) |
670 |
--qt5_use_modules(qwwsmtpclient Network) |
671 |
-+target_link_libraries(qwwsmtpclient Qt5::Network) |
672 |
- |
673 |
- add_library(MSA STATIC ${libMSA_SOURCES}) |
674 |
- set_property(TARGET MSA APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
675 |
- target_link_libraries(MSA Imap Streams qwwsmtpclient) |
676 |
--qt5_use_modules(MSA Network) |
677 |
- |
678 |
- add_library(Composer STATIC ${libComposer_SOURCES}) |
679 |
- set_property(TARGET Composer APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
680 |
- target_link_libraries(Composer Common MSA Streams UiUtils qwwsmtpclient) |
681 |
--qt5_use_modules(Composer Gui Network) |
682 |
- |
683 |
- add_library(Imap STATIC ${libImap_SOURCES}) |
684 |
- set_property(TARGET Imap APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
685 |
--target_link_libraries(Imap Common Streams UiUtils) |
686 |
--qt5_use_modules(Imap Gui Network Sql) |
687 |
-+target_link_libraries(Imap Common Streams UiUtils Qt5::Sql) |
688 |
- |
689 |
- add_library(Cryptography STATIC ${libCryptography_SOURCES}) |
690 |
--qt5_use_modules(Cryptography Core) |
691 |
- set_property(TARGET Cryptography APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
692 |
- target_link_libraries(Cryptography Common Imap) |
693 |
- if(WITH_MIMETIC) |
694 |
-@@ -636,8 +631,7 @@ endif() |
695 |
- ## QtKeyChain plugin |
696 |
- if(WITH_QTKEYCHAIN_PLUGIN) |
697 |
- trojita_add_plugin(trojita_plugin_QtKeychainPasswordPlugin WITH_QTKEYCHAIN_PLUGIN src/Plugins/QtKeyChain/QtKeyChainPassword.cpp) |
698 |
-- qt5_use_modules(trojita_plugin_QtKeychainPasswordPlugin Core DBus) |
699 |
-- target_link_libraries(trojita_plugin_QtKeychainPasswordPlugin ${QTKEYCHAIN_LIBRARIES}) |
700 |
-+ target_link_libraries(trojita_plugin_QtKeychainPasswordPlugin ${QTKEYCHAIN_LIBRARIES} Qt5::DBus) |
701 |
- set_property(TARGET trojita_plugin_QtKeychainPasswordPlugin APPEND PROPERTY INCLUDE_DIRECTORIES ${QTKEYCHAIN_INCLUDE_DIRS}) |
702 |
- endif() |
703 |
- |
704 |
-@@ -662,7 +656,7 @@ if(WITH_ABOOKADDRESSBOOK_PLUGIN) |
705 |
- trojita_add_plugin(trojita_plugin_AbookAddressbookPlugin WITH_ABOOKADDRESSBOOK_PLUGIN ${libAbookAddressbook_SOURCES} ${libAbookAddressbook_UI_OUT}) |
706 |
- set_property(TARGET trojita_plugin_AbookAddressbookPlugin APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
707 |
- |
708 |
-- qt5_use_modules(trojita_plugin_AbookAddressbookPlugin Widgets) |
709 |
-+ target_link_libraries(trojita_plugin_AbookAddressbookPlugin Qt5::Widgets) |
710 |
- |
711 |
- set(be_contacts_SOURCES |
712 |
- ${path_AbookAddressbook}/main.cpp |
713 |
-@@ -675,7 +669,7 @@ if(WITH_ABOOKADDRESSBOOK_PLUGIN) |
714 |
- set_property(TARGET be.contacts APPEND PROPERTY COMPILE_DEFINITIONS QT_STATICPLUGIN) |
715 |
- target_link_libraries(be.contacts trojita_plugin_AbookAddressbookPlugin) |
716 |
- endif() |
717 |
-- qt5_use_modules(be.contacts Widgets) |
718 |
-+ target_link_libraries(be.contacts Qt5::Widgets) |
719 |
- endif() |
720 |
- |
721 |
- # Generate file static_plugins.h.in |
722 |
-@@ -695,15 +689,13 @@ if(WITH_DESKTOP) |
723 |
- # The following is needed for the LineEdit widget within the .ui files. |
724 |
- # The ${path_DesktopGui} is needed so that the generated ui_*.h file can find the headers of the custom widgets |
725 |
- set_property(TARGET DesktopGui APPEND PROPERTY INCLUDE_DIRECTORIES ${path_DesktopGui}) |
726 |
-- target_link_libraries(DesktopGui Common UiUtils Composer Cryptography Imap IPC MSA Plugins Streams qwwsmtpclient) |
727 |
-+ target_link_libraries(DesktopGui Common UiUtils Composer Cryptography Imap IPC MSA Plugins Streams qwwsmtpclient Qt5::WebKitWidgets) |
728 |
- |
729 |
- # On Windows build a real Win32 GUI application without console window |
730 |
- # On other platforms WIN32 flag is ignored |
731 |
- add_executable(trojita WIN32 ${trojita_desktop_SOURCES} ${trojita_QM}) |
732 |
- set_property(TARGET trojita APPEND PROPERTY COMPILE_DEFINITIONS QT_NO_CAST_FROM_ASCII QT_NO_CAST_TO_ASCII) |
733 |
- target_link_libraries(trojita AppVersion Common UiUtils DesktopGui ${STATIC_PLUGINS}) |
734 |
-- qt5_use_modules(DesktopGui Network WebKitWidgets) |
735 |
-- qt5_use_modules(trojita Widgets Network) |
736 |
- endif() |
737 |
- |
738 |
- |
739 |
-@@ -737,17 +729,15 @@ if(WITH_TESTS) |
740 |
- tests/Utils/LibMailboxSync.cpp |
741 |
- ) |
742 |
- add_library(test_LibMailboxSync STATIC ${test_LibMailboxSync_SOURCES}) |
743 |
-- qt5_use_modules(test_LibMailboxSync Test Network) |
744 |
- set_property(TARGET test_LibMailboxSync APPEND PROPERTY INCLUDE_DIRECTORIES |
745 |
- ${CMAKE_CURRENT_SOURCE_DIR}/tests |
746 |
- ${CMAKE_CURRENT_SOURCE_DIR}/tests/Utils) |
747 |
-- target_link_libraries(test_LibMailboxSync Imap MSA Streams Common Composer) |
748 |
-+ target_link_libraries(test_LibMailboxSync Imap MSA Streams Common Composer Qt5::Test) |
749 |
- |
750 |
- macro(trojita_test dir fname) |
751 |
- set(test_${fname}_SOURCES tests/${dir}/test_${fname}.cpp) |
752 |
- add_executable(test_${fname} ${test_${fname}_SOURCES}) |
753 |
- target_link_libraries(test_${fname} Imap MSA Streams Common Composer Cryptography test_LibMailboxSync) |
754 |
-- qt5_use_modules(test_${fname} Network Sql Test Widgets) |
755 |
- set_property(TARGET test_${fname} APPEND PROPERTY INCLUDE_DIRECTORIES ${CMAKE_CURRENT_SOURCE_DIR}/tests) |
756 |
- if(NOT CMAKE_CROSSCOMPILING) |
757 |
- add_test(test_${fname} test_${fname}) |
758 |
-@@ -759,9 +749,9 @@ if(WITH_TESTS) |
759 |
- enable_testing() |
760 |
- trojita_test(Composer Composer_Submission) |
761 |
- trojita_test(Composer Composer_responses) |
762 |
-+ target_link_libraries(test_Composer_responses Qt5::WebKitWidgets) |
763 |
- trojita_test(Composer Html_formatting) |
764 |
-- qt5_use_modules(test_Composer_responses WebKitWidgets) |
765 |
-- qt5_use_modules(test_Html_formatting WebKitWidgets) |
766 |
-+ target_link_libraries(test_Html_formatting Qt5::WebKitWidgets) |
767 |
- trojita_test(Imap Imap_DisappearingMailboxes) |
768 |
- trojita_test(Imap Imap_Idle) |
769 |
- trojita_test(Imap Imap_LowLevelParser) |
770 |
--- |
771 |
-2.17.0 |
772 |
- |
773 |
|
774 |
diff --git a/mail-client/trojita/files/trojita-0.7-qt-5.13.patch b/mail-client/trojita/files/trojita-0.7-qt-5.13.patch |
775 |
deleted file mode 100644 |
776 |
index 9f1ab3e7e88..00000000000 |
777 |
--- a/mail-client/trojita/files/trojita-0.7-qt-5.13.patch |
778 |
+++ /dev/null |
779 |
@@ -1,37 +0,0 @@ |
780 |
-From 39772585033c1c0aff96f297e93de7be53f9b114 Mon Sep 17 00:00:00 2001 |
781 |
-From: Heiko Becker <heirecka@×××××××.org> |
782 |
-Date: Sat, 23 Mar 2019 01:17:11 +0100 |
783 |
-Subject: [PATCH] tests: Fix build with Qt 5.13 |
784 |
- |
785 |
-QTest::toString(QModelIndex) was added in |
786 |
-7ef0b575b38d267bd3dc14ff46935d556562ff00 and thus causes a build |
787 |
-error with Qt 5.13 because it's redefined here. |
788 |
- |
789 |
-Change-Id: I015800e49cf8d0e87f3541642406396f150d0eeb |
790 |
---- |
791 |
- tests/Imap/test_Imap_BodyParts.cpp | 2 ++ |
792 |
- 1 file changed, 2 insertions(+) |
793 |
- |
794 |
-diff --git a/tests/Imap/test_Imap_BodyParts.cpp b/tests/Imap/test_Imap_BodyParts.cpp |
795 |
-index f1c577fa..b6e0421d 100644 |
796 |
---- a/tests/Imap/test_Imap_BodyParts.cpp |
797 |
-+++ b/tests/Imap/test_Imap_BodyParts.cpp |
798 |
-@@ -51,6 +51,7 @@ struct Data { |
799 |
- |
800 |
- Q_DECLARE_METATYPE(QList<Data>) |
801 |
- |
802 |
-+#if QT_VERSION < QT_VERSION_CHECK(5, 13, 0) |
803 |
- namespace QTest { |
804 |
- template <> |
805 |
- char *toString(const QModelIndex &index) |
806 |
-@@ -60,6 +61,7 @@ char *toString(const QModelIndex &index) |
807 |
- return qstrdup(buf.toUtf8().constData()); |
808 |
- } |
809 |
- } |
810 |
-+#endif |
811 |
- |
812 |
- using namespace Imap::Mailbox; |
813 |
- |
814 |
--- |
815 |
-GitLab |
816 |
- |
817 |
|
818 |
diff --git a/mail-client/trojita/files/trojita-0.7-qt-5.15.patch b/mail-client/trojita/files/trojita-0.7-qt-5.15.patch |
819 |
deleted file mode 100644 |
820 |
index f6ce4cc938d..00000000000 |
821 |
--- a/mail-client/trojita/files/trojita-0.7-qt-5.15.patch |
822 |
+++ /dev/null |
823 |
@@ -1,28 +0,0 @@ |
824 |
-From 2869c385e72932cbed7398742b8a4d5e3feda765 Mon Sep 17 00:00:00 2001 |
825 |
-From: Heiko Becker <heirecka@×××××××.org> |
826 |
-Date: Tue, 24 Mar 2020 13:14:43 +0100 |
827 |
-Subject: Fix build with Qt 5.15.0 |
828 |
- |
829 |
-QPainterPath is no longer included via qtransform.h (since |
830 |
-5.15.0-beta2, 50d2acdc93b4de2ba56eb67787e2bdcb21dd4bea in qtbase.git). |
831 |
- |
832 |
-Change-Id: Ibb59e769bba8514d86aa886afee26a2395d458ef |
833 |
---- |
834 |
- src/Gui/Window.cpp | 1 + |
835 |
- 1 file changed, 1 insertion(+) |
836 |
- |
837 |
-diff --git a/src/Gui/Window.cpp b/src/Gui/Window.cpp |
838 |
-index 65ba246..8d74874 100644 |
839 |
---- a/src/Gui/Window.cpp |
840 |
-+++ b/src/Gui/Window.cpp |
841 |
-@@ -32,6 +32,7 @@ |
842 |
- #include <QKeyEvent> |
843 |
- #include <QMenuBar> |
844 |
- #include <QMessageBox> |
845 |
-+#include <QPainterPath> |
846 |
- #include <QProgressBar> |
847 |
- #include <QRegularExpression> |
848 |
- #include <QScopedPointer> |
849 |
--- |
850 |
-cgit v1.1 |
851 |
- |
852 |
|
853 |
diff --git a/mail-client/trojita/metadata.xml b/mail-client/trojita/metadata.xml |
854 |
deleted file mode 100644 |
855 |
index 8cee3d85364..00000000000 |
856 |
--- a/mail-client/trojita/metadata.xml |
857 |
+++ /dev/null |
858 |
@@ -1,23 +0,0 @@ |
859 |
-<?xml version="1.0" encoding="UTF-8"?> |
860 |
-<!DOCTYPE pkgmetadata SYSTEM "https://www.gentoo.org/dtd/metadata.dtd"> |
861 |
-<pkgmetadata> |
862 |
- <maintainer type="person" proxied="yes"> |
863 |
- <email>jkt@×××.org</email> |
864 |
- <name>Jan Kundrát</name> |
865 |
- </maintainer> |
866 |
- <maintainer type="project"> |
867 |
- <email>qt@g.o</email> |
868 |
- <name>Gentoo Qt Project</name> |
869 |
- </maintainer> |
870 |
- <maintainer type="project"> |
871 |
- <email>kde@g.o</email> |
872 |
- <name>Gentoo KDE Project</name> |
873 |
- </maintainer> |
874 |
- <use> |
875 |
- <flag name="password">Store passwords securely via <pkg>dev-libs/qtkeychain</pkg></flag> |
876 |
- <flag name="pim">Enable support for KDE PIM resources integration via <pkg>kde-apps/akonadi</pkg> addressbook plugin</flag> |
877 |
- </use> |
878 |
- <upstream> |
879 |
- <remote-id type="sourceforge">trojita</remote-id> |
880 |
- </upstream> |
881 |
-</pkgmetadata> |
882 |
|
883 |
diff --git a/mail-client/trojita/trojita-0.7-r6.ebuild b/mail-client/trojita/trojita-0.7-r6.ebuild |
884 |
deleted file mode 100644 |
885 |
index 7c1b4c0b6fa..00000000000 |
886 |
--- a/mail-client/trojita/trojita-0.7-r6.ebuild |
887 |
+++ /dev/null |
888 |
@@ -1,90 +0,0 @@ |
889 |
-# Copyright 1999-2020 Gentoo Authors |
890 |
-# Distributed under the terms of the GNU General Public License v2 |
891 |
- |
892 |
-EAPI=7 |
893 |
- |
894 |
-if [[ ${PV} = *9999* ]]; then |
895 |
- EGIT_REPO_URI="https://anongit.kde.org/${PN}.git" |
896 |
- inherit git-r3 |
897 |
-else |
898 |
- SRC_URI="mirror://sourceforge/${PN}/${P}.tar.xz" |
899 |
- KEYWORDS="amd64 x86" |
900 |
-fi |
901 |
-inherit cmake virtualx xdg |
902 |
- |
903 |
-DESCRIPTION="A Qt IMAP e-mail client" |
904 |
-HOMEPAGE="http://trojita.flaska.net/" |
905 |
- |
906 |
-LICENSE="|| ( GPL-2 GPL-3 )" |
907 |
-SLOT="0" |
908 |
-IUSE="+crypt +dbus debug +password test +zlib" |
909 |
- |
910 |
-REQUIRED_USE="password? ( dbus )" |
911 |
-RESTRICT="!test? ( test )" |
912 |
- |
913 |
-BDEPEND=" |
914 |
- dev-qt/linguist-tools:5 |
915 |
- zlib? ( virtual/pkgconfig ) |
916 |
-" |
917 |
-RDEPEND=" |
918 |
- dev-qt/qtcore:5 |
919 |
- dev-qt/qtgui:5 |
920 |
- dev-qt/qtnetwork:5[ssl] |
921 |
- dev-qt/qtsql:5[sqlite] |
922 |
- dev-qt/qtsvg:5 |
923 |
- dev-qt/qtwebkit:5 |
924 |
- dev-qt/qtwidgets:5 |
925 |
- crypt? ( |
926 |
- >=app-crypt/gpgme-1.8.0[cxx,qt5] |
927 |
- dev-libs/mimetic |
928 |
- ) |
929 |
- dbus? ( dev-qt/qtdbus:5 ) |
930 |
- password? ( dev-libs/qtkeychain[qt5(+)] ) |
931 |
- zlib? ( sys-libs/zlib ) |
932 |
-" |
933 |
-DEPEND="${RDEPEND} |
934 |
- test? ( dev-qt/qttest:5 ) |
935 |
-" |
936 |
- |
937 |
-DOCS=( README LICENSE ) |
938 |
- |
939 |
-PATCHES=( |
940 |
- "${FILESDIR}/${P}-gpgme.patch" |
941 |
- "${FILESDIR}/${P}-gpg-tests.patch" |
942 |
- "${FILESDIR}/${P}-qt-5.11b3.patch" |
943 |
- "${FILESDIR}/${P}-qt-5.13.patch" # bug 730058 |
944 |
- "${FILESDIR}/${P}-qt-5.15.patch" |
945 |
- "${FILESDIR}/${P}-CVE-2019-10734.patch" # KDE-bug 404697 |
946 |
- "${FILESDIR}/${P}-CVE-2020-15047.patch" # bug 729596 |
947 |
- "${FILESDIR}/${P}-cmake-cxx11.patch" |
948 |
- "${FILESDIR}/${P}-desktop-spec-namespace.patch" |
949 |
- "${FILESDIR}/${P}-metainfo.patch" # bug 730140 |
950 |
- "${FILESDIR}/${P}-crash-w-attachments.patch" # KDE-Bug 417697 |
951 |
-) |
952 |
- |
953 |
-src_prepare() { |
954 |
- cmake_src_prepare |
955 |
- |
956 |
- # the build system is taking a look at `git describe ... --dirty` and |
957 |
- # gentoo's modifications to CMakeLists.txt break these |
958 |
- sed -e "s/--dirty//" -i cmake/TrojitaVersion.cmake || die "Cannot fix the version check" |
959 |
-} |
960 |
- |
961 |
-src_configure() { |
962 |
- local mycmakeargs=( |
963 |
- -DWITH_RAGEL=OFF # bug 739866, broken by ragel-7 |
964 |
- -DWITH_CRYPTO_MESSAGES=$(usex crypt) |
965 |
- -DWITH_GPGMEPP=$(usex crypt) |
966 |
- -DWITH_MIMETIC=$(usex crypt) |
967 |
- -DWITH_DBUS=$(usex dbus) |
968 |
- -DWITH_QTKEYCHAIN_PLUGIN=$(usex password) |
969 |
- -DWITH_TESTS=$(usex test) |
970 |
- -DWITH_ZLIB=$(usex zlib) |
971 |
- ) |
972 |
- |
973 |
- cmake_src_configure |
974 |
-} |
975 |
- |
976 |
-src_test() { |
977 |
- virtx cmake_src_test |
978 |
-} |
979 |
|
980 |
diff --git a/mail-client/trojita/trojita-9999.ebuild b/mail-client/trojita/trojita-9999.ebuild |
981 |
deleted file mode 100644 |
982 |
index 0908d71cbc9..00000000000 |
983 |
--- a/mail-client/trojita/trojita-9999.ebuild |
984 |
+++ /dev/null |
985 |
@@ -1,81 +0,0 @@ |
986 |
-# Copyright 1999-2020 Gentoo Authors |
987 |
-# Distributed under the terms of the GNU General Public License v2 |
988 |
- |
989 |
-EAPI=7 |
990 |
- |
991 |
-if [[ ${PV} = *9999* ]]; then |
992 |
- EGIT_REPO_URI="https://anongit.kde.org/${PN}.git" |
993 |
- inherit git-r3 |
994 |
-else |
995 |
- SRC_URI="mirror://sourceforge/${PN}/${P}.tar.xz" |
996 |
- KEYWORDS="~amd64 ~x86" |
997 |
-fi |
998 |
-inherit cmake virtualx xdg |
999 |
- |
1000 |
-DESCRIPTION="A Qt IMAP e-mail client" |
1001 |
-HOMEPAGE="http://trojita.flaska.net/" |
1002 |
- |
1003 |
-LICENSE="|| ( GPL-2 GPL-3 )" |
1004 |
-SLOT="0" |
1005 |
-IUSE="+crypt +dbus debug +password pim +spell test +zlib" |
1006 |
- |
1007 |
-REQUIRED_USE="password? ( dbus )" |
1008 |
-RESTRICT="!test? ( test )" |
1009 |
- |
1010 |
-BDEPEND=" |
1011 |
- dev-qt/linguist-tools:5 |
1012 |
- zlib? ( virtual/pkgconfig ) |
1013 |
-" |
1014 |
-RDEPEND=" |
1015 |
- dev-qt/qtcore:5 |
1016 |
- dev-qt/qtgui:5 |
1017 |
- dev-qt/qtnetwork:5[ssl] |
1018 |
- dev-qt/qtsql:5[sqlite] |
1019 |
- dev-qt/qtsvg:5 |
1020 |
- dev-qt/qtwebkit:5 |
1021 |
- dev-qt/qtwidgets:5 |
1022 |
- crypt? ( |
1023 |
- >=app-crypt/gpgme-1.8.0[cxx,qt5] |
1024 |
- dev-libs/mimetic |
1025 |
- ) |
1026 |
- dbus? ( dev-qt/qtdbus:5 ) |
1027 |
- password? ( dev-libs/qtkeychain[qt5(+)] ) |
1028 |
- pim? ( kde-apps/akonadi-contacts:5 ) |
1029 |
- spell? ( kde-frameworks/sonnet:5 ) |
1030 |
- zlib? ( sys-libs/zlib ) |
1031 |
-" |
1032 |
-DEPEND="${RDEPEND} |
1033 |
- test? ( dev-qt/qttest:5 ) |
1034 |
-" |
1035 |
- |
1036 |
-DOCS=( README LICENSE ) |
1037 |
- |
1038 |
-src_prepare() { |
1039 |
- cmake_src_prepare |
1040 |
- |
1041 |
- # the build system is taking a look at `git describe ... --dirty` and |
1042 |
- # gentoo's modifications to CMakeLists.txt break these |
1043 |
- sed -e "s/--dirty//" -i cmake/TrojitaVersion.cmake || die "Cannot fix the version check" |
1044 |
-} |
1045 |
- |
1046 |
-src_configure() { |
1047 |
- local mycmakeargs=( |
1048 |
- -DWITH_RAGEL=OFF # bug 739866, broken by ragel-7 |
1049 |
- -DWITH_ABOOKADDRESSBOOK_PLUGIN=ON |
1050 |
- -DWITH_CRYPTO_MESSAGES=$(usex crypt) |
1051 |
- -DWITH_GPGMEPP=$(usex crypt) |
1052 |
- -DWITH_MIMETIC=$(usex crypt) |
1053 |
- -DWITH_DBUS=$(usex dbus) |
1054 |
- -DWITH_QTKEYCHAIN_PLUGIN=$(usex password) |
1055 |
- -DWITH_AKONADIADDRESSBOOK_PLUGIN=$(usex pim) |
1056 |
- -DWITH_SONNET_PLUGIN=$(usex spell) |
1057 |
- -DBUILD_TESTING=$(usex test) |
1058 |
- -DWITH_ZLIB=$(usex zlib) |
1059 |
- ) |
1060 |
- |
1061 |
- cmake_src_configure |
1062 |
-} |
1063 |
- |
1064 |
-src_test() { |
1065 |
- virtx cmake_src_test |
1066 |
-} |
1067 |
|
1068 |
diff --git a/profiles/package.mask b/profiles/package.mask |
1069 |
index cce8b5bb87b..4e64dbc33fd 100644 |
1070 |
--- a/profiles/package.mask |
1071 |
+++ b/profiles/package.mask |
1072 |
@@ -334,11 +334,6 @@ games-puzzle/gnudoku |
1073 |
# Preparing for final 5.0.0 release |
1074 |
>=app-text/tesseract-5.0.0_beta |
1075 |
|
1076 |
-# Andreas Sturmlechner <asturm@g.o> (2021-08-02) |
1077 |
-# Depends on Qt5WebKit with more holes in it than swiss cheese. Bug #685750 |
1078 |
-# Last release in 2016. Removal on 2021-10-04. |
1079 |
-mail-client/trojita |
1080 |
- |
1081 |
# Andreas Sturmlechner <asturm@g.o> (2021-08-02) |
1082 |
# Depends on Qt5WebKit with more holes in it than swiss cheese. Bug #740416 |
1083 |
# Removal on 2021-10-04. |