Gentoo Archives: gentoo-commits

From: Mike Gilbert <floppym@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/
Date: Mon, 27 Jun 2022 19:00:05
Message-Id: 1656356386.1aad461ffd13f98f6d736823b1e6678ed0503757.floppym@gentoo
1 commit: 1aad461ffd13f98f6d736823b1e6678ed0503757
2 Author: Mike Gilbert <floppym <AT> gentoo <DOT> org>
3 AuthorDate: Fri Jun 24 16:04:29 2022 +0000
4 Commit: Mike Gilbert <floppym <AT> gentoo <DOT> org>
5 CommitDate: Mon Jun 27 18:59:46 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1aad461f
7
8 user.eclass: allow UID/GID 0 in enewuser/enewgroup
9
10 Used by acct-{user,group}/root.
11
12 The check is skipped on most systems because root is created by baselayout.
13 An error may be produced if a user runs emerge --root=/myroot
14 acct-user/root, where /myroot is an empty directory.
15
16 Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>
17
18 eclass/user.eclass | 8 ++++----
19 1 file changed, 4 insertions(+), 4 deletions(-)
20
21 diff --git a/eclass/user.eclass b/eclass/user.eclass
22 index 906e84e83c69..d5b827d2e76b 100644
23 --- a/eclass/user.eclass
24 +++ b/eclass/user.eclass
25 @@ -123,13 +123,13 @@ enewuser() {
26 # handle uid
27 local euid=${1}; shift
28 if [[ -n ${euid} && ${euid} != -1 ]] ; then
29 - if [[ ${euid} -gt 0 ]] ; then
30 + if [[ ${euid} -ge 0 ]] ; then
31 if [[ -n $(egetent passwd ${euid}) ]] ; then
32 [[ -n ${force_uid} ]] && die "${FUNCNAME}: UID ${euid} already taken"
33 euid="next"
34 fi
35 else
36 - eerror "Userid given but is not greater than 0!"
37 + eerror "Userid given but is not greater than or equal to 0!"
38 die "${euid} is not a valid UID"
39 fi
40 else
41 @@ -289,13 +289,13 @@ enewgroup() {
42 # handle gid
43 local egid=${1}; shift
44 if [[ -n ${egid} && ${egid} != -1 ]] ; then
45 - if [[ ${egid} -gt 0 ]] ; then
46 + if [[ ${egid} -ge 0 ]] ; then
47 if [[ -n $(egetent group ${egid}) ]] ; then
48 [[ -n ${force_gid} ]] && die "${FUNCNAME}: GID ${egid} already taken"
49 egid="next available; requested gid taken"
50 fi
51 else
52 - eerror "Groupid given but is not greater than 0!"
53 + eerror "Groupid given but is not greater than or equal to 0!"
54 die "${egid} is not a valid GID"
55 fi
56 else