1 |
commit: 61c992359d353f5ccac8e997443991cbcb733e73 |
2 |
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
3 |
AuthorDate: Tue Sep 11 14:26:52 2018 +0000 |
4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
5 |
CommitDate: Tue Sep 11 16:23:50 2018 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61c99235 |
7 |
|
8 |
kde-plasma/plasma-desktop: Improve arrow key nav. of kicker search |
9 |
|
10 |
KDE-Bug: https://bugs.kde.org/show_bug.cgi?id=397779 |
11 |
See also: https://phabricator.kde.org/D15286 |
12 |
Package-Manager: Portage-2.3.48, Repoman-2.3.10 |
13 |
|
14 |
.../plasma-desktop-5.13.5-kickersearch-nav.patch | 87 +++++++++++ |
15 |
.../plasma-desktop/plasma-desktop-5.13.5-r1.ebuild | 168 +++++++++++++++++++++ |
16 |
2 files changed, 255 insertions(+) |
17 |
|
18 |
diff --git a/kde-plasma/plasma-desktop/files/plasma-desktop-5.13.5-kickersearch-nav.patch b/kde-plasma/plasma-desktop/files/plasma-desktop-5.13.5-kickersearch-nav.patch |
19 |
new file mode 100644 |
20 |
index 00000000000..75b5bc27b2a |
21 |
--- /dev/null |
22 |
+++ b/kde-plasma/plasma-desktop/files/plasma-desktop-5.13.5-kickersearch-nav.patch |
23 |
@@ -0,0 +1,87 @@ |
24 |
+From 1692ae244bc5229df78df2d5ba2e76418362cb50 Mon Sep 17 00:00:00 2001 |
25 |
+From: Eike Hein <hein@×××.org> |
26 |
+Date: Wed, 5 Sep 2018 18:58:35 +0900 |
27 |
+Subject: Improve arrow key navigation of Kicker search results |
28 |
+ |
29 |
+Summary: |
30 |
+Kicker already makes sure the first search result is highlighted |
31 |
+and actionable while searching. This patch makes arrow-down after |
32 |
+typing move to the second search result instead of merely moving |
33 |
+focus from the search field to the list, so the user doesn't have |
34 |
+to press arrow-down twice anymore. |
35 |
+ |
36 |
+It also allows using arrow-left/right to jump to the other result |
37 |
+columns, when the cursor is at the start or end of the text field, |
38 |
+respectively. |
39 |
+ |
40 |
+BUG:397779 |
41 |
+ |
42 |
+Reviewers: ngraham |
43 |
+ |
44 |
+Subscribers: plasma-devel |
45 |
+ |
46 |
+Tags: #plasma |
47 |
+ |
48 |
+Differential Revision: https://phabricator.kde.org/D15286 |
49 |
+--- |
50 |
+ .../package/contents/ui/MenuRepresentation.qml | 20 +++++++++++++++++++- |
51 |
+ .../kicker/package/contents/ui/RunnerResultsList.qml | 1 + |
52 |
+ 2 files changed, 20 insertions(+), 1 deletion(-) |
53 |
+ |
54 |
+diff --git a/applets/kicker/package/contents/ui/MenuRepresentation.qml b/applets/kicker/package/contents/ui/MenuRepresentation.qml |
55 |
+index b70b76b..58cbf8d 100644 |
56 |
+--- a/applets/kicker/package/contents/ui/MenuRepresentation.qml |
57 |
++++ b/applets/kicker/package/contents/ui/MenuRepresentation.qml |
58 |
+@@ -393,7 +393,7 @@ FocusScope { |
59 |
+ } else if (event.key == Qt.Key_Down) { |
60 |
+ if (rootList.visible) { |
61 |
+ rootList.showChildDialogs = false; |
62 |
+- rootList.currentIndex = 0; |
63 |
++ rootList.currentIndex = Math.min(1, rootList.count); |
64 |
+ rootList.forceActiveFocus(); |
65 |
+ rootList.showChildDialogs = true; |
66 |
+ } |
67 |
+@@ -402,11 +402,29 @@ FocusScope { |
68 |
+ for (var i = 0; i < runnerModel.count; ++i) { |
69 |
+ if (runnerModel.modelForRow(i).count) { |
70 |
+ var targetList = runnerColumnsRepeater.itemAt(i); |
71 |
++ targetList.currentIndex = Math.min(1, targetList.count); |
72 |
++ targetList.forceActiveFocus(); |
73 |
++ break; |
74 |
++ } |
75 |
++ } |
76 |
++ } |
77 |
++ } else if (event.key == Qt.Key_Left && cursorPosition == 0) { |
78 |
++ for (var i = runnerModel.count; i >= 0; --i) { |
79 |
++ if (runnerModel.modelForRow(i).count) { |
80 |
++ var targetList = runnerColumnsRepeater.itemAt(i); |
81 |
+ targetList.currentIndex = 0; |
82 |
+ targetList.forceActiveFocus(); |
83 |
+ break; |
84 |
+ } |
85 |
+ } |
86 |
++ } else if (event.key == Qt.Key_Right && cursorPosition == length) { |
87 |
++ for (var i = 1; i < runnerModel.count; ++i) { |
88 |
++ if (runnerModel.modelForRow(i).count) { |
89 |
++ var targetList = runnerColumnsRepeater.itemAt(i); |
90 |
++ targetList.currentIndex = 0; |
91 |
++ targetList.forceActiveFocus(); |
92 |
++ break; |
93 |
++ } |
94 |
+ } |
95 |
+ } else if (event.key == Qt.Key_Enter || event.key == Qt.Key_Return) { |
96 |
+ if (runnerColumns.visible && runnerModel.modelForRow(0).count) { |
97 |
+diff --git a/applets/kicker/package/contents/ui/RunnerResultsList.qml b/applets/kicker/package/contents/ui/RunnerResultsList.qml |
98 |
+index 3627c2f..4e6dc2f 100644 |
99 |
+--- a/applets/kicker/package/contents/ui/RunnerResultsList.qml |
100 |
++++ b/applets/kicker/package/contents/ui/RunnerResultsList.qml |
101 |
+@@ -30,6 +30,7 @@ FocusScope { |
102 |
+ signal keyNavigationAtListEnd |
103 |
+ |
104 |
+ property alias currentIndex: runnerMatches.currentIndex |
105 |
++ property alias count: runnerMatches.count |
106 |
+ property alias containsMouse: runnerMatches.containsMouse |
107 |
+ |
108 |
+ Accessible.name: header.text |
109 |
+-- |
110 |
+cgit v0.11.2 |
111 |
|
112 |
diff --git a/kde-plasma/plasma-desktop/plasma-desktop-5.13.5-r1.ebuild b/kde-plasma/plasma-desktop/plasma-desktop-5.13.5-r1.ebuild |
113 |
new file mode 100644 |
114 |
index 00000000000..06140e915b1 |
115 |
--- /dev/null |
116 |
+++ b/kde-plasma/plasma-desktop/plasma-desktop-5.13.5-r1.ebuild |
117 |
@@ -0,0 +1,168 @@ |
118 |
+# Copyright 1999-2018 Gentoo Foundation |
119 |
+# Distributed under the terms of the GNU General Public License v2 |
120 |
+ |
121 |
+EAPI=6 |
122 |
+ |
123 |
+KDE_HANDBOOK="forceoptional" |
124 |
+KDE_TEST="true" |
125 |
+VIRTUALX_REQUIRED="test" |
126 |
+inherit kde5 |
127 |
+ |
128 |
+DESCRIPTION="KDE Plasma desktop" |
129 |
+KEYWORDS="~amd64 ~arm ~x86" |
130 |
+IUSE="appstream +fontconfig ibus +mouse pulseaudio scim +semantic-desktop touchpad" |
131 |
+ |
132 |
+COMMON_DEPEND=" |
133 |
+ $(add_frameworks_dep attica) |
134 |
+ $(add_frameworks_dep kactivities) |
135 |
+ $(add_frameworks_dep kactivities-stats) |
136 |
+ $(add_frameworks_dep karchive) |
137 |
+ $(add_frameworks_dep kauth) |
138 |
+ $(add_frameworks_dep kbookmarks) |
139 |
+ $(add_frameworks_dep kcmutils) |
140 |
+ $(add_frameworks_dep kcodecs) |
141 |
+ $(add_frameworks_dep kcompletion) |
142 |
+ $(add_frameworks_dep kconfig) |
143 |
+ $(add_frameworks_dep kconfigwidgets) |
144 |
+ $(add_frameworks_dep kcoreaddons) |
145 |
+ $(add_frameworks_dep kdbusaddons) |
146 |
+ $(add_frameworks_dep kdeclarative) |
147 |
+ $(add_frameworks_dep kded) |
148 |
+ $(add_frameworks_dep kdelibs4support) |
149 |
+ $(add_frameworks_dep kemoticons) |
150 |
+ $(add_frameworks_dep kglobalaccel) |
151 |
+ $(add_frameworks_dep kguiaddons) |
152 |
+ $(add_frameworks_dep ki18n) |
153 |
+ $(add_frameworks_dep kiconthemes) |
154 |
+ $(add_frameworks_dep kio) |
155 |
+ $(add_frameworks_dep kitemmodels) |
156 |
+ $(add_frameworks_dep kitemviews) |
157 |
+ $(add_frameworks_dep kjobwidgets) |
158 |
+ $(add_frameworks_dep knewstuff) |
159 |
+ $(add_frameworks_dep knotifications) |
160 |
+ $(add_frameworks_dep knotifyconfig) |
161 |
+ $(add_frameworks_dep kparts) |
162 |
+ $(add_frameworks_dep kpeople) |
163 |
+ $(add_frameworks_dep krunner) |
164 |
+ $(add_frameworks_dep kservice) |
165 |
+ $(add_frameworks_dep kwallet) |
166 |
+ $(add_frameworks_dep kwidgetsaddons) |
167 |
+ $(add_frameworks_dep kwindowsystem) |
168 |
+ $(add_frameworks_dep kxmlgui) |
169 |
+ $(add_frameworks_dep plasma) |
170 |
+ $(add_frameworks_dep solid) |
171 |
+ $(add_frameworks_dep sonnet) |
172 |
+ $(add_plasma_dep kwin) |
173 |
+ $(add_plasma_dep plasma-workspace) |
174 |
+ $(add_qt_dep qtconcurrent) |
175 |
+ $(add_qt_dep qtdbus) |
176 |
+ $(add_qt_dep qtdeclarative) |
177 |
+ $(add_qt_dep qtgui) |
178 |
+ $(add_qt_dep qtnetwork) |
179 |
+ $(add_qt_dep qtprintsupport) |
180 |
+ $(add_qt_dep qtsql) |
181 |
+ $(add_qt_dep qtsvg) |
182 |
+ $(add_qt_dep qtwidgets) |
183 |
+ $(add_qt_dep qtx11extras) |
184 |
+ $(add_qt_dep qtxml) |
185 |
+ media-libs/phonon[qt5(+)] |
186 |
+ x11-libs/libX11 |
187 |
+ x11-libs/libXcursor |
188 |
+ x11-libs/libXfixes |
189 |
+ x11-libs/libXi |
190 |
+ x11-libs/libxcb |
191 |
+ x11-libs/libxkbfile |
192 |
+ appstream? ( dev-libs/appstream[qt5] ) |
193 |
+ fontconfig? ( |
194 |
+ media-libs/fontconfig |
195 |
+ media-libs/freetype |
196 |
+ x11-libs/libXft |
197 |
+ x11-libs/xcb-util-image |
198 |
+ ) |
199 |
+ ibus? ( |
200 |
+ $(add_qt_dep qtx11extras) |
201 |
+ app-i18n/ibus |
202 |
+ dev-libs/glib:2 |
203 |
+ x11-libs/libxcb |
204 |
+ x11-libs/xcb-util-keysyms |
205 |
+ ) |
206 |
+ pulseaudio? ( |
207 |
+ dev-libs/glib:2 |
208 |
+ media-libs/libcanberra |
209 |
+ media-sound/pulseaudio |
210 |
+ ) |
211 |
+ scim? ( app-i18n/scim ) |
212 |
+ semantic-desktop? ( $(add_frameworks_dep baloo) ) |
213 |
+ touchpad? ( x11-drivers/xf86-input-synaptics ) |
214 |
+" |
215 |
+DEPEND="${COMMON_DEPEND} |
216 |
+ dev-libs/boost |
217 |
+ x11-base/xorg-proto |
218 |
+ fontconfig? ( x11-libs/libXrender ) |
219 |
+ mouse? ( |
220 |
+ x11-drivers/xf86-input-evdev |
221 |
+ x11-drivers/xf86-input-libinput |
222 |
+ ) |
223 |
+" |
224 |
+RDEPEND="${COMMON_DEPEND} |
225 |
+ $(add_frameworks_dep qqc2-desktop-style) |
226 |
+ $(add_plasma_dep breeze) |
227 |
+ $(add_plasma_dep kde-cli-tools) |
228 |
+ $(add_plasma_dep oxygen) |
229 |
+ $(add_qt_dep qtgraphicaleffects) |
230 |
+ sys-apps/accountsservice |
231 |
+ sys-apps/util-linux |
232 |
+ x11-apps/setxkbmap |
233 |
+ pulseaudio? ( $(add_plasma_dep plasma-pa ) ) |
234 |
+ !kde-apps/kcontrol |
235 |
+ !<kde-apps/kde4-l10n-17.08.1-r1 |
236 |
+ !kde-apps/knetattach[handbook] |
237 |
+ !kde-misc/kcm-touchpad |
238 |
+ !kde-plasma/plasma-desktop:4 |
239 |
+ !kde-plasma/plasma-workspace:4 |
240 |
+ !kde-plasma/solid-actions-kcm:4 |
241 |
+ !kde-plasma/systemsettings:4 |
242 |
+" |
243 |
+ |
244 |
+PATCHES=( |
245 |
+ "${FILESDIR}/${P}-activityswitcher.patch" |
246 |
+ "${FILESDIR}/${P}-kickersearch-nav.patch" |
247 |
+) |
248 |
+ |
249 |
+src_configure() { |
250 |
+ local mycmakeargs=( |
251 |
+ $(cmake-utils_use_find_package appstream AppStreamQt) |
252 |
+ $(cmake-utils_use_find_package fontconfig Fontconfig) |
253 |
+ $(cmake-utils_use_find_package ibus IBus) |
254 |
+ $(cmake-utils_use_find_package mouse Evdev) |
255 |
+ $(cmake-utils_use_find_package mouse XorgLibinput) |
256 |
+ $(cmake-utils_use_find_package pulseaudio PulseAudio) |
257 |
+ $(cmake-utils_use_find_package scim SCIM) |
258 |
+ $(cmake-utils_use_find_package semantic-desktop KF5Baloo) |
259 |
+ $(cmake-utils_use_find_package touchpad Synaptics) |
260 |
+ ) |
261 |
+ |
262 |
+ kde5_src_configure |
263 |
+} |
264 |
+ |
265 |
+src_test() { |
266 |
+ # parallel tests fail, foldermodeltest hangs, bug #646890 |
267 |
+ # needs D-Bus, bug #634166 |
268 |
+ local myctestargs=( |
269 |
+ -j1 |
270 |
+ -E "(foldermodeltest|test_kio_fonts)" |
271 |
+ ) |
272 |
+ |
273 |
+ kde5_src_test |
274 |
+} |
275 |
+ |
276 |
+pkg_postinst() { |
277 |
+ kde5_pkg_postinst |
278 |
+ |
279 |
+ if has_version "x11-libs/gtk+:2" && ! has_version "dev-libs/libappindicator:2"; then |
280 |
+ elog "For GTK+2 applications legacy-systray support, please install dev-libs/libappindicator:2." |
281 |
+ fi |
282 |
+ if has_version "x11-libs/gtk+:3" && ! has_version "dev-libs/libappindicator:3"; then |
283 |
+ elog "For GTK+3 applications legacy-systray support, please install dev-libs/libappindicator:3." |
284 |
+ fi |
285 |
+} |