Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: media-libs/libvpx/, media-libs/libvpx/files/
Date: Sun, 06 Nov 2022 04:22:06
Message-Id: 1667708419.1dfa289f303b8c390a24d11898a9e07fad7d69e2.sam@gentoo
1 commit: 1dfa289f303b8c390a24d11898a9e07fad7d69e2
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Sun Nov 6 04:20:19 2022 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Sun Nov 6 04:20:19 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1dfa289f
7
8 media-libs/libvpx: fix configure w/ clang 16
9
10 Closes: https://bugs.gentoo.org/879705
11 Signed-off-by: Sam James <sam <AT> gentoo.org>
12
13 .../files/libvpx-1.12.0-configure-clang16.patch | 37 ++++++++++++++++++++++
14 ...ibvpx-1.12.0.ebuild => libvpx-1.12.0-r1.ebuild} | 3 +-
15 2 files changed, 39 insertions(+), 1 deletion(-)
16
17 diff --git a/media-libs/libvpx/files/libvpx-1.12.0-configure-clang16.patch b/media-libs/libvpx/files/libvpx-1.12.0-configure-clang16.patch
18 new file mode 100644
19 index 000000000000..bb815b887885
20 --- /dev/null
21 +++ b/media-libs/libvpx/files/libvpx-1.12.0-configure-clang16.patch
22 @@ -0,0 +1,37 @@
23 +https://chromium-review.googlesource.com/c/webm/libvpx/+/4004627
24 +
25 +From 62dee8012ea70a9f0628471609c5768f98a1e726 Mon Sep 17 00:00:00 2001
26 +From: Sam James <sam@g.o>
27 +Date: Sun, 6 Nov 2022 04:11:59 +0000
28 +Subject: [PATCH] build: fix -Wimplicit-int (Clang 16)
29 +
30 +Clang 16 will make -Wimplicit-int error by default which can, in addition to
31 +other things, lead to some configure tests silently failing/returning the wrong result.
32 +
33 +Fixes this error:
34 +```
35 ++/var/tmp/portage/media-libs/libvpx-1.12.0/temp/vpx-conf-1802-30624.c:1:15: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
36 +```
37 +
38 +For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
39 +or the (new) c-std-porting mailing list [3].
40 +
41 +[0] https://lwn.net/Articles/913505/
42 +[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
43 +[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
44 +[3] hosted at lists.linux.dev.
45 +
46 +Bug: https://bugs.gentoo.org/879705
47 +Change-Id: Id73a98944ab3c99a368b9da7a5e902ddff9d937f
48 +Signed-off-by: Sam James <sam@g.o>
49 +--- a/build/make/configure.sh
50 ++++ b/build/make/configure.sh
51 +@@ -1511,7 +1511,7 @@ EOF
52 +
53 + # Try to find which inline keywords are supported
54 + check_cc <<EOF && INLINE="inline"
55 +-static inline function() {}
56 ++static inline int function(void) {}
57 + EOF
58 +
59 + # Almost every platform uses pthreads.
60
61 diff --git a/media-libs/libvpx/libvpx-1.12.0.ebuild b/media-libs/libvpx/libvpx-1.12.0-r1.ebuild
62 similarity index 97%
63 rename from media-libs/libvpx/libvpx-1.12.0.ebuild
64 rename to media-libs/libvpx/libvpx-1.12.0-r1.ebuild
65 index c6c94481f2c1..72ccda036cbe 100644
66 --- a/media-libs/libvpx/libvpx-1.12.0.ebuild
67 +++ b/media-libs/libvpx/libvpx-1.12.0-r1.ebuild
68 @@ -42,7 +42,8 @@ BDEPEND="dev-lang/perl
69
70 PATCHES=(
71 # bug #501010
72 - "${FILESDIR}/libvpx-1.3.0-sparc-configure.patch"
73 + "${FILESDIR}/${PN}-1.3.0-sparc-configure.patch"
74 + "${FILESDIR}/${P}-configure-clang16.patch"
75 )
76
77 src_configure() {