Gentoo Archives: gentoo-commits

From: "Sebastian Pipping (sping)" <sping@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in app-cdr/isomaster/files: isomaster-1.3.8-gtk_file_chooser_get_current.patch isomaster-1.3.8-unbundle-iniparser.patch
Date: Sat, 07 Jan 2012 18:42:58
Message-Id: 20120107184248.1A2042004C@flycatcher.gentoo.org
1 sping 12/01/07 18:42:48
2
3 Added: isomaster-1.3.8-gtk_file_chooser_get_current.patch
4 isomaster-1.3.8-unbundle-iniparser.patch
5 Log:
6 app-cdr/isomaster: 1.3.8
7
8 (Portage version: 2.1.10.44/cvs/Linux x86_64)
9
10 Revision Changes Path
11 1.1 app-cdr/isomaster/files/isomaster-1.3.8-gtk_file_chooser_get_current.patch
12
13 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-cdr/isomaster/files/isomaster-1.3.8-gtk_file_chooser_get_current.patch?rev=1.1&view=markup
14 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-cdr/isomaster/files/isomaster-1.3.8-gtk_file_chooser_get_current.patch?rev=1.1&content-type=text/plain
15
16 Index: isomaster-1.3.8-gtk_file_chooser_get_current.patch
17 ===================================================================
18 From eabb3f85d12121409f901d64c556a9f579c11864 Mon Sep 17 00:00:00 2001
19 From: Sebastian Pipping <sebastian@×××××××.org>
20 Date: Sat, 7 Jan 2012 19:30:52 +0100
21 Subject: [PATCH] Handle NULL return from
22 gtk_file_chooser_get_current_folder()
23
24 ---
25 isobrowser.c | 53 ++++++++++++++++++++++++++++++++++-------------------
26 1 files changed, 34 insertions(+), 19 deletions(-)
27
28 diff --git a/isobrowser.c b/isobrowser.c
29 index c03548b..e108f03 100644
30 --- a/isobrowser.c
31 +++ b/isobrowser.c
32 @@ -9,6 +9,7 @@
33 * Andrew Smith, http://littlesvr.ca/misc/contactandrew.php
34 *
35 * Contributors:
36 +* Sebastian Pipping <sebastian@×××××××.org>
37 *
38 ******************************************************************************/
39
40 @@ -1454,19 +1455,26 @@ gboolean openIsoCbk(GtkMenuItem* menuItem, gpointer data)
41
42 /* RECORD last iso dir */
43 char* lastIsoDir = gtk_file_chooser_get_current_folder(GTK_FILE_CHOOSER(dialog));
44 -
45 - if(GBLappSettings.lastIsoDir != NULL && strlen(lastIsoDir) > strlen(GBLappSettings.lastIsoDir))
46 + if(lastIsoDir)
47 + {
48 + if(GBLappSettings.lastIsoDir != NULL && strlen(lastIsoDir) > strlen(GBLappSettings.lastIsoDir))
49 + {
50 + free(GBLappSettings.lastIsoDir);
51 + GBLappSettings.lastIsoDir = NULL;
52 + }
53 +
54 + if(GBLappSettings.lastIsoDir == NULL)
55 + GBLappSettings.lastIsoDir = malloc(strlen(lastIsoDir) + 1);
56 +
57 + strcpy(GBLappSettings.lastIsoDir, lastIsoDir);
58 +
59 + g_free(lastIsoDir);
60 + }
61 + else /* e.g. when opening a file from the <Recently used> view */
62 {
63 free(GBLappSettings.lastIsoDir);
64 GBLappSettings.lastIsoDir = NULL;
65 }
66 -
67 - if(GBLappSettings.lastIsoDir == NULL)
68 - GBLappSettings.lastIsoDir = malloc(strlen(lastIsoDir) + 1);
69 -
70 - strcpy(GBLappSettings.lastIsoDir, lastIsoDir);
71 -
72 - g_free(lastIsoDir);
73 /* END RECORD last iso dir */
74 }
75
76 @@ -1758,20 +1766,27 @@ gboolean saveIsoCbk(GtkWidget *widget, GdkEvent *event)
77
78 /* RECORD last iso dir */
79 char* lastIsoDir = gtk_file_chooser_get_current_folder(GTK_FILE_CHOOSER(dialog));
80 -
81 - if(GBLappSettings.lastIsoDir != NULL && strlen(lastIsoDir) > strlen(GBLappSettings.lastIsoDir))
82 + if(lastIsoDir)
83 + {
84 + if(GBLappSettings.lastIsoDir != NULL && strlen(lastIsoDir) > strlen(GBLappSettings.lastIsoDir))
85 + {
86 + free(GBLappSettings.lastIsoDir);
87 + GBLappSettings.lastIsoDir = NULL;
88 + }
89 +
90 + if(GBLappSettings.lastIsoDir == NULL)
91 + GBLappSettings.lastIsoDir = malloc(strlen(lastIsoDir) + 1);
92 +
93 + strcpy(GBLappSettings.lastIsoDir, lastIsoDir);
94 +
95 + g_free(lastIsoDir);
96 + }
97 + else /* e.g. when opening a file from the <Recently used> view */
98 {
99 free(GBLappSettings.lastIsoDir);
100 GBLappSettings.lastIsoDir = NULL;
101 }
102 -
103 - if(GBLappSettings.lastIsoDir == NULL)
104 - GBLappSettings.lastIsoDir = malloc(strlen(lastIsoDir) + 1);
105 -
106 - strcpy(GBLappSettings.lastIsoDir, lastIsoDir);
107 -
108 - g_free(lastIsoDir);
109 - /* END RECORD iso save dir */
110 + /* END RECORD last iso dir */
111
112 askedToAddExtension = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(addExtensionCheckbox));
113 }
114 --
115 1.7.8.3
116
117
118
119
120 1.1 app-cdr/isomaster/files/isomaster-1.3.8-unbundle-iniparser.patch
121
122 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-cdr/isomaster/files/isomaster-1.3.8-unbundle-iniparser.patch?rev=1.1&view=markup
123 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-cdr/isomaster/files/isomaster-1.3.8-unbundle-iniparser.patch?rev=1.1&content-type=text/plain
124
125 Index: isomaster-1.3.8-unbundle-iniparser.patch
126 ===================================================================
127 From 598606c7b96e421ffbcb09ccd9aac61fa83cd0fe Mon Sep 17 00:00:00 2001
128 From: Sebastian Pipping <sebastian@×××××××.org>
129 Date: Sat, 7 Jan 2012 17:42:13 +0100
130 Subject: [PATCH] Unbundle iniparser, fix use of compile/link flags
131
132 ---
133 Makefile | 10 +++-------
134 1 files changed, 3 insertions(+), 7 deletions(-)
135
136 diff --git a/Makefile b/Makefile
137 index 363a36a..c0434fb 100644
138 --- a/Makefile
139 +++ b/Makefile
140 @@ -65,21 +65,18 @@ OBJECTS = isomaster.o window.o browser.o fsbrowser.o isobrowser.o error.o about.
141
142 all: translations isomaster.desktop isomaster
143
144 -isomaster: $(OBJECTS) lib iniparser
145 +isomaster: $(OBJECTS) lib
146 @echo 'Linking isomaster'
147 - @$(CC) $(OBJECTS) bk/bk.a iniparser-2.17/libiniparser.a $(LDFLAGS) $(CFLAGS) $(CPPFLAGS) `pkg-config --libs gtk+-2.0` -o isomaster
148 + @$(CC) $(LDFLAGS) $(OBJECTS) bk/bk.a `pkg-config --libs gtk+-2.0` -liniparser -o isomaster
149
150 # static pattern rule
151 $(OBJECTS): %.o: %.c %.h bk/bk.h Makefile
152 @echo 'Compiling' $<
153 - @$(CC) $< $(CFLAGS) $(CPPFLAGS) -c -o $@
154 + @$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@
155
156 lib:
157 cd bk && $(MAKE)
158
159 -iniparser:
160 - cd iniparser-2.17 && $(MAKE)
161 -
162 translations:
163 ifndef WITHOUT_NLS
164 cd po && $(MAKE)
165 @@ -94,7 +91,6 @@ bk-doc:
166
167 clean:
168 cd bk && $(MAKE) clean
169 - cd iniparser-2.17 && $(MAKE) clean
170 ifndef WITHOUT_NLS
171 cd po && $(MAKE) clean
172 endif
173 diff --git a/settings.h b/settings.h
174 index fda67b7..e619e0c 100644
175 --- a/settings.h
176 +++ b/settings.h
177 @@ -4,7 +4,7 @@
178 #include <stdbool.h>
179
180 #include "isomaster.h"
181 -#include "iniparser-2.17/src/iniparser.h"
182 +#include <iniparser.h>
183
184 #define ISOMASTER_DEFAULT_WINDOW_WIDTH 500
185 #define ISOMASTER_DEFAULT_WINDOW_HEIGHT 550
186 --
187 1.7.8.3