Gentoo Archives: gentoo-commits

From: Ionen Wolkens <ionen@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: games-emulation/pcsx2/
Date: Mon, 02 Jan 2023 11:08:19
Message-Id: 1672657523.0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2.ionen@gentoo
1 commit: 0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2
2 Author: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
3 AuthorDate: Mon Jan 2 10:28:21 2023 +0000
4 Commit: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
5 CommitDate: Mon Jan 2 11:05:23 2023 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ee6e8f7
7
8 games-emulation/pcsx2: add comment about upstream
9
10 May be useful to know for anyone working on this.
11
12 Upstream doesn't seem to want to hear of non-appimage issues.
13 They also dislike that we do workarounds for these issues and
14 wants it pristine (no patch/sed, even tiny changes like changing
15 the path to find resources in /usr/share given been seemingly
16 refusing to add a cmake option to change it) and using bundled libs.
17
18 Hopefully may change if it gets a dedicated linux contributor, as
19 there's currently none and it's at most just drive-by PRs which
20 don't get maintained and eventually break.
21
22 Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>
23
24 games-emulation/pcsx2/pcsx2-9999.ebuild | 7 +++++--
25 1 file changed, 5 insertions(+), 2 deletions(-)
26
27 diff --git a/games-emulation/pcsx2/pcsx2-9999.ebuild b/games-emulation/pcsx2/pcsx2-9999.ebuild
28 index b9d68d63b68b..e2f804a6b008 100644
29 --- a/games-emulation/pcsx2/pcsx2-9999.ebuild
30 +++ b/games-emulation/pcsx2/pcsx2-9999.ebuild
31 @@ -161,13 +161,17 @@ src_configure() {
32 -DDISABLE_BUILD_DATE=yes
33 -DDISABLE_SETCAP=yes
34 -DENABLE_TESTS=$(usex test)
35 - -DUSE_SYSTEM_LIBS=yes
36 -DUSE_VTUNE=no
37 -DUSE_VULKAN=$(usex vulkan)
38 -DWAYLAND_API=$(usex wayland)
39 -DX11_API=yes # fails if X libs are missing even if disabled
40 -DXDG_STD=yes
41
42 + # note that the current upstream is somewhat hostile to using system
43 + # libs, system installs, or any modifications and may disregard any
44 + # bugs that is not reproducible with the appimage using bundled libs
45 + -DUSE_SYSTEM_LIBS=yes
46 +
47 # sse4.1 is the bare minimum required, -m is required at build time
48 # (see PCSX2Base.h) and it dies if no support at runtime (AppInit.cpp)
49 # https://github.com/PCSX2/pcsx2/pull/4329
50 @@ -189,7 +193,6 @@ src_test() {
51 }
52
53 src_install() {
54 - # package mode was removed turning cmake_src_install into a noop
55 newbin "${BUILD_DIR}"/pcsx2-qt/pcsx2-qt ${PN}
56
57 insinto /usr/share/${PN}