Gentoo Archives: gentoo-commits

From: Fabian Groffen <grobian@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage-utils:master commit in: /
Date: Sun, 19 Jan 2020 16:37:28
Message-Id: 1579449634.1ebb60136546f233982386df561f4a83cb4d434c.grobian@gentoo
1 commit: 1ebb60136546f233982386df561f4a83cb4d434c
2 Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
3 AuthorDate: Sun Jan 19 16:00:34 2020 +0000
4 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
5 CommitDate: Sun Jan 19 16:00:34 2020 +0000
6 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=1ebb6013
7
8 qmanifest: fix Coverity 206565 Unchecked return value
9
10 Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>
11
12 qmanifest.c | 10 +++++++---
13 1 file changed, 7 insertions(+), 3 deletions(-)
14
15 diff --git a/qmanifest.c b/qmanifest.c
16 index 597357b..d9452a4 100644
17 --- a/qmanifest.c
18 +++ b/qmanifest.c
19 @@ -220,8 +220,8 @@ write_hashes(
20
21 if (m != NULL)
22 fwrite(data, len, 1, m);
23 - if (gm != NULL)
24 - gzwrite(gm, data, len);
25 + if (gm != NULL && gzwrite(gm, data, len) == 0)
26 + fprintf(stderr, "failed to write to compressed stream\n");
27 }
28
29 /**
30 @@ -430,7 +430,11 @@ generate_dir(const char *dir, enum type_manifest mtype)
31 "IGNORE lost+found\n"
32 "IGNORE packages\n"
33 "IGNORE snapshots\n");
34 - gzwrite(mf, path, len);
35 + if (gzwrite(mf, path, len) == 0) {
36 + fprintf(stderr, "failed to write to file '%s/%s': %s\n",
37 + dir, str_manifest_files_gz, strerror(errno));
38 + return NULL;
39 + }
40
41 if (list_dir(&dentries, &dentrieslen, dir) != 0)
42 return NULL;