| 1 |
commit: 40335ce6a4577e520a612d7061dadf5c9b2e8b01 |
| 2 |
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Wed Jan 22 19:37:53 2020 +0000 |
| 4 |
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Wed Jan 22 19:37:53 2020 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=40335ce6 |
| 7 |
|
| 8 |
qpkg: fix Coverity 125897 Unchecked return value |
| 9 |
|
| 10 |
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> |
| 11 |
|
| 12 |
qpkg.c | 3 +-- |
| 13 |
1 file changed, 1 insertion(+), 2 deletions(-) |
| 14 |
|
| 15 |
diff --git a/qpkg.c b/qpkg.c |
| 16 |
index 4519e9c..7835cd7 100644 |
| 17 |
--- a/qpkg.c |
| 18 |
+++ b/qpkg.c |
| 19 |
@@ -356,8 +356,7 @@ int qpkg_main(int argc, char **argv) |
| 20 |
err("'%s' is not a valid package destination", qpkg_bindir); |
| 21 |
for (i = 0; i <= 1; i++) { |
| 22 |
if (mkdir(qpkg_bindir, 0750) == -1) { |
| 23 |
- lstat(qpkg_bindir, &st); |
| 24 |
- if (!S_ISDIR(st.st_mode)) { |
| 25 |
+ if (lstat(qpkg_bindir, &st) == 0 && !S_ISDIR(st.st_mode)) { |
| 26 |
unlink(qpkg_bindir); |
| 27 |
continue; |
| 28 |
} |
Archives