Gentoo Archives: gentoo-commits

From: Brian Dolbec <dolsen@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/gentoo-keys:gsoc-2016 commit in: gkeys/gkeys/
Date: Sat, 24 Dec 2016 09:13:59
Message-Id: 1482555255.70cb948e5d68bfe0cb0c05b5e5518b2815e68d3f.dolsen@gentoo
1 commit: 70cb948e5d68bfe0cb0c05b5e5518b2815e68d3f
2 Author: aeroniero33 <justthisthing <AT> gmail <DOT> com>
3 AuthorDate: Sun Jun 12 14:19:35 2016 +0000
4 Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org>
5 CommitDate: Sat Dec 24 04:54:15 2016 +0000
6 URL: https://gitweb.gentoo.org/proj/gentoo-keys.git/commit/?id=70cb948e
7
8 gkeys/actions: Update the update-seed function
9
10 Update descriptions.
11 Update operations to current library code usage.
12 <rebase edit>
13 Replace print() use with self.output(). Expand commit message
14 </edit Brian Dolbec>
15
16 gkeys/gkeys/action_map.py | 7 ++++---
17 gkeys/gkeys/actions.py | 41 +++++++++++++++++++++++++++++++----------
18 2 files changed, 35 insertions(+), 13 deletions(-)
19
20 diff --git a/gkeys/gkeys/action_map.py b/gkeys/gkeys/action_map.py
21 index 1bd0625..5433297 100644
22 --- a/gkeys/gkeys/action_map.py
23 +++ b/gkeys/gkeys/action_map.py
24 @@ -385,8 +385,8 @@ Found Failures:
25 'func': 'updateseed',
26 'options': ['category', 'nick', '1file', 'dest', 'signature',
27 'timestamp'],
28 - 'desc': '''Update the selected seed file(s)''',
29 - 'long_desc': '''Update the selected seed file(s)''',
30 + 'desc': '''Update the selected seed file(s) or all categories if no arguments are given''',
31 + 'long_desc': '''Update the selected seed file(s) or all categories if no arguments are given''',
32 'example': '''$ gkeys update-seed -C gentoo-devs
33
34 Gkey task results:
35 @@ -394,7 +394,8 @@ Found Failures:
36 Key info...............: Gentoo-Linux Gentoo-keys Project Signing Key <gkeys>, 0xA41DBBD9151C3FC7
37 category, nick.....: gentoo gkeys
38
39 - Update operation completed
40 + Fetch operation completed
41 + Completed
42 ''',
43 }),
44 ('list-seed', {
45
46 diff --git a/gkeys/gkeys/actions.py b/gkeys/gkeys/actions.py
47 index c218d8d..3d0399a 100644
48 --- a/gkeys/gkeys/actions.py
49 +++ b/gkeys/gkeys/actions.py
50 @@ -1,4 +1,4 @@
51 -#
52 +
53 #-*- coding:utf-8 -*-
54
55 """
56 @@ -96,19 +96,41 @@ class Actions(ActionBase):
57 messages.append("")
58 messages.append("Fetch operation completed")
59 return (False not in success, messages)
60 -
61 +
62 def updateseed(self, args):
63 - '''Updates seeds of a selected file'''
64 + '''Updates seeds of a selected file or all categories if no args are given'''
65 self.logger.debug(_unicode("ACTIONS: updateseed; args: %s")
66 % _unicode(args))
67 + messages = []
68 + success = True
69 + if not args.category:
70 + '''Update all available categories'''
71 + seed_categories = list(self.config.defaults['seeds'])
72 + category_msgs = []
73 + for seed_category in seed_categories:
74 + self.seeds = None
75 + custom_args = args
76 + custom_args.category = seed_category
77 + category_success, messages = self.updateseed(custom_args)
78 + category_msgs.extend(messages)
79 + return (True, category_msgs)
80 + self.output('', "Fetching seeds for %s category.\n" %args.category)
81 fetch_success, fetch_messages = self.fetchseed(args)
82 if fetch_success is not True:
83 - return (False, fetch_messages)
84 - install_success, install_messages = self.installkey(args)
85 - if install_success is not True:
86 - return (False, install_messages)
87 - messages = fetch_messages + [install_messages]
88 - return (True, messages)
89 + success = False
90 + messages = fetch_messages
91 + self.output('', "Fetch failed.\n")
92 + else:
93 + self.output('', "Fetch succeeded.\n")
94 + self.output('', "Installing or Refreshing keys for %s category." %args.category)
95 + install_success, install_messages = self.installkey(args)
96 + if install_success is not True:
97 + self.output('', "Update failed.\n")
98 + success = False
99 + else:
100 + self.output('', "Update succeeded.\n")
101 + messages = fetch_messages + ["Update operation:"] + [install_messages]
102 + return (success, messages)
103
104 def addseed(self, args):
105 '''Add or replace a key in the selected seed file'''
106 @@ -313,7 +335,6 @@ class Actions(ActionBase):
107 self.gpg.set_keydir(gkey.keydir, "recv-keys")
108 self.gpg.set_keyseedfile()
109 seeds = self.gpg.seedfile.seeds
110 - #print(seeds)
111 if seeds:
112 self.logger.debug("ACTIONS: installkey; found installed seeds:"
113 "\n %s" % seeds)