Archives
Archives
| From: | "Diego Petteno (flameeyes)" <flameeyes@g.o> |
|---|---|
| To: | gentoo-commits@l.g.o |
| Subject: | [gentoo-commits] gentoo-x86 commit in media-libs/xine-lib/files: xine-lib-1.1.10.1-off-by-one.patch |
| Date: | Mon, 25 Feb 2008 23:08:47 |
| Message-Id: | E1JTmRA-0003md-8W@stork.gentoo.org |
| 1 | flameeyes 08/02/25 23:08:44 |
| 2 | |
| 3 | Added: xine-lib-1.1.10.1-off-by-one.patch |
| 4 | Log: |
| 5 | Fix FLAC playback after security fix. |
| 6 | (Portage version: 2.1.4.4) |
| 7 | |
| 8 | Revision Changes Path |
| 9 | 1.1 media-libs/xine-lib/files/xine-lib-1.1.10.1-off-by-one.patch |
| 10 | |
| 11 | file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/xine-lib/files/xine-lib-1.1.10.1-off-by-one.patch?rev=1.1&view=markup |
| 12 | plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/xine-lib/files/xine-lib-1.1.10.1-off-by-one.patch?rev=1.1&content-type=text/plain |
| 13 | |
| 14 | Index: xine-lib-1.1.10.1-off-by-one.patch |
| 15 | =================================================================== |
| 16 | |
| 17 | # HG changeset patch |
| 18 | # User Darren Salt <linux@××××××××××××××××××××××××.uk> |
| 19 | # Date 1203549555 0 |
| 20 | # Node ID 0a9d58e399a14cfadc622f562020ba5123254592 |
| 21 | # Parent 6f70d1625834502a735349a6597ad7a85fb68aa5 |
| 22 | Off-by-one in the FLAC security fix, breaking playback of some files. |
| 23 | |
| 24 | --- a/src/demuxers/demux_flac.c Wed Feb 20 21:45:48 2008 +0000 |
| 25 | +++ b/src/demuxers/demux_flac.c Wed Feb 20 23:19:15 2008 +0000 |
| 26 | @@ -202,7 +202,7 @@ static int open_flac_file(demux_flac_t * |
| 27 | |
| 28 | length = _X_LE_32(ptr); |
| 29 | ptr += 4 + length; |
| 30 | - if (length >= block_length - 8) |
| 31 | + if (length > block_length - 8) |
| 32 | return 0; /* bad length or too little left in the buffer */ |
| 33 | |
| 34 | user_comment_list_length = _X_LE_32(ptr); |
| 35 | |
| 36 | |
| 37 | |
| 38 | |
| 39 | -- |
| 40 | gentoo-commits@l.g.o mailing list |