Gentoo Archives: gentoo-commits

From: Fabian Groffen <grobian@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage-utils:master commit in: /
Date: Wed, 22 Jan 2020 19:54:06
Message-Id: 1579720692.107a164f604fd8ead594b3eaeea1840a3c84a157.grobian@gentoo
1 commit: 107a164f604fd8ead594b3eaeea1840a3c84a157
2 Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
3 AuthorDate: Wed Jan 22 19:18:12 2020 +0000
4 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
5 CommitDate: Wed Jan 22 19:18:12 2020 +0000
6 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=107a164f
7
8 qmerge: fix Coverity 125890 Unchecked return value
9
10 Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>
11
12 qmerge.c | 5 ++++-
13 1 file changed, 4 insertions(+), 1 deletion(-)
14
15 diff --git a/qmerge.c b/qmerge.c
16 index 6988285..f2ef84d 100644
17 --- a/qmerge.c
18 +++ b/qmerge.c
19 @@ -1671,7 +1671,10 @@ pkg_fetch(int level, const depend_atom *atom, const struct pkg_t *pkg)
20 unlink_empty(buf);
21
22 snprintf(str, sizeof(str), "%s/%s", pkgdir, pkg->CATEGORY);
23 - mkdir(str, 0755);
24 + if (mkdir(str, 0755) == -1) {
25 + warn("Failed to create %s", str);
26 + return;
27 + }
28
29 /* XXX: should do a size check here for partial downloads */