Gentoo Archives: gentoo-commits

From: "Andreas K. Hüttel" <dilfridge@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: app-text/xournalpp/, app-text/xournalpp/files/
Date: Sat, 26 Feb 2022 18:26:11
Message-Id: 1645899955.e836b0a51dbed966f373adea13fc3c3abb320c48.dilfridge@gentoo
1 commit: e836b0a51dbed966f373adea13fc3c3abb320c48
2 Author: Andreas K. Hüttel <dilfridge <AT> gentoo <DOT> org>
3 AuthorDate: Sat Feb 26 18:25:40 2022 +0000
4 Commit: Andreas K. Hüttel <dilfridge <AT> gentoo <DOT> org>
5 CommitDate: Sat Feb 26 18:25:55 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e836b0a5
7
8 app-text/xournalpp: QA fixes
9
10 Closes: https://bugs.gentoo.org/834064
11 Closes: https://bugs.gentoo.org/834065
12 Package-Manager: Portage-3.0.30, Repoman-3.0.3
13 Signed-off-by: Andreas K. Hüttel <dilfridge <AT> gentoo.org>
14
15 .../files/xournalpp-1.1.1-nocompress.patch | 53 ++++++++++++++++++++++
16 .../xournalpp/files/xournalpp-1.1.1-nostrip.patch | 31 +++++++++++++
17 ...nalpp-9999.ebuild => xournalpp-1.1.1-r1.ebuild} | 5 ++
18 app-text/xournalpp/xournalpp-9999.ebuild | 5 ++
19 4 files changed, 94 insertions(+)
20
21 diff --git a/app-text/xournalpp/files/xournalpp-1.1.1-nocompress.patch b/app-text/xournalpp/files/xournalpp-1.1.1-nocompress.patch
22 new file mode 100644
23 index 000000000000..dc3ecca1bad0
24 --- /dev/null
25 +++ b/app-text/xournalpp/files/xournalpp-1.1.1-nocompress.patch
26 @@ -0,0 +1,53 @@
27 +From 91319980ebddf80f797118fd67bf95b509b31725 Mon Sep 17 00:00:00 2001
28 +From: =?UTF-8?q?Andreas=20K=2E=20H=C3=BCttel?= <dilfridge@g.o>
29 +Date: Sat, 26 Feb 2022 19:05:39 +0100
30 +Subject: [PATCH 2/2] Do not compress manpages, this is done by the package
31 + manager
32 +MIME-Version: 1.0
33 +Content-Type: text/plain; charset=UTF-8
34 +Content-Transfer-Encoding: 8bit
35 +
36 +Signed-off-by: Andreas K. Hüttel <dilfridge@g.o>
37 +---
38 + man/CMakeLists.txt | 12 ++++--------
39 + 1 file changed, 4 insertions(+), 8 deletions(-)
40 +
41 +diff --git a/man/CMakeLists.txt b/man/CMakeLists.txt
42 +index 499d9297..974aea4b 100644
43 +--- a/man/CMakeLists.txt
44 ++++ b/man/CMakeLists.txt
45 +@@ -9,27 +9,23 @@ mark_as_advanced(HELP2MAN)
46 + if (HELP2MAN)
47 + set(MAN_INCLUDE "${PROJECT_SOURCE_DIR}/man/extra.groff")
48 + set(MAN_PAGE "${CMAKE_CURRENT_BINARY_DIR}/xournalpp.1")
49 +- set(MAN_FILE "${CMAKE_CURRENT_BINARY_DIR}/xournalpp.1.gz")
50 +
51 + add_custom_command(
52 +- OUTPUT ${MAN_FILE}
53 ++ OUTPUT ${MAN_PAGE}
54 + COMMAND ${HELP2MAN} --no-info -i ${MAN_INCLUDE} -o ${MAN_PAGE} --version-string=${PROJECT_VERSION} --name="open-source hand note-taking program" ${CMAKE_BINARY_DIR}/src/xournalpp
55 +- COMMAND gzip -n -f -9 ${MAN_PAGE}
56 + DEPENDS ${CMAKE_BINARY_DIR}/src/xournalpp
57 + )
58 +
59 + set(MAN_PAGE_THUMBNAILER "${CMAKE_CURRENT_BINARY_DIR}/xournalpp-thumbnailer.1")
60 +- set(MAN_FILE_THUMBNAILER "${CMAKE_CURRENT_BINARY_DIR}/xournalpp-thumbnailer.1.gz")
61 +
62 + add_custom_command(
63 +- OUTPUT ${MAN_FILE_THUMBNAILER}
64 ++ OUTPUT ${MAN_PAGE_THUMBNAILER}
65 + COMMAND ${HELP2MAN} --no-info --no-discard-stderr -o ${MAN_PAGE_THUMBNAILER} --version-string=${PROJECT_VERSION} --name="creates thumbnails" ${CMAKE_BINARY_DIR}/src/xoj-preview-extractor/xournalpp-thumbnailer
66 +- COMMAND gzip -n -f -9 ${MAN_PAGE_THUMBNAILER}
67 + DEPENDS ${CMAKE_BINARY_DIR}/src/xoj-preview-extractor/xournalpp-thumbnailer
68 + )
69 +
70 +- add_custom_target(manpage ALL DEPENDS ${MAN_FILE} ${MAN_FILE_THUMBNAILER})
71 +- install(FILES ${MAN_FILE} ${MAN_FILE_THUMBNAILER} DESTINATION "share/man/man1")
72 ++ add_custom_target(manpage ALL DEPENDS ${MAN_PAGE} ${MAN_PAGE_THUMBNAILER})
73 ++ install(FILES ${MAN_PAGE} ${MAN_PAGE_THUMBNAILER} DESTINATION "share/man/man1")
74 + else(HELP2MAN)
75 + message("help2man is missing; no man pages will be generated")
76 + endif(HELP2MAN)
77 +--
78 +2.34.1
79 +
80
81 diff --git a/app-text/xournalpp/files/xournalpp-1.1.1-nostrip.patch b/app-text/xournalpp/files/xournalpp-1.1.1-nostrip.patch
82 new file mode 100644
83 index 000000000000..0698bc443fda
84 --- /dev/null
85 +++ b/app-text/xournalpp/files/xournalpp-1.1.1-nostrip.patch
86 @@ -0,0 +1,31 @@
87 +From 9686113b760cf5838a63ba6bee438ec3b7ab99e8 Mon Sep 17 00:00:00 2001
88 +From: =?UTF-8?q?Andreas=20K=2E=20H=C3=BCttel?= <dilfridge@g.o>
89 +Date: Sat, 26 Feb 2022 19:01:17 +0100
90 +Subject: [PATCH 1/2] Do not explicitly strip the thumbnailer (why?)
91 +MIME-Version: 1.0
92 +Content-Type: text/plain; charset=UTF-8
93 +Content-Transfer-Encoding: 8bit
94 +
95 +Signed-off-by: Andreas K. Hüttel <dilfridge@g.o>
96 +---
97 + src/xoj-preview-extractor/CMakeLists.txt | 4 ----
98 + 1 file changed, 4 deletions(-)
99 +
100 +diff --git a/src/xoj-preview-extractor/CMakeLists.txt b/src/xoj-preview-extractor/CMakeLists.txt
101 +index 50d1b410..b653d983 100644
102 +--- a/src/xoj-preview-extractor/CMakeLists.txt
103 ++++ b/src/xoj-preview-extractor/CMakeLists.txt
104 +@@ -41,10 +41,6 @@ target_include_directories (xournalpp-thumbnailer PRIVATE ${librsvg_INCLUDE_DIRS
105 +
106 + set (THUMBNAILER_BIN "xournalpp-thumbnailer")
107 +
108 +-add_custom_command (TARGET xournalpp-thumbnailer POST_BUILD
109 +- COMMAND ${CMAKE_STRIP} ${THUMBNAILER_BIN}
110 +-)
111 +-
112 + ## Install ##
113 +
114 + install (TARGETS xournalpp-thumbnailer
115 +--
116 +2.34.1
117 +
118
119 diff --git a/app-text/xournalpp/xournalpp-9999.ebuild b/app-text/xournalpp/xournalpp-1.1.1-r1.ebuild
120 similarity index 90%
121 copy from app-text/xournalpp/xournalpp-9999.ebuild
122 copy to app-text/xournalpp/xournalpp-1.1.1-r1.ebuild
123 index 2c5a3a5f0527..8ce79e89fbf1 100644
124 --- a/app-text/xournalpp/xournalpp-9999.ebuild
125 +++ b/app-text/xournalpp/xournalpp-1.1.1-r1.ebuild
126 @@ -41,6 +41,11 @@ BDEPEND="
127 sys-apps/lsb-release
128 "
129
130 +PATCHES=(
131 + "${FILESDIR}/${PN}-1.1.1-nostrip.patch"
132 + "${FILESDIR}/${PN}-1.1.1-nocompress.patch"
133 +)
134 +
135 src_prepare() {
136 cmake_src_prepare
137 }
138
139 diff --git a/app-text/xournalpp/xournalpp-9999.ebuild b/app-text/xournalpp/xournalpp-9999.ebuild
140 index 2c5a3a5f0527..8ce79e89fbf1 100644
141 --- a/app-text/xournalpp/xournalpp-9999.ebuild
142 +++ b/app-text/xournalpp/xournalpp-9999.ebuild
143 @@ -41,6 +41,11 @@ BDEPEND="
144 sys-apps/lsb-release
145 "
146
147 +PATCHES=(
148 + "${FILESDIR}/${PN}-1.1.1-nostrip.patch"
149 + "${FILESDIR}/${PN}-1.1.1-nocompress.patch"
150 +)
151 +
152 src_prepare() {
153 cmake_src_prepare
154 }