Gentoo Archives: gentoo-commits

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/common-mistakes/
Date: Fri, 28 Oct 2016 17:13:57
Message-Id: 1477674810.3607b7a4e355a2421321f2dfccc24f40f1d0d48e.ulm@gentoo
1 commit: 3607b7a4e355a2421321f2dfccc24f40f1d0d48e
2 Author: Ulrich Müller <ulm <AT> gentoo <DOT> org>
3 AuthorDate: Fri Oct 28 17:13:30 2016 +0000
4 Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org>
5 CommitDate: Fri Oct 28 17:13:30 2016 +0000
6 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=3607b7a4
7
8 Whitespace fixes.
9
10 ebuild-writing/common-mistakes/text.xml | 16 ++++++++--------
11 1 file changed, 8 insertions(+), 8 deletions(-)
12
13 diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml
14 index 8293bc8..1a2ef85 100644
15 --- a/ebuild-writing/common-mistakes/text.xml
16 +++ b/ebuild-writing/common-mistakes/text.xml
17 @@ -237,7 +237,7 @@ part.
18 </li>
19 <li>
20 <e>One dependency per line.</e><br />
21 - Don't put multiple dependency on the same line. It makes it ugly to read
22 + Don't put multiple dependency on the same line. It makes it ugly to read
23 and hard to follow.
24 </li>
25 </ul>
26 @@ -293,17 +293,17 @@ some tips on how to find the correct dependencies.
27
28 <p>
29 Another common mistake users make when submitting ebuilds is supplying an
30 -invalid license. For example, <c>GPL</c> is not a valid license. You need to
31 -specify <c>GPL-1</c> or <c>GPL-2</c>. Same with <c>LGPL</c>. Make sure the
32 -license you use in the <c>LICENSE</c> field is something that exists in
33 -<path>/usr/portage/licenses</path>. As a tip, check the <path>COPYING</path>
34 +invalid license. For example, <c>GPL</c> is not a valid license. You need to
35 +specify <c>GPL-1</c> or <c>GPL-2</c>. Same with <c>LGPL</c>. Make sure the
36 +license you use in the <c>LICENSE</c> field is something that exists in
37 +<path>/usr/portage/licenses</path>. As a tip, check the <path>COPYING</path>
38 in a source tarball for the license. If a package does not specify it
39 uses <c>GPL-1</c> or <c>GPL-2</c>, it is very likely it uses <c>GPL-2</c>.
40 </p>
41
42 <p>
43 If the license for the package you submit is unique and not in
44 -<path>/usr/portage/licenses/</path>, then you must submit the new license in a
45 +<path>/usr/portage/licenses/</path>, then you must submit the new license in a
46 separate file.
47 </p>
48
49 @@ -377,8 +377,8 @@ tell you if there is trailing whitespace at the end of lines or on empty lines.
50 <body>
51
52 <p>
53 -If <c>S=${WORKDIR}/${P}</c>, then you should not add it to your ebuild. This is
54 -implied already, you should only add it if it is something other than
55 +If <c>S=${WORKDIR}/${P}</c>, then you should not add it to your ebuild. This is
56 +implied already, you should only add it if it is something other than
57 <c>${WORKDIR}/${P}</c>.
58 </p>