[gentoo-commits] gentoo-x86 commit in gnome-base/gnome-shell/files: gnome-shell-3.8.4-close-rundialog.patch

[Pacho Ramos (pacho)]

pacho       13/12/27 21:11:36

  Added:                gnome-shell-3.8.4-close-rundialog.patch
  Log:
  Fix security bug #496168
  
  (Portage version: 2.2.7/cvs/Linux x86_64, signed Manifest commit with key A188FBD4)

Revision  Changes    Path
1.1                  gnome-base/gnome-shell/files/gnome-shell-3.8.4-close-rundialog.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/gnome-base/gnome-shell/files/gnome-shell-3.8.4-close-rundialog.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/gnome-base/gnome-shell/files/gnome-shell-3.8.4-close-rundialog.patch?rev=1.1&content-type=text/plain

Index: gnome-shell-3.8.4-close-rundialog.patch
===================================================================
From efdf1ff755943fba1f8a9aaeff77daa3ed338088 Mon Sep 17 00:00:00 2001
From: Florian Müllner <fmuellner@×××××.org>
Date: Wed, 18 Sep 2013 17:47:59 +0000
Subject: main: Close runDialog as necessary on session mode changes

We already do this for looking glass, but it makes even less sense
for the normal run dialog - if a mode sets runDialog to false, the
intention is to not allow executing aribitrary commands.

https://bugzilla.gnome.org/show_bug.cgi?id=708218
---
diff --git a/js/ui/main.js b/js/ui/main.js
index bca2b22..6f961be 100644
--- a/js/ui/main.js
+++ b/js/ui/main.js
@@ -90,8 +90,12 @@ function _sessionUpdated() {
                                   Shell.KeyBindingMode.OVERVIEW,
                                   sessionMode.hasRunDialog ? openRunDialog : null);
 
-    if (!sessionMode.hasRunDialog && lookingGlass)
-        lookingGlass.close();
+    if (!sessionMode.hasRunDialog) {
+        if (runDialog)
+            runDialog.close();
+        if (lookingGlass)
+            lookingGlass.close();
+    }
 }
 
 function start() {
--
cgit v0.9.2