1 |
commit: f1b70227b021d0f56aeb6b477dffafe00baaa588 |
2 |
Author: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail <DOT> com> |
3 |
AuthorDate: Fri Feb 8 16:00:49 2019 +0000 |
4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
5 |
CommitDate: Sat Feb 9 09:52:00 2019 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1b70227 |
7 |
|
8 |
kde-frameworks/kio: remove unused patch(es) |
9 |
|
10 |
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail.com> |
11 |
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org> |
12 |
|
13 |
kde-frameworks/kio/files/kio-5.52.0-sendfile.patch | 109 --------------------- |
14 |
1 file changed, 109 deletions(-) |
15 |
|
16 |
diff --git a/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch b/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch |
17 |
deleted file mode 100644 |
18 |
index d02b8f50b19..00000000000 |
19 |
--- a/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch |
20 |
+++ /dev/null |
21 |
@@ -1,109 +0,0 @@ |
22 |
-From 31980ecd1cacac9bd75ce35e3048946e1c27e1a0 Mon Sep 17 00:00:00 2001 |
23 |
-From: David Edmundson <kde@×××××××××××××××××.uk> |
24 |
-Date: Wed, 21 Nov 2018 15:30:48 +0000 |
25 |
-Subject: Restore sendfile support |
26 |
- |
27 |
-Summary: |
28 |
-Somehow in the kdelibs -> framework port the cmake checks for |
29 |
-HAVE_SENDFILE got lost. |
30 |
- |
31 |
-That re-enables a massive optimisation in the file kioslave that has all the code existing and used in kdelibs4 that we're currently missing. |
32 |
- |
33 |
-Test Plan: |
34 |
-Put a compilation fail inside the #ifdef, before it wasn't triggered, now it is. |
35 |
- |
36 |
-Ran unit tests |
37 |
-Moved a file in dolphin |
38 |
- |
39 |
-Reviewers: dfaure |
40 |
- |
41 |
-Reviewed By: dfaure |
42 |
- |
43 |
-Subscribers: ngraham, apol, kde-frameworks-devel |
44 |
- |
45 |
-Tags: #frameworks |
46 |
- |
47 |
-Differential Revision: https://phabricator.kde.org/D17048 |
48 |
---- |
49 |
- src/ioslaves/file/ConfigureChecks.cmake | 1 + |
50 |
- src/ioslaves/file/config-kioslave-file.h.cmake | 2 ++ |
51 |
- src/ioslaves/file/file_unix.cpp | 2 +- |
52 |
- 3 files changed, 4 insertions(+), 1 deletion(-) |
53 |
- |
54 |
-diff --git a/src/ioslaves/file/ConfigureChecks.cmake b/src/ioslaves/file/ConfigureChecks.cmake |
55 |
-index 5a83d1b..39fcd6f 100644 |
56 |
---- a/src/ioslaves/file/ConfigureChecks.cmake |
57 |
-+++ b/src/ioslaves/file/ConfigureChecks.cmake |
58 |
-@@ -7,6 +7,7 @@ include(CheckStructHasMember) |
59 |
- check_include_files(sys/time.h HAVE_SYS_TIME_H) |
60 |
- check_include_files(string.h HAVE_STRING_H) |
61 |
- check_include_files(limits.h HAVE_LIMITS_H) |
62 |
-+check_function_exists(sendfile HAVE_SENDFILE) |
63 |
- |
64 |
- check_function_exists(posix_fadvise HAVE_FADVISE) # kioslave |
65 |
- |
66 |
-diff --git a/src/ioslaves/file/config-kioslave-file.h.cmake b/src/ioslaves/file/config-kioslave-file.h.cmake |
67 |
-index e47fdb2..3df7ebd 100644 |
68 |
---- a/src/ioslaves/file/config-kioslave-file.h.cmake |
69 |
-+++ b/src/ioslaves/file/config-kioslave-file.h.cmake |
70 |
-@@ -13,3 +13,5 @@ |
71 |
- /* Defined if system has extended file attributes support. */ |
72 |
- #cmakedefine01 HAVE_SYS_XATTR_H |
73 |
- |
74 |
-+/* Defined if system has the sendfile function. */ |
75 |
-+#cmakedefine01 HAVE_SENDFILE |
76 |
-diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp |
77 |
-index 817cce8..34422e5 100644 |
78 |
---- a/src/ioslaves/file/file_unix.cpp |
79 |
-+++ b/src/ioslaves/file/file_unix.cpp |
80 |
-@@ -49,7 +49,7 @@ |
81 |
- #include "fdreceiver.h" |
82 |
- |
83 |
- //sendfile has different semantics in different platforms |
84 |
--#if defined HAVE_SENDFILE && defined Q_OS_LINUX |
85 |
-+#if HAVE_SENDFILE && defined Q_OS_LINUX |
86 |
- #define USE_SENDFILE 1 |
87 |
- #endif |
88 |
- |
89 |
--- |
90 |
-cgit v0.11.2 |
91 |
-From 8f926e4596221b11e62c7ac80bb5864d3d8cf4f6 Mon Sep 17 00:00:00 2001 |
92 |
-From: David Edmundson <kde@×××××××××××××××××.uk> |
93 |
-Date: Wed, 21 Nov 2018 15:30:53 +0000 |
94 |
-Subject: Use correct variable type for returned value from read/sendfile |
95 |
- |
96 |
-Summary: |
97 |
-n stores the read/transferred bytes. This returns a ssize_t. |
98 |
-We were casting to an int, which theoretically is a loss of data. |
99 |
- |
100 |
-In practice it isn't an issue as we only read a max of MAX_IPC_SIZE at a |
101 |
-time, which would fit in an int. |
102 |
- |
103 |
-Reviewers: apol |
104 |
- |
105 |
-Reviewed By: apol |
106 |
- |
107 |
-Subscribers: kde-frameworks-devel |
108 |
- |
109 |
-Tags: #frameworks |
110 |
- |
111 |
-Differential Revision: https://phabricator.kde.org/D17051 |
112 |
---- |
113 |
- src/ioslaves/file/file_unix.cpp | 2 +- |
114 |
- 1 file changed, 1 insertion(+), 1 deletion(-) |
115 |
- |
116 |
-diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp |
117 |
-index 34422e5..7ed0ae8 100644 |
118 |
---- a/src/ioslaves/file/file_unix.cpp |
119 |
-+++ b/src/ioslaves/file/file_unix.cpp |
120 |
-@@ -251,7 +251,7 @@ void FileProtocol::copy(const QUrl &srcUrl, const QUrl &destUrl, |
121 |
- |
122 |
- KIO::filesize_t processed_size = 0; |
123 |
- char buffer[ MAX_IPC_SIZE ]; |
124 |
-- int n; |
125 |
-+ ssize_t n = 0; |
126 |
- #ifdef USE_SENDFILE |
127 |
- bool use_sendfile = buff_src.st_size < 0x7FFFFFFF; |
128 |
- #endif |
129 |
--- |
130 |
-cgit v0.11.2 |