Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: media-gfx/kxstitch/, media-gfx/kxstitch/files/
Date: Sat, 22 Jun 2019 14:50:57
Message-Id: 1561215034.115ef47d90a31b86423d33845023b58fff05ca1e.asturm@gentoo
1 commit: 115ef47d90a31b86423d33845023b58fff05ca1e
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sat Jun 22 13:51:35 2019 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sat Jun 22 14:50:34 2019 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=115ef47d
7
8 media-gfx/kxstitch: Drop 2.1.1-r2
9
10 Package-Manager: Portage-2.3.67, Repoman-2.3.15
11 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
12
13 media-gfx/kxstitch/Manifest | 1 -
14 .../files/kxstitch-2.1.1-imagemagick-fix.patch | 99 ----------------------
15 .../kxstitch/files/kxstitch-2.1.1-qt-5.11.patch | 37 --------
16 media-gfx/kxstitch/kxstitch-2.1.1-r2.ebuild | 46 ----------
17 4 files changed, 183 deletions(-)
18
19 diff --git a/media-gfx/kxstitch/Manifest b/media-gfx/kxstitch/Manifest
20 index 269543effbc..756774fdacc 100644
21 --- a/media-gfx/kxstitch/Manifest
22 +++ b/media-gfx/kxstitch/Manifest
23 @@ -1,2 +1 @@
24 -DIST kxstitch-2.1.1.tar.xz 1726364 BLAKE2B 47257408f31ca7db4bddf984150baac6cd850206cedb95c73b0d62ee9f966028afd97bb3653b385104a1c679512c35f41aa25c5b703c715e565d48cfda59da36 SHA512 d5a6b6d06bfb894dd7404cb81350389f1ebf5c8a463eb792358abd67f362d1e1f578d06319461a006625864f1c4a69ebb4ccd0db422870c3eae0516c9132a3b3
25 DIST kxstitch-2.2.0.tar.xz 1784360 BLAKE2B 6d06090bb33ccd4db7e8b8a3521b0e1377f253b472cc500862b1b8b0da1abf0d759a85a870b50a1a1f55f385274cdc94761e612a838d93aaffb76191df725150 SHA512 bf09130a35bc605db2bbd6e5e129ac494e8f02b920d4a8d6705b5030a9339306b3b302bd988839e1684da3e5e15e91d655dadf916eb4bf2dc9c1322fd435281d
26
27 diff --git a/media-gfx/kxstitch/files/kxstitch-2.1.1-imagemagick-fix.patch b/media-gfx/kxstitch/files/kxstitch-2.1.1-imagemagick-fix.patch
28 deleted file mode 100644
29 index bf8c5e14096..00000000000
30 --- a/media-gfx/kxstitch/files/kxstitch-2.1.1-imagemagick-fix.patch
31 +++ /dev/null
32 @@ -1,99 +0,0 @@
33 -From 75a129d3c2f21914a47b970df822e485aca625ac Mon Sep 17 00:00:00 2001
34 -From: Steve Allewell <steve.allewell@×××××.com>
35 -Date: Sun, 11 Nov 2018 15:48:50 +0000
36 -Subject: Fix for importing images for V6 of ImageMagick
37 -
38 -The getPixelColor in V6 of ImageMagick does not appear to return the
39 -same information as in V7, consequently importing images has resulted in
40 -a black image when using V6 of ImageMagick. This fix reverts the change
41 -made in commit 295773f44bfda1227d85edf065a8de14dc889159 when using V6.
42 -
43 -Big thanks to Sean Enck for reporting and helping diagnose the problem.
44 ----
45 - src/ImportImageDlg.cpp | 16 ++++++++++++++++
46 - src/MainWindow.cpp | 17 +++++++++++++++++
47 - 2 files changed, 33 insertions(+)
48 -
49 -diff --git a/src/ImportImageDlg.cpp b/src/ImportImageDlg.cpp
50 -index e6396c6..340ff1d 100644
51 ---- a/src/ImportImageDlg.cpp
52 -+++ b/src/ImportImageDlg.cpp
53 -@@ -391,9 +391,21 @@ void ImportImageDlg::renderPixmap()
54 - QProgressDialog progress(i18n("Rendering preview"), i18n("Cancel"), 0, pixelCount, this);
55 - progress.setWindowModality(Qt::WindowModal);
56 -
57 -+/*
58 -+ * ImageMagick prior to V7 used matte (opacity) to determine if an image has transparency.
59 -+ * 0.0 for transparent to 1.0 for opaque
60 -+ *
61 -+ * ImageMagick V7 now uses alpha (transparency).
62 -+ * 1.0 for transparent to 0.0 for opaque
63 -+ *
64 -+ * Access to pixels has changed too, V7 can use pixelColor to access the color of a particular
65 -+ * pixel, but although this was available in V6, it doesn't appear to produce the same result
66 -+ * and has resulted in black images when importing.
67 -+ */
68 - #if MagickLibVersion < 0x700
69 - bool hasTransparency = m_convertedImage.matte();
70 - double transparent = 1.0;
71 -+ const Magick::PixelPacket *pixels = m_convertedImage.getConstPixels(0, 0, width, height);
72 - #else
73 - bool hasTransparency = m_convertedImage.alpha();
74 - double transparent = 0.0;
75 -@@ -408,7 +420,11 @@ void ImportImageDlg::renderPixmap()
76 - }
77 -
78 - for (int dx = 0 ; dx < width ; dx++) {
79 -+#if MagickLibVersion < 0x700
80 -+ Magick::ColorRGB rgb = Magick::Color(*pixels++);
81 -+#else
82 - Magick::ColorRGB rgb = m_convertedImage.pixelColor(dx, dy);
83 -+#endif
84 -
85 - if (hasTransparency && (rgb.alpha() == transparent)) {
86 - //ignore this pixel as it is transparent
87 -diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
88 -index 1f12f5b..ecf552a 100644
89 ---- a/src/MainWindow.cpp
90 -+++ b/src/MainWindow.cpp
91 -@@ -541,13 +541,26 @@ void MainWindow::convertImage(const QString &source)
92 -
93 - bool useFractionals = importImageDlg->useFractionals();
94 -
95 -+/*
96 -+ * ImageMagick prior to V7 used matte (opacity) to determine if an image has transparency.
97 -+ * 0.0 for transparent to 1.0 for opaque
98 -+ *
99 -+ * ImageMagick V7 now uses alpha (transparency).
100 -+ * 1.0 for transparent to 0.0 for opaque
101 -+ *
102 -+ * Access to pixels has changed too, V7 can use pixelColor to access the color of a particular
103 -+ * pixel, but although this was available in V6, it doesn't appear to produce the same result
104 -+ * and has resulted in black images when importing.
105 -+ */
106 - #if MagickLibVersion < 0x700
107 - bool hasTransparency = convertedImage.matte();
108 - double transparent = 1.0;
109 -+ const Magick::PixelPacket *pixels = convertedImage.getConstPixels(0, 0, imageWidth, imageHeight);
110 - #else
111 - bool hasTransparency = convertedImage.alpha();
112 - double transparent = 0.0;
113 - #endif
114 -+
115 - bool ignoreColor = importImageDlg->ignoreColor();
116 - Magick::Color ignoreColorValue = importImageDlg->ignoreColorValue();
117 -
118 -@@ -579,7 +592,11 @@ void MainWindow::convertImage(const QString &source)
119 - }
120 -
121 - for (int dx = 0 ; dx < imageWidth ; dx++) {
122 -+#if MagickLibVersion < 0x700
123 -+ Magick::ColorRGB rgb = Magick::Color(*pixels++); // is this a memory leak
124 -+#else
125 - Magick::ColorRGB rgb = convertedImage.pixelColor(dx, dy);
126 -+#endif
127 -
128 - if (hasTransparency && (rgb.alpha() == transparent)) {
129 - // ignore this pixel as it is transparent
130 ---
131 -cgit v1.1
132
133 diff --git a/media-gfx/kxstitch/files/kxstitch-2.1.1-qt-5.11.patch b/media-gfx/kxstitch/files/kxstitch-2.1.1-qt-5.11.patch
134 deleted file mode 100644
135 index 70022fe9c8f..00000000000
136 --- a/media-gfx/kxstitch/files/kxstitch-2.1.1-qt-5.11.patch
137 +++ /dev/null
138 @@ -1,37 +0,0 @@
139 -From 9db3fcf9cd367681c0864238dc5009a604f3896c Mon Sep 17 00:00:00 2001
140 -From: Jonathan Riddell <jr@××××××××.org>
141 -Date: Wed, 27 Jun 2018 16:45:16 +0100
142 -Subject: fix build with Qt 5.11
143 -
144 ----
145 - src/LibraryPatternPropertiesDlg.cpp | 2 ++
146 - src/TextElementDlg.cpp | 1 +
147 - 2 files changed, 3 insertions(+)
148 -
149 -diff --git a/src/LibraryPatternPropertiesDlg.cpp b/src/LibraryPatternPropertiesDlg.cpp
150 -index 8d2e24c..c10da3f 100644
151 ---- a/src/LibraryPatternPropertiesDlg.cpp
152 -+++ b/src/LibraryPatternPropertiesDlg.cpp
153 -@@ -11,6 +11,8 @@
154 -
155 - #include "LibraryPatternPropertiesDlg.h"
156 -
157 -+#include <QIcon>
158 -+
159 - #include <KConfigGroup>
160 - #include <KHelpClient>
161 - #include <KLocalizedString>
162 -diff --git a/src/TextElementDlg.cpp b/src/TextElementDlg.cpp
163 -index 4d88b1e..fb545d1 100644
164 ---- a/src/TextElementDlg.cpp
165 -+++ b/src/TextElementDlg.cpp
166 -@@ -16,6 +16,7 @@
167 - #include "TextElementDlg.h"
168 -
169 - #include <QColorDialog>
170 -+#include <QButtonGroup>
171 -
172 - #include <KHelpClient>
173 - #include <KLocalizedString>
174 ---
175 -cgit v0.11.2
176
177 diff --git a/media-gfx/kxstitch/kxstitch-2.1.1-r2.ebuild b/media-gfx/kxstitch/kxstitch-2.1.1-r2.ebuild
178 deleted file mode 100644
179 index 232c67d1a14..00000000000
180 --- a/media-gfx/kxstitch/kxstitch-2.1.1-r2.ebuild
181 +++ /dev/null
182 @@ -1,46 +0,0 @@
183 -# Copyright 1999-2019 Gentoo Authors
184 -# Distributed under the terms of the GNU General Public License v2
185 -
186 -EAPI=7
187 -
188 -KDE_HANDBOOK="forceoptional"
189 -inherit kde5
190 -
191 -DESCRIPTION="Program to create cross stitch patterns"
192 -HOMEPAGE="https://userbase.kde.org/KXStitch"
193 -SRC_URI="mirror://kde/stable/${PN}/${PV}/${P}.tar.xz"
194 -
195 -LICENSE="GPL-2+"
196 -SLOT="5"
197 -KEYWORDS="~amd64"
198 -IUSE=""
199 -
200 -BDEPEND="
201 - sys-devel/gettext
202 -"
203 -DEPEND="
204 - $(add_frameworks_dep kcompletion)
205 - $(add_frameworks_dep kconfig)
206 - $(add_frameworks_dep kconfigwidgets)
207 - $(add_frameworks_dep kcoreaddons)
208 - $(add_frameworks_dep ki18n)
209 - $(add_frameworks_dep kio)
210 - $(add_frameworks_dep ktextwidgets)
211 - $(add_frameworks_dep kwidgetsaddons)
212 - $(add_frameworks_dep kxmlgui)
213 - $(add_qt_dep qtgui)
214 - $(add_qt_dep qtprintsupport)
215 - $(add_qt_dep qtwidgets)
216 - $(add_qt_dep qtx11extras)
217 - $(add_qt_dep qtxml)
218 - media-gfx/imagemagick[cxx]
219 - x11-libs/libX11
220 -"
221 -RDEPEND="${DEPEND}
222 - !media-gfx/kxstitch:4
223 -"
224 -
225 -PATCHES=(
226 - "${FILESDIR}/${P}-qt-5.11.patch"
227 - "${FILESDIR}/${P}-imagemagick-fix.patch"
228 -)