| 1 |
commit: ea2d9c5a7da408437d36c3f14112088f905d57f1 |
| 2 |
Author: Andreas K. Huettel (dilfridge) <dilfridge <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Mon Jul 21 20:22:36 2014 +0000 |
| 4 |
Commit: Alexander Berntsen <bernalex <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Fri Jul 25 16:11:24 2014 +0000 |
| 6 |
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=ea2d9c5a |
| 7 |
|
| 8 |
repoman: Warn if virtuals depend on perl-core, bug 516428 |
| 9 |
|
| 10 |
Reported-by: Andreas K. Hüttel <dilfridge <AT> gentoo.org> |
| 11 |
Authored-by: Andreas K. Hüttel <dilfridge <AT> gentoo.org> |
| 12 |
Reviewed-by: Alexander Berntsen <bernalex <AT> gentoo.org> |
| 13 |
Signed-off-by: Alexander Berntsen <bernalex <AT> gentoo.org> |
| 14 |
|
| 15 |
--- |
| 16 |
bin/repoman | 9 +++++++++ |
| 17 |
1 file changed, 9 insertions(+) |
| 18 |
|
| 19 |
diff --git a/bin/repoman b/bin/repoman |
| 20 |
index c36ace1..9c5d720 100755 |
| 21 |
--- a/bin/repoman |
| 22 |
+++ b/bin/repoman |
| 23 |
@@ -299,6 +299,7 @@ qahelp = { |
| 24 |
"dependency.badindev": "User-visible ebuilds with unsatisfied dependencies (matched against *visible* ebuilds) in developing arch", |
| 25 |
"dependency.badmaskedindev": "Masked ebuilds with unsatisfied dependencies (matched against *all* ebuilds) in developing arch", |
| 26 |
"dependency.badtilde": "Uses the ~ dep operator with a non-zero revision part, which is useless (the revision is ignored)", |
| 27 |
+ "dependency.perlcore": "This ebuild directly depends on a package in perl-core; it should use the corresponding virtual instead.", |
| 28 |
"dependency.syntax": "Syntax error in dependency string (usually an extra/missing space/parenthesis)", |
| 29 |
"dependency.unknown": "Ebuild has a dependency that refers to an unknown package (which may be valid if it is a blocker for a renamed/removed package, or is an alternative choice provided by an overlay)", |
| 30 |
"file.executable": "Ebuilds, digests, metadata.xml, Manifest, and ChangeLog do not need the executable bit", |
| 31 |
@@ -386,6 +387,7 @@ qawarnings = set(( |
| 32 |
"dependency.badindev", |
| 33 |
"dependency.badmaskedindev", |
| 34 |
"dependency.badtilde", |
| 35 |
+"dependency.perlcore", |
| 36 |
"DESCRIPTION.punctuation", |
| 37 |
"DESCRIPTION.toolong", |
| 38 |
"EAPI.deprecated", |
| 39 |
@@ -2058,6 +2060,13 @@ for x in effective_scanlist: |
| 40 |
relative_path + |
| 41 |
": %s: consider using '%s' instead of '%s'" % |
| 42 |
(mytype, suspect_virtual[atom.cp], atom)) |
| 43 |
+ if not is_blocker and \ |
| 44 |
+ atom.cp.startswith("perl-core/"): |
| 45 |
+ stats['dependency.perlcore'] += 1 |
| 46 |
+ fails['dependency.perlcore'].append( |
| 47 |
+ relative_path + |
| 48 |
+ ": %s: please use '%s' instead of '%s'" % |
| 49 |
+ (mytype, atom.replace("perl-core/","virtual/perl-"), atom)) |
| 50 |
|
| 51 |
if buildtime and \ |
| 52 |
not is_blocker and \ |
Archives