| 1 |
Author: zmedico |
| 2 |
Date: 2009-10-01 19:29:24 +0000 (Thu, 01 Oct 2009) |
| 3 |
New Revision: 14471 |
| 4 |
|
| 5 |
Modified: |
| 6 |
main/trunk/man/repoman.1 |
| 7 |
main/trunk/pym/repoman/checks.py |
| 8 |
Log: |
| 9 |
Bug #285191 - Remove the RDEPEND.implicit check because it is invalid. |
| 10 |
|
| 11 |
|
| 12 |
Modified: main/trunk/man/repoman.1 |
| 13 |
=================================================================== |
| 14 |
--- main/trunk/man/repoman.1 2009-10-01 19:21:24 UTC (rev 14470) |
| 15 |
+++ main/trunk/man/repoman.1 2009-10-01 19:29:24 UTC (rev 14471) |
| 16 |
@@ -186,10 +186,6 @@ |
| 17 |
.B RDEPEND.badmaskedindev |
| 18 |
Masked ebuilds with RDEPEND settings (matched against *all* ebuilds) in developing arch |
| 19 |
.TP |
| 20 |
-.B RDEPEND.implicit |
| 21 |
-RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND |
| 22 |
-assignment |
| 23 |
-.TP |
| 24 |
.B RDEPEND.suspect |
| 25 |
RDEPEND contains a package that usually only belongs in DEPEND |
| 26 |
.TP |
| 27 |
|
| 28 |
Modified: main/trunk/pym/repoman/checks.py |
| 29 |
=================================================================== |
| 30 |
--- main/trunk/pym/repoman/checks.py 2009-10-01 19:21:24 UTC (rev 14470) |
| 31 |
+++ main/trunk/pym/repoman/checks.py 2009-10-01 19:29:24 UTC (rev 14471) |
| 32 |
@@ -268,37 +268,6 @@ |
| 33 |
if match: |
| 34 |
return "Quoted \"${A}\" on line: %d" |
| 35 |
|
| 36 |
-class ImplicitRuntimeDeps(LineCheck): |
| 37 |
- """ |
| 38 |
- Detect the case where DEPEND is set and RDEPEND is unset in the ebuild, |
| 39 |
- since this triggers implicit RDEPEND=$DEPEND assignment. |
| 40 |
- """ |
| 41 |
- |
| 42 |
- _assignment_re = re.compile(r'^\s*(R?DEPEND)=') |
| 43 |
- |
| 44 |
- def new(self, pkg): |
| 45 |
- # RDEPEND=DEPEND is no longer available in EAPI=3 |
| 46 |
- if pkg.metadata['EAPI'] in ('0', '1', '2'): |
| 47 |
- self.repoman_check_name = 'RDEPEND.implicit' |
| 48 |
- else: |
| 49 |
- self.repoman_check_name = 'EAPI.incompatible' |
| 50 |
- self._rdepend = False |
| 51 |
- self._depend = False |
| 52 |
- |
| 53 |
- def check(self, num, line): |
| 54 |
- if not self._rdepend: |
| 55 |
- m = self._assignment_re.match(line) |
| 56 |
- if m is None: |
| 57 |
- pass |
| 58 |
- elif m.group(1) == "RDEPEND": |
| 59 |
- self._rdepend = True |
| 60 |
- elif m.group(1) == "DEPEND": |
| 61 |
- self._depend = True |
| 62 |
- |
| 63 |
- def end(self): |
| 64 |
- if self._depend and not self._rdepend: |
| 65 |
- yield 'RDEPEND is not explicitly assigned' |
| 66 |
- |
| 67 |
class InheritAutotools(LineCheck): |
| 68 |
""" |
| 69 |
Make sure appropriate functions are called in |
| 70 |
@@ -493,7 +462,7 @@ |
| 71 |
EbuildAssignment, EbuildUselessDodoc, |
| 72 |
EbuildUselessCdS, EbuildNestedDie, |
| 73 |
EbuildPatches, EbuildQuotedA, EapiDefinition, |
| 74 |
- IUseUndefined, ImplicitRuntimeDeps, InheritAutotools, |
| 75 |
+ IUseUndefined, InheritAutotools, |
| 76 |
EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, |
| 77 |
DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue, |
| 78 |
SrcCompileEconf, Eapi3IncompatibleFuncs, Eapi3GoneVars))) |
Archives