Gentoo Archives: gentoo-commits

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/genkernel:master commit in: defaults/
Date: Fri, 01 Mar 2019 05:55:17
Message-Id: 1551419559.205135d844f76de534417a67235bfcf9ec4eecca.robbat2@gentoo
1 commit: 205135d844f76de534417a67235bfcf9ec4eecca
2 Author: Guido Jäkel <g.jaekel <AT> dnb <DOT> de>
3 AuthorDate: Wed Jun 20 08:34:24 2018 +0000
4 Commit: Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
5 CommitDate: Fri Mar 1 05:52:39 2019 +0000
6 URL: https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=205135d8
7
8 remove NFS rsize/wsize options from default
9
10 I suggest to completely remove "rsize=1024,wsize=1024" from the DEFAULT_NFSOPTIONS:
11 * The kernel/mount default is "unlimited" and the concrete values will be with negotiated with the NFS server.
12 * If optional values for {r,w}size are passed to the kernel commandline parameter "nfrsoot=...,<options>", this additinal options are *appended* to the resulting mount options. But (at least) for {r,w}size, the first occurrence strikes; i.e. the values passed via the commandline are ignored in fact.
13
14 As a more complex alternative, the function "findnfsmount()" ( <AT> initrd.scripts, 569ff.) may be rewritten to parse and kick out double-occurences of options.
15
16 Background: I run into this issue booting a diskless server; using PXE for the kernel and initramfs and NFS for the rootfs.
17
18 Signed-off-by: Guido Jäkel <G.Jaekel <AT> DNB.DE>
19 Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org>
20
21 defaults/initrd.defaults | 2 +-
22 1 file changed, 1 insertion(+), 1 deletion(-)
23
24 diff --git a/defaults/initrd.defaults b/defaults/initrd.defaults
25 index 924bdea..8ef8d3c 100755
26 --- a/defaults/initrd.defaults
27 +++ b/defaults/initrd.defaults
28 @@ -81,7 +81,7 @@ overlayfs_modules_dir=mnt/cdrom
29
30 LOOPS='/livecd.loop /zisofs /livecd.squashfs /image.squashfs /livecd.gcloop'
31
32 -DEFAULT_NFSOPTIONS="ro,nolock,rsize=1024,wsize=1024"
33 +DEFAULT_NFSOPTIONS="ro,nolock"
34
35 # HWOPTS is the list of ALL options that take do/no prefixes, almost all of
36 # which match a MODULES_* variable; it is ALSO the order of evaluation.