[gentoo-commits] gentoo-x86 commit in eclass: rox.eclass

[Jim Ramsay (lack)]

lack        07/11/28 17:20:04

  Modified:             rox.eclass
  Log:
  Replaced IFS with marginally more readable value
  
  Replaced useq with use (thanks to drac for pointing this out)
  
  Added warnings about not using 'usemime' in the global scope.

Revision  Changes    Path
1.24                 eclass/rox.eclass

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/rox.eclass?rev=1.24&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/rox.eclass?rev=1.24&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/rox.eclass?r1=1.23&r2=1.24

Index: rox.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/rox.eclass,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- rox.eclass	28 Nov 2007 14:20:58 -0000	1.23
+++ rox.eclass	28 Nov 2007 17:20:03 -0000	1.24
@@ -1,6 +1,6 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/rox.eclass,v 1.23 2007/11/28 14:20:58 lack Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/rox.eclass,v 1.24 2007/11/28 17:20:03 lack Exp $
 
 # ROX eclass Version 3
 
@@ -38,8 +38,11 @@
 #       APPMIME="a/foo-1;a/foo-2
 #                $(usemime three "a/three")
 #                text/plain"
-#    will be expanded to either "a/foo-1;a/foo-2;a/three;text/plain" if USE=three
-#    or "a/foo-1;a/foo-2;text/plain" if not.
+#    will be expanded to either "a/foo-1;a/foo-2;a/three;text/plain" if 
+#    USE=three or "a/foo-1;a/foo-2;text/plain" if not.
+#    WARNING: the 'usemime' function cannot be used in global scope. You should
+#    set APPMIME (or at least the USE-dependant parts) in your own src_install
+#    before calling rox_src_install.  See rox-extra/archive for an example.
 # KEEP_SRC - this flag, if set, will not remove the source directory
 #    but will do a 'make clean' in it. This is useful if users wish to
 #    preserve the source code for some reason
@@ -84,9 +87,11 @@
 # External Functions
 
 # Used for assembling APPMIME with USE-dependent parts
+# WARNING: Cannot be used in global scope.
+#          Set this in src_install just before you call rox_src_install
 usemime() {
 	local myuse=$1; shift
-	useq $myuse && echo "$@"
+	use $myuse && echo "$@"
 }
 
 # Utility Functions
@@ -95,7 +100,7 @@
 # where needed.
 expandmime() {
 	local old_IFS=$IFS
-	IFS=";$' \t\n'"
+	IFS=$'; \t\n'
 	echo "$*"
 	IFS=$old_IFS
 }



-- 
gentoo-commits@g.o mailing list