1 |
commit: a7182e09e90bcd37cca9f56639f604a809ab4c1d |
2 |
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
3 |
AuthorDate: Mon Feb 3 13:07:47 2020 +0000 |
4 |
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
5 |
CommitDate: Mon Feb 3 13:07:47 2020 +0000 |
6 |
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=a7182e09 |
7 |
|
8 |
libq/tree: ensure meta fields are clear when not set |
9 |
|
10 |
For some reason we went with uncleared pointers. Probably because we |
11 |
only requested things that should/would exist. However, for sanity, and |
12 |
probably bug #701470, return NULL pointers for anything not set (in |
13 |
metadata). |
14 |
|
15 |
Bug: https://bugs.gentoo.org/show_bug.cgi?id=701470 |
16 |
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> |
17 |
|
18 |
libq/tree.c | 6 +++--- |
19 |
1 file changed, 3 insertions(+), 3 deletions(-) |
20 |
|
21 |
diff --git a/libq/tree.c b/libq/tree.c |
22 |
index 9df3541..8424459 100644 |
23 |
--- a/libq/tree.c |
24 |
+++ b/libq/tree.c |
25 |
@@ -621,7 +621,7 @@ tree_read_file_pms(tree_pkg_ctx *pkg_ctx) |
26 |
goto err; |
27 |
|
28 |
len = sizeof(*ret) + s.st_size + 1; |
29 |
- ret = xmalloc(len); |
30 |
+ ret = xzalloc(len); |
31 |
ptr = (char*)ret + sizeof(*ret); |
32 |
if ((off_t)fread(ptr, 1, s.st_size, f) != s.st_size) |
33 |
goto err; |
34 |
@@ -689,7 +689,7 @@ tree_read_file_md5(tree_pkg_ctx *pkg_ctx) |
35 |
goto err; |
36 |
|
37 |
len = sizeof(*ret) + s.st_size + 1; |
38 |
- ret = xmalloc(len); |
39 |
+ ret = xzalloc(len); |
40 |
ptr = (char*)ret + sizeof(*ret); |
41 |
if ((off_t)fread(ptr, 1, s.st_size, f) != s.st_size) |
42 |
goto err; |
43 |
@@ -802,7 +802,7 @@ tree_read_file_ebuild(tree_pkg_ctx *pkg_ctx) |
44 |
goto err; |
45 |
|
46 |
len = sizeof(*ret) + s.st_size + 1; |
47 |
- ret = xmalloc(len); |
48 |
+ ret = xzalloc(len); |
49 |
p = (char *)ret + sizeof(*ret); |
50 |
if ((off_t)fread(p, 1, s.st_size, f) != s.st_size) |
51 |
goto err; |