Gentoo Archives: gentoo-commits

From: Marek Szuba <marecki@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: sci-electronics/ngspice/
Date: Fri, 29 Dec 2017 15:11:52
Message-Id: 1514560289.dfff7d0d5c2104311e9f5163931597a29862137e.marecki@gentoo
1 commit: dfff7d0d5c2104311e9f5163931597a29862137e
2 Author: Marek Szuba <marecki <AT> gentoo <DOT> org>
3 AuthorDate: Fri Dec 29 15:11:29 2017 +0000
4 Commit: Marek Szuba <marecki <AT> gentoo <DOT> org>
5 CommitDate: Fri Dec 29 15:11:29 2017 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfff7d0d
7
8 sci-electronics/ngspice: reenable tests
9
10 If USE=debug is not set, all tests should pass now - excessive output
11 which broke empty-1.cir and resume-1.cir was a side effect of enabling
12 NDEV, which we have just disabled as recommended by upstream.
13
14 If USE=debug *is* set tests cannot presently succeed because of excessive
15 output in all 4 tests in regression/lib-processing/. Just print a
16 warning and skip the tests altogether.
17
18 See-Also: https://sourceforge.net/p/ngspice/bugs/353/
19 Gentoo-Bug: https://bugs.gentoo.org/642460
20 Package-Manager: Portage-2.3.13, Repoman-2.3.3
21
22 sci-electronics/ngspice/ngspice-27-r1.ebuild | 12 ++++++++----
23 1 file changed, 8 insertions(+), 4 deletions(-)
24
25 diff --git a/sci-electronics/ngspice/ngspice-27-r1.ebuild b/sci-electronics/ngspice/ngspice-27-r1.ebuild
26 index c7357f55c6e..849d3e48a21 100644
27 --- a/sci-electronics/ngspice/ngspice-27-r1.ebuild
28 +++ b/sci-electronics/ngspice/ngspice-27-r1.ebuild
29 @@ -15,9 +15,6 @@ SLOT="0"
30 IUSE="X debug doc examples fftw openmp readline shared tcl"
31 KEYWORDS="~amd64 ~ppc ~sparc ~x86 ~x64-macos"
32
33 -# See bug #642460
34 -RESTRICT="test"
35 -
36 DEPEND="sys-libs/ncurses:0=
37 X? ( x11-libs/libXaw
38 x11-libs/libXt
39 @@ -179,7 +176,14 @@ ngspice_install() {
40 }
41
42 src_test() {
43 - multibuild_foreach_variant ngspice_test
44 + if ! use debug; then
45 + multibuild_foreach_variant ngspice_test
46 + else
47 + # https://sourceforge.net/p/ngspice/bugs/353/
48 + ewarn
49 + ewarn "Skipping tests because they are known to fail in debug mode"
50 + ewarn
51 + fi
52 }
53
54 ngspice_test() {