Gentoo Archives: gentoo-commits

From: "Zac Medico (zmedico)" <zmedico@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] portage r13724 - main/trunk/bin
Date: Sun, 28 Jun 2009 18:24:25
Message-Id: E1MKz39-0000bJ-PI@stork.gentoo.org
1 Author: zmedico
2 Date: 2009-06-28 18:24:23 +0000 (Sun, 28 Jun 2009)
3 New Revision: 13724
4
5 Modified:
6 main/trunk/bin/repoman
7 Log:
8 Bug #236786 - Warn about 'test?' USE conditionals in RDEPEND. Thanks to
9 Markus Meier <maekke@g.o> for this patch.
10
11
12 Modified: main/trunk/bin/repoman
13 ===================================================================
14 --- main/trunk/bin/repoman 2009-06-28 16:12:28 UTC (rev 13723)
15 +++ main/trunk/bin/repoman 2009-06-28 18:24:23 UTC (rev 13724)
16 @@ -1404,7 +1404,11 @@
17 if mytype in ("DEPEND", "RDEPEND", "PDEPEND"):
18 for token in mydepstr.split():
19 if token in operator_tokens or \
20 - token.endswith("?"):
21 + token[-1:] == "?":
22 + if token == "test?" and mytype == "RDEPEND":
23 + stats['RDEPEND.suspect'] += 1
24 + fails['RDEPEND.suspect'].append(relative_path + \
25 + ": 'test?' USE conditional in RDEPEND")
26 continue
27 try:
28 atom = portage.dep.Atom(token)