Gentoo Archives: gentoo-commits

From: Brian Dolbec <dolsen@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage:repoman commit in: pym/repoman/modules/scan/metadata/, pym/repoman/
Date: Sun, 31 Jan 2016 20:03:42
Message-Id: 1454185521.de3ef8986c2607fb4741ab664b31c29e1a3c936e.dolsen@gentoo
1 commit: de3ef8986c2607fb4741ab664b31c29e1a3c936e
2 Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org>
3 AuthorDate: Sun Jan 3 11:31:26 2016 +0000
4 Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org>
5 CommitDate: Sat Jan 30 20:25:21 2016 +0000
6 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=de3ef898
7
8 scanner.py: Migrate another metadata check to ebuild_metadata
9
10 pym/repoman/modules/scan/metadata/ebuild_metadata.py | 3 +++
11 pym/repoman/scanner.py | 2 --
12 2 files changed, 3 insertions(+), 2 deletions(-)
13
14 diff --git a/pym/repoman/modules/scan/metadata/ebuild_metadata.py b/pym/repoman/modules/scan/metadata/ebuild_metadata.py
15 index 143a40e..2dc1db2 100644
16 --- a/pym/repoman/modules/scan/metadata/ebuild_metadata.py
17 +++ b/pym/repoman/modules/scan/metadata/ebuild_metadata.py
18 @@ -28,6 +28,9 @@ class EbuildMetadata(object):
19 "%s: %s variable contains non-ASCII "
20 "character at position %s" %
21 (ebuild.relative_path, k, m.start() + 1))
22 + if ebuild.metadata.get("PROVIDE"):
23 + self.qatracker.add_error("virtual.oldstyle", ebuild.relative_path)
24 +
25 return {'continue': False}
26
27 @property
28
29 diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py
30 index c5601dd..ec126e6 100644
31 --- a/pym/repoman/scanner.py
32 +++ b/pym/repoman/scanner.py
33 @@ -327,8 +327,6 @@ class Scanner(object):
34 if y_ebuild_continue:
35 continue
36
37 - if dynamic_data['ebuild'].metadata.get("PROVIDE"):
38 - self.qatracker.add_error("virtual.oldstyle", dynamic_data['ebuild'].relative_path)
39
40 for pos, missing_var in enumerate(missingvars):
41 if not dynamic_data['ebuild'].metadata.get(missing_var):