Gentoo Archives: gentoo-commits

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/common-mistakes/
Date: Tue, 30 Mar 2021 18:15:53
Message-Id: 1617128092.fd90736ea1141e95c63a9634d424aa843454ca45.ulm@gentoo
1 commit: fd90736ea1141e95c63a9634d424aa843454ca45
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Sun Mar 21 02:31:00 2021 +0000
4 Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org>
5 CommitDate: Tue Mar 30 18:14:52 2021 +0000
6 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=fd90736e
7
8 ebuild-writing/common-mistakes: give more information on invalid ${ROOT} usage
9
10 Bug: https://bugs.gentoo.org/775191
11 Signed-off-by: Sam James <sam <AT> gentoo.org>
12 [Add bug number to link text.]
13 Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>
14
15 ebuild-writing/common-mistakes/text.xml | 7 +++++--
16 1 file changed, 5 insertions(+), 2 deletions(-)
17
18 diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml
19 index d77b143..c92813f 100644
20 --- a/ebuild-writing/common-mistakes/text.xml
21 +++ b/ebuild-writing/common-mistakes/text.xml
22 @@ -31,8 +31,11 @@ this.
23 <p>
24 The usage of <c>ROOT</c> is only designed to influence the way the package is
25 installed (ie. into <c>ROOT</c>) <d/> building and compiling should not depend
26 -on <c>ROOT</c>. As a consequence of this the usage of <c>ROOT</c> in
27 -<c>src_*</c> functions is not allowed.
28 +on <c>ROOT</c>. As a consequence of this, the usage of <c>ROOT</c> in
29 +<c>src_*</c> functions is not allowed. <c>pkgcheck</c> can now detect some
30 +such cases via its <c>MisplacedVariable</c> check.
31 +See <uri link="https://bugs.gentoo.org/775191">bug 775191</uri> for more
32 +information.
33 </p>
34
35 <p>