Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/kde:master commit in: kde-apps/okular/files/, kde-apps/okular/
Date: Sun, 22 Aug 2021 23:03:31
Message-Id: 1629673341.6bf3ae87c13a3c61097fa1c4c4be36e8fa764d7a.asturm@gentoo
1 commit: 6bf3ae87c13a3c61097fa1c4c4be36e8fa764d7a
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sun Aug 22 23:02:21 2021 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sun Aug 22 23:02:21 2021 +0000
6 URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=6bf3ae87
7
8 kde-apps/okular: Rebase okular-20.11.90-tests.patch on top of HEAD
9
10 Reported-by: jospezial <jospezial <AT> gmx.de>
11 Closes: https://bugs.gentoo.org/809674
12 Package-Manager: Portage-3.0.22, Repoman-3.0.3
13 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
14
15 kde-apps/okular/files/okular-21.11.80-tests.patch | 145 ++++++++++++++++++++++
16 kde-apps/okular/okular-9999.ebuild | 2 +-
17 2 files changed, 146 insertions(+), 1 deletion(-)
18
19 diff --git a/kde-apps/okular/files/okular-21.11.80-tests.patch b/kde-apps/okular/files/okular-21.11.80-tests.patch
20 new file mode 100644
21 index 0000000000..683a07bc1a
22 --- /dev/null
23 +++ b/kde-apps/okular/files/okular-21.11.80-tests.patch
24 @@ -0,0 +1,145 @@
25 +From 323fed918995fe2e01036c74c1498446b4d2f122 Mon Sep 17 00:00:00 2001
26 +From: Andreas Sturmlechner <andreas.sturmlechner@×××××.com>
27 +Date: Thu, 12 Oct 2017 14:09:09 +0200
28 +Subject: [PATCH] Move tests into existing (auto)tests subdirectories
29 +
30 +---
31 + generators/chm/CMakeLists.txt | 12 +++---------
32 + generators/chm/autotests/CMakeLists.txt | 8 ++++++++
33 + generators/chm/autotests/chmgeneratortest.cpp | 2 +-
34 + generators/comicbook/CMakeLists.txt | 10 +++-------
35 + generators/comicbook/autotests/CMakeLists.txt | 6 ++++++
36 + generators/kimgio/CMakeLists.txt | 5 +----
37 + generators/kimgio/tests/CMakeLists.txt | 5 +++++
38 + generators/kimgio/tests/kimgiotest.cpp | 2 +-
39 + 8 files changed, 28 insertions(+), 22 deletions(-)
40 + create mode 100644 generators/chm/autotests/CMakeLists.txt
41 + create mode 100644 generators/comicbook/autotests/CMakeLists.txt
42 + create mode 100644 generators/kimgio/tests/CMakeLists.txt
43 +
44 +diff --git a/generators/chm/CMakeLists.txt b/generators/chm/CMakeLists.txt
45 +index 0d7452cba..3adb3fd54 100644
46 +--- a/generators/chm/CMakeLists.txt
47 ++++ b/generators/chm/CMakeLists.txt
48 +@@ -23,15 +23,9 @@ okular_add_generator(okularGenerator_chmlib ${okularGenerator_chmlib_SRCS})
49 + target_include_directories(okularGenerator_chmlib PRIVATE ${CHM_INCLUDE_DIR} ${LIBZIP_INCLUDE_DIR})
50 + target_link_libraries(okularGenerator_chmlib okularcore ${CHM_LIBRARY} ${LIBZIP_LIBRARY} KF5::KHtml)
51 +
52 +-########### autotests ###############
53 +-
54 +-add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
55 +-ecm_add_test(autotests/chmgeneratortest.cpp
56 +- TEST_NAME "chmgeneratortest"
57 +- LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore
58 +-)
59 +-
60 +-target_compile_definitions(chmgeneratortest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_chmlib>")
61 ++if(BUILD_TESTING)
62 ++ add_subdirectory(autotests)
63 ++endif()
64 +
65 + ########### install files ###############
66 + install( FILES okularChm.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
67 +diff --git a/generators/chm/autotests/CMakeLists.txt b/generators/chm/autotests/CMakeLists.txt
68 +new file mode 100644
69 +index 000000000..59753ca45
70 +--- /dev/null
71 ++++ b/generators/chm/autotests/CMakeLists.txt
72 +@@ -0,0 +1,8 @@
73 ++add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/../" )
74 ++
75 ++ecm_add_test(chmgeneratortest.cpp
76 ++ TEST_NAME "chmgeneratortest"
77 ++ LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore
78 ++)
79 ++
80 ++target_compile_definitions(chmgeneratortest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_chmlib>")
81 +diff --git a/generators/chm/autotests/chmgeneratortest.cpp b/generators/chm/autotests/chmgeneratortest.cpp
82 +index c428fa1b3..68f7a5821 100644
83 +--- a/generators/chm/autotests/chmgeneratortest.cpp
84 ++++ b/generators/chm/autotests/chmgeneratortest.cpp
85 +@@ -30,7 +30,7 @@ void ChmGeneratorTest::initTestCase()
86 + {
87 + Okular::SettingsCore::instance(QStringLiteral("ChmGeneratorTest"));
88 + m_document = new Okular::Document(nullptr);
89 +- const QString testFile = QStringLiteral(KDESRCDIR "autotests/data/test.chm");
90 ++ const QString testFile = QStringLiteral(KDESRCDIR "data/test.chm");
91 + QMimeDatabase db;
92 + const QMimeType mime = db.mimeTypeForFile(testFile);
93 + QCOMPARE(m_document->openDocument(testFile, QUrl(), mime), Okular::Document::OpenSuccess);
94 +diff --git a/generators/comicbook/CMakeLists.txt b/generators/comicbook/CMakeLists.txt
95 +index a0e7569a2..91bcc6ec7 100644
96 +--- a/generators/comicbook/CMakeLists.txt
97 ++++ b/generators/comicbook/CMakeLists.txt
98 +@@ -25,13 +25,9 @@ if (KArchive_HAVE_LZMA)
99 + target_compile_definitions(okular_comicbook PRIVATE -DWITH_K7ZIP=1)
100 + endif()
101 +
102 +-########### autotests ###############
103 +-
104 +-add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
105 +-ecm_add_test(autotests/comicbooktest.cpp
106 +- TEST_NAME "comicbooktest"
107 +- LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore okular_comicbook
108 +-)
109 ++if(BUILD_TESTING)
110 ++ add_subdirectory(autotests)
111 ++endif()
112 +
113 + ########### install files ###############
114 + install( FILES okularComicbook.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
115 +diff --git a/generators/comicbook/autotests/CMakeLists.txt b/generators/comicbook/autotests/CMakeLists.txt
116 +new file mode 100644
117 +index 000000000..aaacb341a
118 +--- /dev/null
119 ++++ b/generators/comicbook/autotests/CMakeLists.txt
120 +@@ -0,0 +1,6 @@
121 ++add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/../" )
122 ++
123 ++ecm_add_test(comicbooktest.cpp
124 ++ TEST_NAME "comicbooktest"
125 ++ LINK_LIBRARIES Qt5::Test KF5::CoreAddons okularcore okular_comicbook
126 ++)
127 +diff --git a/generators/kimgio/CMakeLists.txt b/generators/kimgio/CMakeLists.txt
128 +index 6919bad1a..765f36c0b 100644
129 +--- a/generators/kimgio/CMakeLists.txt
130 ++++ b/generators/kimgio/CMakeLists.txt
131 +@@ -7,10 +7,7 @@ okular_add_generator(okularGenerator_kimgio generator_kimgio.cpp)
132 + target_link_libraries(okularGenerator_kimgio okularcore KF5::KExiv2 KF5::I18n)
133 +
134 + if(BUILD_TESTING AND BUILD_DESKTOP)
135 +- add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/" )
136 +- set( kimgiotest_SRCS tests/kimgiotest.cpp ${CMAKE_SOURCE_DIR}/part/pagepainter.cpp ${CMAKE_SOURCE_DIR}/part/guiutils.cpp ${CMAKE_SOURCE_DIR}/part/debug_ui.cpp )
137 +- ecm_add_test(${kimgiotest_SRCS} TEST_NAME "kimgiotest" LINK_LIBRARIES okularcore okularpart Qt5::Svg Qt5::Test)
138 +- target_compile_definitions(kimgiotest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_kimgio>")
139 ++ add_subdirectory(tests)
140 + endif()
141 +
142 +
143 +diff --git a/generators/kimgio/tests/CMakeLists.txt b/generators/kimgio/tests/CMakeLists.txt
144 +new file mode 100644
145 +index 000000000..844c9096a
146 +--- /dev/null
147 ++++ b/generators/kimgio/tests/CMakeLists.txt
148 +@@ -0,0 +1,5 @@
149 ++add_definitions( -DKDESRCDIR="${CMAKE_CURRENT_SOURCE_DIR}/../" )
150 ++
151 ++set( kimgiotest_SRCS kimgiotest.cpp ${CMAKE_SOURCE_DIR}/part/pagepainter.cpp ${CMAKE_SOURCE_DIR}/part/guiutils.cpp ${CMAKE_SOURCE_DIR}/part/debug_ui.cpp )
152 ++ecm_add_test(${kimgiotest_SRCS} TEST_NAME "kimgiotest" LINK_LIBRARIES okularcore okularpart Qt5::Svg Qt5::Test)
153 ++target_compile_definitions(kimgiotest PRIVATE -DGENERATOR_PATH="$<TARGET_FILE:okularGenerator_kimgio>")
154 +diff --git a/generators/kimgio/tests/kimgiotest.cpp b/generators/kimgio/tests/kimgiotest.cpp
155 +index d521a5a7b..259bb4894 100644
156 +--- a/generators/kimgio/tests/kimgiotest.cpp
157 ++++ b/generators/kimgio/tests/kimgiotest.cpp
158 +@@ -4,7 +4,7 @@
159 + SPDX-License-Identifier: GPL-2.0-or-later
160 + */
161 +
162 +-#include "../../settings_core.h"
163 ++#include "../../../settings_core.h"
164 + #include "../generator_kimgio.h"
165 +
166 + #include <core/observer.h>
167 +--
168 +2.33.0
169 +
170
171 diff --git a/kde-apps/okular/okular-9999.ebuild b/kde-apps/okular/okular-9999.ebuild
172 index 002e928a02..a91feea7d6 100644
173 --- a/kde-apps/okular/okular-9999.ebuild
174 +++ b/kde-apps/okular/okular-9999.ebuild
175 @@ -68,7 +68,7 @@ RDEPEND="${DEPEND}
176 "
177
178 PATCHES=(
179 - "${FILESDIR}/${PN}-20.11.90-tests.patch" # bug 734138
180 + "${FILESDIR}/${PN}-21.11.80-tests.patch" # bug 734138
181 "${FILESDIR}/${PN}-20.08.2-hide-mobile-app.patch" # avoid same-name entry
182 )