1 |
commit: 06c1ac768322d28e4e8ee00c81fe6c296c9a9459 |
2 |
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
3 |
AuthorDate: Fri Nov 10 10:40:07 2017 +0000 |
4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
5 |
CommitDate: Fri Nov 10 10:40:24 2017 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06c1ac76 |
7 |
|
8 |
kde-apps/okular: Fix build w/ cmake-3.10 |
9 |
|
10 |
Package-Manager: Portage-2.3.8, Repoman-2.3.4 |
11 |
|
12 |
.../okular/files/okular-17.08.3-cmake-3.10.patch | 45 ++++++++++++++++++++++ |
13 |
kde-apps/okular/okular-17.08.3.ebuild | 2 + |
14 |
2 files changed, 47 insertions(+) |
15 |
|
16 |
diff --git a/kde-apps/okular/files/okular-17.08.3-cmake-3.10.patch b/kde-apps/okular/files/okular-17.08.3-cmake-3.10.patch |
17 |
new file mode 100644 |
18 |
index 00000000000..33c56a6e7ec |
19 |
--- /dev/null |
20 |
+++ b/kde-apps/okular/files/okular-17.08.3-cmake-3.10.patch |
21 |
@@ -0,0 +1,45 @@ |
22 |
+From f777e2a9241c4f384f60c467e226eee85fb5bc98 Mon Sep 17 00:00:00 2001 |
23 |
+From: Henrik Fehlauer <rkflx@×××××.net> |
24 |
+Date: Sat, 4 Nov 2017 00:22:09 +0100 |
25 |
+Subject: Fix CMake Error in generators/spectre/CMakeLists.txt |
26 |
+ |
27 |
+Summary: |
28 |
+When porting from `add_library` to `okular_add_generator`, 2f9246ae42ce |
29 |
+missed to remove `MODULE` for spectre, which is already implicitly added |
30 |
+as can be seen [here](https://phabricator.kde.org/source/kcoreaddons/browse/master/KF5CoreAddonsMacros.cmake;83623a46c9862ee37535de93427dec0b0c55e24d$139). |
31 |
+ |
32 |
+This causes the upcoming CMake 3.10 to print the error `Cannot find |
33 |
+source file`, which can be fixed by removing the superfluous `MODULE`. |
34 |
+ |
35 |
+BUG: 386176 |
36 |
+ |
37 |
+Test Plan: |
38 |
+No error shown anymore with CMake 3.10.0-rc4. Still works with CMake |
39 |
+3.5.1. |
40 |
+ |
41 |
+Reviewers: #okular, ngraham |
42 |
+ |
43 |
+Reviewed By: ngraham |
44 |
+ |
45 |
+Tags: #okular |
46 |
+ |
47 |
+Differential Revision: https://phabricator.kde.org/D8612 |
48 |
+--- |
49 |
+ generators/spectre/CMakeLists.txt | 2 +- |
50 |
+ 1 file changed, 1 insertion(+), 1 deletion(-) |
51 |
+ |
52 |
+diff --git a/generators/spectre/CMakeLists.txt b/generators/spectre/CMakeLists.txt |
53 |
+index d808c36..5d6927d 100644 |
54 |
+--- a/generators/spectre/CMakeLists.txt |
55 |
++++ b/generators/spectre/CMakeLists.txt |
56 |
+@@ -24,7 +24,7 @@ ki18n_wrap_ui(okularGenerator_ghostview_SRCS |
57 |
+ kconfig_add_kcfg_files(okularGenerator_ghostview_SRCS conf/gssettings.kcfgc ) |
58 |
+ |
59 |
+ |
60 |
+-okular_add_generator(okularGenerator_ghostview MODULE ${okularGenerator_ghostview_SRCS}) |
61 |
++okular_add_generator(okularGenerator_ghostview ${okularGenerator_ghostview_SRCS}) |
62 |
+ |
63 |
+ target_link_libraries(okularGenerator_ghostview okularcore ${LIBSPECTRE_LIBRARY} KF5::I18n Qt5::Xml) |
64 |
+ |
65 |
+-- |
66 |
+cgit v0.11.2 |
67 |
|
68 |
diff --git a/kde-apps/okular/okular-17.08.3.ebuild b/kde-apps/okular/okular-17.08.3.ebuild |
69 |
index 283bc3eb368..d5f22e6d85a 100644 |
70 |
--- a/kde-apps/okular/okular-17.08.3.ebuild |
71 |
+++ b/kde-apps/okular/okular-17.08.3.ebuild |
72 |
@@ -64,6 +64,8 @@ RDEPEND="${DEPEND} |
73 |
# bug 603116 |
74 |
RESTRICT+=" test" |
75 |
|
76 |
+PATCHES=( "${FILESDIR}/${P}-cmake-3.10.patch" ) |
77 |
+ |
78 |
src_prepare() { |
79 |
kde5_src_prepare |
80 |
use mobile || cmake_comment_add_subdirectory mobile |