| 1 |
commit: bf90e71df4e003dada5464a941a20f4c70a4c755 |
| 2 |
Author: Michael Palimaka <kensington <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Wed Sep 24 16:40:19 2014 +0000 |
| 4 |
Commit: Michael Palimaka <kensington <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Wed Sep 24 16:43:21 2014 +0000 |
| 6 |
URL: http://sources.gentoo.org/gitweb/?p=proj/qa-scripts.git;a=commit;h=bf90e71d |
| 7 |
|
| 8 |
depcheck: ensure that missing RDEPEND is also reported during a virtual check |
| 9 |
|
| 10 |
It was failing due to a difference in return code handling: |
| 11 |
a() { |
| 12 |
local x=$(false) |
| 13 |
echo $? |
| 14 |
} |
| 15 |
|
| 16 |
b() { |
| 17 |
local x |
| 18 |
x=$(false) |
| 19 |
echo $? |
| 20 |
} |
| 21 |
a |
| 22 |
b |
| 23 |
|
| 24 |
returning: |
| 25 |
0 |
| 26 |
1 |
| 27 |
|
| 28 |
--- |
| 29 |
depcheck | 3 ++- |
| 30 |
1 file changed, 2 insertions(+), 1 deletion(-) |
| 31 |
|
| 32 |
diff --git a/depcheck b/depcheck |
| 33 |
index dae0cd9..93abeb1 100755 |
| 34 |
--- a/depcheck |
| 35 |
+++ b/depcheck |
| 36 |
@@ -58,7 +58,8 @@ virtualcheck() { |
| 37 |
for virtual in $(qdepends --nocolor --name-only --${1} --query ${libowner_pn} | grep ^virtual/) |
| 38 |
do |
| 39 |
debug Checking if ${virtual} is in dependencies |
| 40 |
- local isvirtualdep=$(qdepends --${1} ${atom} | grep ${virtual}) |
| 41 |
+ local isvirtualdep |
| 42 |
+ isvirtualdep=$(qdepends --${1} ${atom} | grep ${virtual}) |
| 43 |
|
| 44 |
if [ $? -eq 0 ]; then |
| 45 |
used_virtuals+=( ${virtual} ) |
Archives