1 |
commit: 4ba1b2e31f26bb8b31890fc3ce6eb7ef0aaf8b9b |
2 |
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
3 |
AuthorDate: Sat Sep 8 12:50:51 2018 +0000 |
4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
5 |
CommitDate: Sat Sep 8 12:51:34 2018 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ba1b2e3 |
7 |
|
8 |
kde-apps/gwenview: Add missing patch |
9 |
|
10 |
Package-Manager: Portage-2.3.49, Repoman-2.3.10 |
11 |
|
12 |
.../gwenview-18.07.90-activities-optional.patch | 160 +++++++++++++++++++++ |
13 |
1 file changed, 160 insertions(+) |
14 |
|
15 |
diff --git a/kde-apps/gwenview/files/gwenview-18.07.90-activities-optional.patch b/kde-apps/gwenview/files/gwenview-18.07.90-activities-optional.patch |
16 |
new file mode 100644 |
17 |
index 00000000000..bf66688a6b9 |
18 |
--- /dev/null |
19 |
+++ b/kde-apps/gwenview/files/gwenview-18.07.90-activities-optional.patch |
20 |
@@ -0,0 +1,160 @@ |
21 |
+From a00eecc78507f48843f719f32e80ae8805a34c15 Mon Sep 17 00:00:00 2001 |
22 |
+From: Alexander Volkov <a.volkov@×××××××××.ru> |
23 |
+Date: Tue, 7 Aug 2018 23:59:15 +0300 |
24 |
+Subject: Make dependency on KActivities optional |
25 |
+ |
26 |
+Reviewers: #gwenview, rkflx |
27 |
+ |
28 |
+Reviewed By: #gwenview, rkflx |
29 |
+ |
30 |
+Subscribers: asturmlechner, rkflx |
31 |
+ |
32 |
+Differential Revision: https://phabricator.kde.org/D14512 |
33 |
+--- |
34 |
+ CMakeLists.txt | 4 +++- |
35 |
+ app/CMakeLists.txt | 5 ++++- |
36 |
+ app/viewmainpage.cpp | 19 ++++++++++++++++--- |
37 |
+ config-gwenview.h.cmake | 1 + |
38 |
+ 4 files changed, 24 insertions(+), 5 deletions(-) |
39 |
+ |
40 |
+diff --git a/CMakeLists.txt b/CMakeLists.txt |
41 |
+index 6e3e412..810813a 100644 |
42 |
+--- a/CMakeLists.txt |
43 |
++++ b/CMakeLists.txt |
44 |
+@@ -71,7 +71,6 @@ add_definitions(-DPHONON_LIB_SONAME=\"${PHONON_LIB_SONAME}\") |
45 |
+ |
46 |
+ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS |
47 |
+ KIO |
48 |
+- Activities |
49 |
+ ItemModels |
50 |
+ I18n |
51 |
+ DocTools |
52 |
+@@ -80,6 +79,9 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS |
53 |
+ IconThemes |
54 |
+ Notifications |
55 |
+ ) |
56 |
++find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS |
57 |
++ Activities |
58 |
++) |
59 |
+ |
60 |
+ ## Dependencies |
61 |
+ find_package(JPEG) |
62 |
+diff --git a/app/CMakeLists.txt b/app/CMakeLists.txt |
63 |
+index 5fe34d6..0d24360 100644 |
64 |
+--- a/app/CMakeLists.txt |
65 |
++++ b/app/CMakeLists.txt |
66 |
+@@ -78,11 +78,14 @@ add_executable(gwenview ${gwenview_SRCS}) |
67 |
+ |
68 |
+ target_link_libraries(gwenview |
69 |
+ KF5::ItemModels |
70 |
+- KF5::Activities |
71 |
+ KF5::Notifications |
72 |
+ gwenviewlib |
73 |
+ ) |
74 |
+ |
75 |
++if (KF5Activities_FOUND) |
76 |
++ target_link_libraries(gwenview KF5::Activities) |
77 |
++endif() |
78 |
++ |
79 |
+ target_link_libraries(gwenview LINK_INTERFACE_LIBRARIES KF5::KIOCore Qt5::Core) |
80 |
+ |
81 |
+ if (KF5Kipi_FOUND) |
82 |
+diff --git a/app/viewmainpage.cpp b/app/viewmainpage.cpp |
83 |
+index fa06e80..480d3c2 100644 |
84 |
+--- a/app/viewmainpage.cpp |
85 |
++++ b/app/viewmainpage.cpp |
86 |
+@@ -18,6 +18,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
87 |
+ |
88 |
+ */ |
89 |
+ #include "viewmainpage.h" |
90 |
++#include "config-gwenview.h" |
91 |
+ |
92 |
+ // Qt |
93 |
+ #include <QCheckBox> |
94 |
+@@ -35,8 +36,10 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
95 |
+ #include <KMessageBox> |
96 |
+ #include <KModelIndexProxyMapper> |
97 |
+ #include <KToggleAction> |
98 |
+-#include <KActivities/ResourceInstance> |
99 |
+ #include <KSqueezedTextLabel> |
100 |
++#ifdef KF5Activities_FOUND |
101 |
++#include <KActivities/ResourceInstance> |
102 |
++#endif |
103 |
+ |
104 |
+ // Local |
105 |
+ #include "fileoperations.h" |
106 |
+@@ -132,7 +135,9 @@ struct ViewMainPagePrivate |
107 |
+ // Activity Resource events reporting needs to be above KPart, |
108 |
+ // in the shell itself, to avoid problems with other MDI applications |
109 |
+ // that use this KPart |
110 |
++#ifdef KF5Activities_FOUND |
111 |
+ QHash<DocumentView*, KActivities::ResourceInstance*> mActivityResources; |
112 |
++#endif |
113 |
+ |
114 |
+ bool mCompareMode; |
115 |
+ ZoomMode::Enum mZoomMode; |
116 |
+@@ -250,7 +255,9 @@ struct ViewMainPagePrivate |
117 |
+ QObject::connect(view, &DocumentView::videoFinished, mSlideShow, &SlideShow::resumeAndGoToNextUrl); |
118 |
+ |
119 |
+ mDocumentViews << view; |
120 |
++#ifdef KF5Activities_FOUND |
121 |
+ mActivityResources.insert(view, new KActivities::ResourceInstance(q->window()->winId(), view)); |
122 |
++#endif |
123 |
+ |
124 |
+ return view; |
125 |
+ } |
126 |
+@@ -269,7 +276,9 @@ struct ViewMainPagePrivate |
127 |
+ QObject::disconnect(view, nullptr, mSlideShow, nullptr); |
128 |
+ |
129 |
+ mDocumentViews.removeOne(view); |
130 |
++#ifdef KF5Activities_FOUND |
131 |
+ mActivityResources.remove(view); |
132 |
++#endif |
133 |
+ mDocumentViewContainer->deleteView(view); |
134 |
+ } |
135 |
+ |
136 |
+@@ -344,8 +353,10 @@ struct ViewMainPagePrivate |
137 |
+ } |
138 |
+ if (oldView) { |
139 |
+ oldView->setCurrent(false); |
140 |
++#ifdef KF5Activities_FOUND |
141 |
+ Q_ASSERT(mActivityResources.contains(oldView)); |
142 |
+ mActivityResources.value(oldView)->notifyFocusedOut(); |
143 |
++#endif |
144 |
+ } |
145 |
+ view->setCurrent(true); |
146 |
+ mDocumentViewController->setView(view); |
147 |
+@@ -358,10 +369,10 @@ struct ViewMainPagePrivate |
148 |
+ // *before* listing /foo (because it matters less to the user) |
149 |
+ mThumbnailBar->selectionModel()->setCurrentIndex(index, QItemSelectionModel::Current); |
150 |
+ } |
151 |
+- |
152 |
++#ifdef KF5Activities_FOUND |
153 |
+ Q_ASSERT(mActivityResources.contains(view)); |
154 |
+ mActivityResources.value(view)->notifyFocusedIn(); |
155 |
+- |
156 |
++#endif |
157 |
+ QObject::connect(view, &DocumentView::currentToolChanged, |
158 |
+ q, &ViewMainPage::updateFocus); |
159 |
+ } |
160 |
+@@ -701,7 +712,9 @@ void ViewMainPage::openUrls(const QList<QUrl>& allUrls, const QUrl ¤tUrl) |
161 |
+ DocumentView* view = it.value(); |
162 |
+ DocumentView::Setup savedSetup = d->mDocumentViewContainer->savedSetup(url); |
163 |
+ view->openUrl(url, d->mZoomMode == ZoomMode::Individual && savedSetup.valid ? savedSetup : setup); |
164 |
++#ifdef KF5Activities_FOUND |
165 |
+ d->mActivityResources.value(view)->setUri(url); |
166 |
++#endif |
167 |
+ } |
168 |
+ |
169 |
+ // Init views |
170 |
+diff --git a/config-gwenview.h.cmake b/config-gwenview.h.cmake |
171 |
+index 29a5a60..369442a 100644 |
172 |
+--- a/config-gwenview.h.cmake |
173 |
++++ b/config-gwenview.h.cmake |
174 |
+@@ -6,3 +6,4 @@ |
175 |
+ #cmakedefine HAVE_X11 ${HAVE_X11} |
176 |
+ #cmakedefine HAVE_FITS ${HAVE_FITS} |
177 |
+ #cmakedefine HAVE_QTDBUS ${HAVE_QTDBUS} |
178 |
++#cmakedefine KF5Activities_FOUND 1 |
179 |
+-- |
180 |
+cgit v0.11.2 |