1 |
commit: b027c1e8a3a25ab1f1a5646ccb0e751dcb41271e |
2 |
Author: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org> |
3 |
AuthorDate: Sat Aug 27 11:06:50 2016 +0000 |
4 |
Commit: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org> |
5 |
CommitDate: Sat Aug 27 11:06:59 2016 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b027c1e8 |
7 |
|
8 |
media-libs/imlib: fix testsuite underlinking, bug #367645 |
9 |
|
10 |
Fix by Greg Turner adds required libraries to t-load test. |
11 |
While at it dropped LDFLAGS leak into imlib.pc. |
12 |
|
13 |
Reported-by: Diego Elio Pettenò |
14 |
Bug: https://bugs.gentoo.org/367645 |
15 |
|
16 |
Package-Manager: portage-2.3.0 |
17 |
|
18 |
.../imlib/files/imlib-1.9.15-no-LDFLAGS-in-pc.patch | 16 ++++++++++++++++ |
19 |
.../imlib/files/imlib-1.9.15-underlinking-test.patch | 10 ++++++++++ |
20 |
media-libs/imlib/imlib-1.9.15-r4.ebuild | 4 +++- |
21 |
3 files changed, 29 insertions(+), 1 deletion(-) |
22 |
|
23 |
diff --git a/media-libs/imlib/files/imlib-1.9.15-no-LDFLAGS-in-pc.patch b/media-libs/imlib/files/imlib-1.9.15-no-LDFLAGS-in-pc.patch |
24 |
new file mode 100644 |
25 |
index 00000000..9a1ade9 |
26 |
--- /dev/null |
27 |
+++ b/media-libs/imlib/files/imlib-1.9.15-no-LDFLAGS-in-pc.patch |
28 |
@@ -0,0 +1,16 @@ |
29 |
+Detected by Gentoo QA check: |
30 |
+ |
31 |
+ * QA Notice: pkg-config files with wrong LDFLAGS detected: |
32 |
+ * /usr/lib32/pkgconfig/imlib.pc:Libs: -L${libdir} -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -lImlib -ljpeg -ltiff -lgif -lpng -lz -lm -lXext -lSM -lICE -lXext -lX11 |
33 |
+ * /usr/lib64/pkgconfig/imlib.pc:Libs: -L${libdir} -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -lImlib -ljpeg -ltiff -lgif -lpng -lz -lm -lXext -lSM -lICE -lXext -lX11 |
34 |
+diff --git a/imlib.pc.in b/imlib.pc.in |
35 |
+index 0a6f276..dc1ef7d 100644 |
36 |
+--- a/imlib.pc.in |
37 |
++++ b/imlib.pc.in |
38 |
+@@ -9,5 +9,5 @@ Name: Imlib |
39 |
+ Description: An image loading and rendering library for X11R6 |
40 |
+ Version: @VERSION@ |
41 |
+ Requires: |
42 |
+-Libs: -L${libdir} @LDFLAGS@ -lImlib @SUPPORT_LIBS@ @X_LIBS@ @X_PRE_LIBS@ -lXext -lX11 @X_EXTRA_LIBS@ |
43 |
++Libs: -L${libdir} -lImlib @SUPPORT_LIBS@ @X_LIBS@ @X_PRE_LIBS@ -lXext -lX11 @X_EXTRA_LIBS@ |
44 |
+ Cflags: -I${includedir} @X_CFLAGS@ |
45 |
|
46 |
diff --git a/media-libs/imlib/files/imlib-1.9.15-underlinking-test.patch b/media-libs/imlib/files/imlib-1.9.15-underlinking-test.patch |
47 |
new file mode 100644 |
48 |
index 00000000..aa52557 |
49 |
--- /dev/null |
50 |
+++ b/media-libs/imlib/files/imlib-1.9.15-underlinking-test.patch |
51 |
@@ -0,0 +1,10 @@ |
52 |
+https://bugs.gentoo.org/show_bug.cgi?id=367645 |
53 |
+by Greg Turner |
54 |
+diff -urpN imlib-1.9.15.orig/Imlib/Makefile.am imlib-1.9.15/Imlib/Makefile.am |
55 |
+--- imlib-1.9.15.orig/Imlib/Makefile.am 2004-09-20 17:22:59.000000000 -0700 |
56 |
++++ imlib-1.9.15/Imlib/Makefile.am 2013-10-08 02:48:53.772197627 -0700 |
57 |
+@@ -44,3 +44,3 @@ INCLUDES = -I. -I$(srcdir) -I.. -I$(srcd |
58 |
+ check_PROGRAMS = t-load |
59 |
+ |
60 |
+-t_load_LDADD = libImlib.la |
61 |
++t_load_LDADD = libImlib.la $(X_PRE_LIBS) $(X_LIBS) -lX11 $(X_EXTRA_LIBS) |
62 |
|
63 |
diff --git a/media-libs/imlib/imlib-1.9.15-r4.ebuild b/media-libs/imlib/imlib-1.9.15-r4.ebuild |
64 |
index d85d7b6..99e4d3d 100644 |
65 |
--- a/media-libs/imlib/imlib-1.9.15-r4.ebuild |
66 |
+++ b/media-libs/imlib/imlib-1.9.15-r4.ebuild |
67 |
@@ -1,4 +1,4 @@ |
68 |
-# Copyright 1999-2015 Gentoo Foundation |
69 |
+# Copyright 1999-2016 Gentoo Foundation |
70 |
# Distributed under the terms of the GNU General Public License v2 |
71 |
# $Id$ |
72 |
|
73 |
@@ -39,6 +39,8 @@ src_prepare() { |
74 |
epatch "${FILESDIR}"/${P}-fix-rendering.patch #197489 |
75 |
epatch "${FILESDIR}"/${P}-asneeded.patch #207638 |
76 |
epatch "${FILESDIR}"/${P}-libpng15.patch #357167 |
77 |
+ epatch "${FILESDIR}"/${P}-underlinking-test.patch #367645 |
78 |
+ epatch "${FILESDIR}"/${P}-no-LDFLAGS-in-pc.patch |
79 |
|
80 |
mkdir m4 && cp "${WORKDIR}"/gtk-1-for-imlib.m4 m4 |