| 1 |
commit: f5a89a542d5355496d0ac1dde6faeda00c5eaa9c |
| 2 |
Author: Yuan Liao <liaoyuan <AT> gmail <DOT> com> |
| 3 |
AuthorDate: Mon Jun 14 20:22:34 2021 +0000 |
| 4 |
Commit: Andrew Ammerlaan <andrewammerlaan <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Tue Jun 15 06:56:16 2021 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=f5a89a54 |
| 7 |
|
| 8 |
scripts/setup-and-run-repoman.sh: use 'sort -V' to get latest tag |
| 9 |
|
| 10 |
Without the -V flag to enable version sort, 'sort' can falsely identify |
| 11 |
a version string like 3.0.9 to be greater than 3.0.10. This can be |
| 12 |
shown by running 'git tag | grep portage | sort -u' in the Portage Git |
| 13 |
tree. This issue is not so prominent for repoman yet because the latest |
| 14 |
version of repoman as of now is 3.0.3, but it will surface when repoman |
| 15 |
3.0.10 is released. |
| 16 |
|
| 17 |
Signed-off-by: Yuan Liao <liaoyuan <AT> gmail.com> |
| 18 |
Closes: https://github.com/gentoo/sci/pull/1094 |
| 19 |
Signed-off-by: Andrew Ammerlaan <andrewammerlaan <AT> gentoo.org> |
| 20 |
|
| 21 |
scripts/setup-and-run-repoman.sh | 2 +- |
| 22 |
1 file changed, 1 insertion(+), 1 deletion(-) |
| 23 |
|
| 24 |
diff --git a/scripts/setup-and-run-repoman.sh b/scripts/setup-and-run-repoman.sh |
| 25 |
index f9e45a9cf..471a05181 100755 |
| 26 |
--- a/scripts/setup-and-run-repoman.sh |
| 27 |
+++ b/scripts/setup-and-run-repoman.sh |
| 28 |
@@ -16,7 +16,7 @@ git clone https://github.com/gentoo/portage.git |
| 29 |
cd portage |
| 30 |
|
| 31 |
# Get all versions, and read into array |
| 32 |
-mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -u ) |
| 33 |
+mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -uV ) |
| 34 |
|
| 35 |
# Select latests version (last element in array) |
| 36 |
RM_VERS="${RM_VERSIONS[-1]}" |
Archives