Gentoo Archives: gentoo-commits

From: Mike Pagano <mpagano@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/linux-patches:5.15 commit in: /
Date: Wed, 23 Feb 2022 12:54:20
Message-Id: 1645620836.3af55a99bc068ceb8986cd45d80b607ce6d6b5d5.mpagano@gentoo
1 commit: 3af55a99bc068ceb8986cd45d80b607ce6d6b5d5
2 Author: Mike Pagano <mpagano <AT> gentoo <DOT> org>
3 AuthorDate: Wed Feb 23 12:53:56 2022 +0000
4 Commit: Mike Pagano <mpagano <AT> gentoo <DOT> org>
5 CommitDate: Wed Feb 23 12:53:56 2022 +0000
6 URL: https://gitweb.gentoo.org/proj/linux-patches.git/commit/?id=3af55a99
7
8 Remove redundant patch
9
10 2410_iwlwifi-fix-use-after-free.patch
11
12 Signed-off-by: Mike Pagano <mpagano <AT> gentoo.org>
13
14 0000_README | 4 ----
15 2410_iwlwifi-fix-use-after-free.patch | 37 -----------------------------------
16 2 files changed, 41 deletions(-)
17
18 diff --git a/0000_README b/0000_README
19 index 802c4d2b..d129a8c2 100644
20 --- a/0000_README
21 +++ b/0000_README
22 @@ -155,10 +155,6 @@ Patch: 2000_BT-Check-key-sizes-only-if-Secure-Simple-Pairing-enabled.patch
23 From: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@××××××××.org/raw
24 Desc: Bluetooth: Check key sizes only when Secure Simple Pairing is enabled. See bug #686758
25
26 -Patch: 2410_iwlwifi-fix-use-after-free.patch
27 -From: https://marc.info/?l=linux-wireless&m=164431994900440&w=2
28 -Desc: iwlwifi: fix use-after-free
29 -
30 Patch: 2900_tmp513-Fix-build-issue-by-selecting-CONFIG_REG.patch
31 From: https://bugs.gentoo.org/710790
32 Desc: tmp513 requies REGMAP_I2C to build. Select it by default in Kconfig. See bug #710790. Thanks to Phil Stracchino
33
34 diff --git a/2410_iwlwifi-fix-use-after-free.patch b/2410_iwlwifi-fix-use-after-free.patch
35 deleted file mode 100644
36 index 4c94467b..00000000
37 --- a/2410_iwlwifi-fix-use-after-free.patch
38 +++ /dev/null
39 @@ -1,37 +0,0 @@
40 -If no firmware was present at all (or, presumably, all of the
41 -firmware files failed to parse), we end up unbinding by calling
42 -device_release_driver(), which calls remove(), which then in
43 -iwlwifi calls iwl_drv_stop(), freeing the 'drv' struct. However
44 -the new code I added will still erroneously access it after it
45 -was freed.
46 -
47 -Set 'failure=false' in this case to avoid the access, all data
48 -was already freed anyway.
49 -
50 -Cc: stable@×××××××××××.org
51 -Reported-by: Stefan Agner <stefan@×××××.ch>
52 -Reported-by: Wolfgang Walter <linux@××××.de>
53 -Reported-by: Jason Self <jason@××××××××.net>
54 -Reported-by: Dominik Behr <dominik@×××××××××××.com>
55 -Reported-by: Marek Marczykowski-Górecki <marmarek@××××××××××××××××××.com>
56 -Fixes: ab07506b0454 ("iwlwifi: fix leaks/bad data after failed firmware load")
57 -Signed-off-by: Johannes Berg <johannes.berg@×××××.com>
58 ----
59 - drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 ++
60 - 1 file changed, 2 insertions(+)
61 -
62 -diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
63 -index 83e3b731ad29..6651e78b39ec 100644
64 ---- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
65 -+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
66 -@@ -1707,6 +1707,8 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
67 - out_unbind:
68 - complete(&drv->request_firmware_complete);
69 - device_release_driver(drv->trans->dev);
70 -+ /* drv has just been freed by the release */
71 -+ failure = false;
72 - free:
73 - if (failure)
74 - iwl_dealloc_ucode(drv);
75 ---
76 -2.34.1