Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/
Date: Sun, 31 Jul 2022 06:16:39
Message-Id: 1659248188.b54a869bfc0a823a5ce5db453847ee883bc34896.sam@gentoo
1 commit: b54a869bfc0a823a5ce5db453847ee883bc34896
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Sun Jul 31 05:09:32 2022 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Sun Jul 31 06:16:28 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b54a869b
7
8 chromium-2.eclass: drop unnecessary 'shopt -s extglob'
9
10 We don't need a subshell because of how is-flagq works.
11
12 Noticed as a result of fallout from the bash change
13 which led to us noticing 5e9a3926fd3e0e573f529fd6aefebba53e082f4a.
14
15 Thanks-to: Ionen Wolkens <ionen <AT> gentoo.org>
16 Thanks-to: Kerin Millar <kfm <AT> plushkava.net>
17 Signed-off-by: Sam James <sam <AT> gentoo.org>
18
19 eclass/chromium-2.eclass | 4 ++--
20 1 file changed, 2 insertions(+), 2 deletions(-)
21
22 diff --git a/eclass/chromium-2.eclass b/eclass/chromium-2.eclass
23 index bf509d8ff0f8..cd4495767e58 100644
24 --- a/eclass/chromium-2.eclass
25 +++ b/eclass/chromium-2.eclass
26 @@ -1,4 +1,4 @@
27 -# Copyright 1999-2021 Gentoo Authors
28 +# Copyright 1999-2022 Gentoo Authors
29 # Distributed under the terms of the GNU General Public License v2
30
31 # @ECLASS: chromium-2.eclass
32 @@ -122,7 +122,7 @@ chromium_pkg_die() {
33 fi
34
35 # Prevent user problems like bug #348235.
36 - if ( shopt -s extglob; is-flagq '-g?(gdb)?([1-9])' ); then
37 + if is-flagq '-g?(gdb)?([1-9])'; then
38 ewarn
39 ewarn "You have enabled debug info (i.e. -g or -ggdb in your CFLAGS/CXXFLAGS)."
40 ewarn "This produces very large build files causes the linker to consume large"