Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/
Date: Wed, 31 Mar 2021 05:35:15
Message-Id: 1617168841.8fda71b2c9d8ac9f4f8529f6b3ebdceeb025908b.sam@gentoo
1 commit: 8fda71b2c9d8ac9f4f8529f6b3ebdceeb025908b
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Sat Mar 27 21:24:48 2021 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Wed Mar 31 05:34:01 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8fda71b2
7
8 autotools.eclass: consistent references to bugs in comments
9
10 Signed-off-by: Sam James <sam <AT> gentoo.org>
11
12 eclass/autotools.eclass | 18 +++++++++---------
13 1 file changed, 9 insertions(+), 9 deletions(-)
14
15 diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
16 index af5cd3d9a20..0ddd344b76e 100644
17 --- a/eclass/autotools.eclass
18 +++ b/eclass/autotools.eclass
19 @@ -78,7 +78,7 @@ if [[ -n ${WANT_AUTOMAKE} ]]; then
20 case ${WANT_AUTOMAKE} in
21 # Even if the package doesn't use automake, we still need to depend
22 # on it because we run aclocal to process m4 macros. This matches
23 - # the autoreconf tool, so this requirement is correct. #401605
24 + # the autoreconf tool, so this requirement is correct, bug #401605.
25 none) ;;
26 latest)
27 # Use SLOT deps if we can. For EAPI=0, we get pretty close.
28 @@ -188,13 +188,13 @@ unset _automake_atom _autoconf_atom
29 eautoreconf() {
30 local x g
31
32 - # Subdirs often share a common build dir #529404. If so, we can't safely
33 + # Subdirs often share a common build dir, bug #529404. If so, we can't safely
34 # run in parallel because many tools clobber the content in there. Libtool
35 # and automake both `rm && cp` while aclocal reads the output. We might be
36 # able to handle this if we split the steps and grab locks on the dirs the
37 # tools actually write to. Then we'd run all the common tools that use
38 # those inputs. Doing this in bash does not scale easily.
39 - # If we do re-enable parallel support, make sure #426512 is handled.
40 + # If we do re-enable parallel support, make sure bug #426512 is handled.
41 if [[ -z ${AT_NO_RECURSIVE} ]] ; then
42 # Take care of subdirs
43 for x in $(autotools_check_macro_val AC_CONFIG_SUBDIRS) ; do
44 @@ -300,8 +300,8 @@ eaclocal_amflags() {
45 [[ -e ${amflags_file} ]] || continue
46 # setup the env in case the pkg does something crazy
47 # in their ACLOCAL_AMFLAGS. like run a shell script
48 - # which turns around and runs autotools. #365401
49 - # or split across multiple lines. #383525
50 + # which turns around and runs autotools (bug #365401)
51 + # or split across multiple lines (bug #383525)
52 autotools_env_setup
53 aclocal_opts=$(sed -n \
54 "/^ACLOCAL_AMFLAGS[[:space:]]*=/{ \
55 @@ -323,7 +323,7 @@ eaclocal_amflags() {
56 # specified parametes. The name of the tool run is the same of the function
57 # without e prefix.
58 # They also force installing the support files for safety.
59 -# Respects AT_M4DIR for additional directories to search for macro's.
60 +# Respects AT_M4DIR for additional directories to search for macros.
61 eaclocal() {
62 [[ ! -f aclocal.m4 || -n $(grep -e 'generated.*by aclocal' aclocal.m4) ]] && \
63 autotools_run_tool --at-m4flags aclocal "$@" $(eaclocal_amflags)
64 @@ -372,7 +372,7 @@ eautoconf() {
65 fi
66
67 # Install config.guess and config.sub which are required by many macros
68 - # in Autoconf >=2.70.
69 + # in autoconf >=2.70.
70 local _gnuconfig
71 case ${EAPI:-0} in
72 0|1|2|3|4|5|6)
73 @@ -430,7 +430,7 @@ eautomake() {
74 || extra_opts+=( --foreign )
75
76 # Older versions of automake do not support --force-missing. But we want
77 - # to use this whenever possible to update random bundled files #133489.
78 + # to use this whenever possible to update random bundled files, bug #133489.
79 case $(_automake_version) in
80 1.4|1.4[.-]*) ;;
81 *) extra_opts+=( --force-missing ) ;;
82 @@ -534,7 +534,7 @@ autotools_run_tool() {
83
84 autotools_env_setup
85
86 - # Allow people to pass in full paths. #549268
87 + # Allow people to pass in full paths, bug #549268
88 local STDERR_TARGET="${T}/${1##*/}.out"
89 # most of the time, there will only be one run, but if there are
90 # more, make sure we get unique log filenames