Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/qt:master commit in: dev-qt/qtcore/, dev-qt/qtcore/files/
Date: Mon, 23 Sep 2019 18:36:40
Message-Id: 1569263226.afbfb79dbd88738e4299f3a20e1622b886dcd9da.asturm@gentoo
1 commit: afbfb79dbd88738e4299f3a20e1622b886dcd9da
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Mon Sep 23 18:27:06 2019 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Mon Sep 23 18:27:06 2019 +0000
6 URL: https://gitweb.gentoo.org/proj/qt.git/commit/?id=afbfb79d
7
8 dev-qt/qtcore: Fix hardcoded libdir path in some *.cmake configs
9
10 Thanks-to: Manuel Nickschas <sputnick <AT> quassel-irc.org>
11 Closes: https://bugs.gentoo.org/691462
12 Package-Manager: Portage-2.3.76, Repoman-2.3.17
13 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
14
15 .../qtcore-5.13.1-Qt5BasicConfig-fix-libdir.patch | 38 ++++++++++++++++++++++
16 dev-qt/qtcore/qtcore-5.13.1.ebuild | 4 +++
17 2 files changed, 42 insertions(+)
18
19 diff --git a/dev-qt/qtcore/files/qtcore-5.13.1-Qt5BasicConfig-fix-libdir.patch b/dev-qt/qtcore/files/qtcore-5.13.1-Qt5BasicConfig-fix-libdir.patch
20 new file mode 100644
21 index 00000000..49b936f5
22 --- /dev/null
23 +++ b/dev-qt/qtcore/files/qtcore-5.13.1-Qt5BasicConfig-fix-libdir.patch
24 @@ -0,0 +1,38 @@
25 +From cc32a691936f37eaaec618a71edd62f896009c9d Mon Sep 17 00:00:00 2001
26 +From: Joerg Bornemann <joerg.bornemann@××.io>
27 +Date: Fri, 6 Sep 2019 10:54:44 +0200
28 +Subject: [PATCH] Fix CMake config files for -libdir different from "lib"
29 +
30 +When Qt was configured with -libdir different from "lib", one could not
31 +build with CMake whenever a static lib was pulled in (e.g. uitools).
32 +
33 +Do not hard-code "/lib" but use the correct variable also for static
34 +libraries.
35 +
36 +Fixes: QTBUG-76255
37 +Change-Id: I28c6861752e29e461247628d2b1f8a9ec32f0790
38 +Reviewed-by: Alexandru Croitor <alexandru.croitor@××.io>
39 +Reviewed-by: Fabian Vogt <fabian@×××××××××××.de>
40 +---
41 + mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in | 6 +++++-
42 + 1 file changed, 5 insertions(+), 1 deletion(-)
43 +
44 +diff --git a/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in b/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in
45 +index d4fd057682d..f4a34d6e481 100644
46 +--- a/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in
47 ++++ b/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in
48 +@@ -53,7 +53,11 @@ function(_qt5_$${CMAKE_MODULE_NAME}_process_prl_file prl_file_location Configura
49 + set(_lib_deps)
50 + set(_link_flags)
51 +
52 +- get_filename_component(_qt5_install_libs \"${_qt5$${CMAKE_MODULE_NAME}_install_prefix}/lib\" ABSOLUTE)
53 ++!!IF isEmpty(CMAKE_LIB_DIR_IS_ABSOLUTE)
54 ++ set(_qt5_install_libs \"${_qt5$${CMAKE_MODULE_NAME}_install_prefix}/$${CMAKE_LIB_DIR}\")
55 ++!!ELSE
56 ++ set(_qt5_install_libs \"$${CMAKE_LIB_DIR}\")
57 ++!!ENDIF
58 +
59 + if(EXISTS \"${prl_file_location}\")
60 + file(STRINGS \"${prl_file_location}\" _prl_strings REGEX \"QMAKE_PRL_LIBS_FOR_CMAKE[ \\t]*=\")
61 +--
62 +2.16.3
63
64 diff --git a/dev-qt/qtcore/qtcore-5.13.1.ebuild b/dev-qt/qtcore/qtcore-5.13.1.ebuild
65 index d881786f..28ff5c1c 100644
66 --- a/dev-qt/qtcore/qtcore-5.13.1.ebuild
67 +++ b/dev-qt/qtcore/qtcore-5.13.1.ebuild
68 @@ -43,6 +43,10 @@ QT5_GENTOO_PRIVATE_CONFIG=(
69 !:xml
70 )
71
72 +PATCHES=(
73 + "${FILESDIR}/${P}-Qt5BasicConfig-fix-libdir.patch" # QTBUG-76255, bug #691462
74 +)
75 +
76 src_prepare() {
77 # don't add -O3 to CXXFLAGS, bug 549140
78 sed -i -e '/CONFIG\s*+=/s/optimize_full//' src/corelib/corelib.pro || die