Gentoo Archives: gentoo-commits

From: Zac Medico <zmedico@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/
Date: Sun, 03 Nov 2019 19:46:02
Message-Id: 1572810284.498900e5e51460502d8271f409a4c614a021613b.zmedico@gentoo
1 commit: 498900e5e51460502d8271f409a4c614a021613b
2 Author: William Hubbs <williamh <AT> gentoo <DOT> org>
3 AuthorDate: Sun Oct 27 17:40:07 2019 +0000
4 Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
5 CommitDate: Sun Nov 3 19:44:44 2019 +0000
6 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=498900e5
7
8 install-qa-check.d: remove check that bans libtool files and static libs from /
9
10 Most upstreams and build systems do not make this distinction, so this
11 causes unnecessary hacks in ebuilds.
12
13 Bug: https://bugs.gentoo.org/699252
14 Signed-off-by: William Hubbs <williamh <AT> gentoo.org>
15 Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>
16
17 bin/install-qa-check.d/80libraries | 10 ----------
18 1 file changed, 10 deletions(-)
19
20 diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries
21 index d1d2c4fdd..e59369bf6 100644
22 --- a/bin/install-qa-check.d/80libraries
23 +++ b/bin/install-qa-check.d/80libraries
24 @@ -152,16 +152,6 @@ lib_check() {
25 done
26 [[ ${abort} == "yes" ]] && die "add those ldscripts"
27
28 - # Make sure people don't store libtool files or static libs in /lib
29 - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null)
30 - if [[ -n ${f} ]] ; then
31 - __vecho -ne '\n'
32 - eqawarn "QA Notice: Excessive files found in the / partition"
33 - eqawarn "${f}"
34 - __vecho -ne '\n'
35 - die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*"
36 - fi
37 -
38 # Verify that the libtool files don't contain bogus $D entries.
39 local abort=no gentoo_bug=no always_overflow=no
40 for a in "${ED%/}"/usr/lib*/*.la ; do