Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/kirigami/, kde-frameworks/kirigami/files/
Date: Tue, 23 Nov 2021 14:59:37
Message-Id: 1637679550.47acd0c95ed6d5cae3026303d7c3fcace06406c4.asturm@gentoo
1 commit: 47acd0c95ed6d5cae3026303d7c3fcace06406c4
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Mon Nov 15 14:52:24 2021 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Tue Nov 23 14:59:10 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47acd0c9
7
8 kde-frameworks/kirigami: PageRowGlobalToolBarUI: don't animate opacity
9
10 Upstream commit 67ec2a1873e3d750529043b243043cfd2e2f9ec6
11
12 KDE-bug: https://bugs.kde.org/show_bug.cgi?id=417636
13 Package-Manager: Portage-3.0.28, Repoman-3.0.3
14 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
15
16 ...geRowGlobalToolBarUI-dont-animate-opacity.patch | 56 ++++++++++++++++++++++
17 kde-frameworks/kirigami/kirigami-5.88.0-r1.ebuild | 48 +++++++++++++++++++
18 2 files changed, 104 insertions(+)
19
20 diff --git a/kde-frameworks/kirigami/files/kirigami-5.88.0-PageRowGlobalToolBarUI-dont-animate-opacity.patch b/kde-frameworks/kirigami/files/kirigami-5.88.0-PageRowGlobalToolBarUI-dont-animate-opacity.patch
21 new file mode 100644
22 index 000000000000..85b2a24f5909
23 --- /dev/null
24 +++ b/kde-frameworks/kirigami/files/kirigami-5.88.0-PageRowGlobalToolBarUI-dont-animate-opacity.patch
25 @@ -0,0 +1,56 @@
26 +From 67ec2a1873e3d750529043b243043cfd2e2f9ec6 Mon Sep 17 00:00:00 2001
27 +From: Nate Graham <nate@×××.org>
28 +Date: Wed, 10 Nov 2021 20:44:53 -0700
29 +Subject: [PATCH] PageRowGlobalToolBarUI: don't animate opacity
30 +
31 +Doing so causes flickering in System Settings and KInfoCenter because of
32 +how the titles are rendered. It also doesn't make conceptual sense since
33 +the style of toolbar generally doesn't change so the user would never
34 +actually see the animated opacity change in the first place.
35 +
36 +BUG: 417636
37 +FIXED-IN: 5.89
38 +---
39 + .../globaltoolbar/PageRowGlobalToolBarUI.qml | 13 +++----------
40 + 1 file changed, 3 insertions(+), 10 deletions(-)
41 +
42 +diff --git a/src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml b/src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
43 +index 640ab51e..c536fed7 100644
44 +--- a/src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
45 ++++ b/src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
46 +@@ -106,8 +106,8 @@ Kirigami.AbstractApplicationHeader {
47 + Layout.preferredHeight: -1
48 + property Kirigami.PageRow pageRow: root
49 +
50 +- opacity: layerIsMainRow && active
51 +- enabled: opacity > 0
52 ++ visible: layerIsMainRow && active
53 ++ enabled: visible
54 +
55 + asynchronous: true
56 +
57 +@@ -115,13 +115,6 @@ Kirigami.AbstractApplicationHeader {
58 +
59 + //TODO: different implementation?
60 + source: globalToolBar.actualStyle == Kirigami.ApplicationHeaderStyle.TabBar ? Qt.resolvedUrl("TabBarControl.qml") : Qt.resolvedUrl("BreadcrumbControl.qml")
61 +-
62 +- Behavior on opacity {
63 +- OpacityAnimator {
64 +- duration: Kirigami.Units.longDuration
65 +- easing.type: Easing.InOutQuad
66 +- }
67 +- }
68 + }
69 +
70 + Item {
71 +@@ -137,6 +130,6 @@ Kirigami.AbstractApplicationHeader {
72 + Layout.preferredWidth: height
73 + }
74 + }
75 +- background.opacity: breadcrumbLoader.opacity
76 ++ background.visible: breadcrumbLoader.visible
77 + }
78 +
79 +--
80 +GitLab
81 +
82
83 diff --git a/kde-frameworks/kirigami/kirigami-5.88.0-r1.ebuild b/kde-frameworks/kirigami/kirigami-5.88.0-r1.ebuild
84 new file mode 100644
85 index 000000000000..a161344b23b0
86 --- /dev/null
87 +++ b/kde-frameworks/kirigami/kirigami-5.88.0-r1.ebuild
88 @@ -0,0 +1,48 @@
89 +# Copyright 1999-2021 Gentoo Authors
90 +# Distributed under the terms of the GNU General Public License v2
91 +
92 +EAPI=8
93 +
94 +ECM_EXAMPLES="true"
95 +ECM_QTHELP="false"
96 +ECM_TEST="true"
97 +KDE_ORG_NAME="${PN}2"
98 +QTMIN=5.15.2
99 +inherit ecm kde.org
100 +
101 +DESCRIPTION="Lightweight user interface framework for mobile and convergent applications"
102 +HOMEPAGE="https://techbase.kde.org/Kirigami"
103 +EGIT_REPO_URI="${EGIT_REPO_URI/${PN}2/${PN}}"
104 +
105 +LICENSE="LGPL-2+"
106 +KEYWORDS="~amd64 ~arm ~arm64 ~ppc64 ~riscv ~x86"
107 +IUSE=""
108 +
109 +# requires package to already be installed
110 +RESTRICT="test"
111 +
112 +BDEPEND="
113 + >=dev-qt/linguist-tools-${QTMIN}:5
114 +"
115 +DEPEND="
116 + >=dev-qt/qtconcurrent-${QTMIN}:5
117 + >=dev-qt/qtdbus-${QTMIN}:5
118 + >=dev-qt/qtdeclarative-${QTMIN}:5
119 + >=dev-qt/qtgui-${QTMIN}:5
120 + >=dev-qt/qtnetwork-${QTMIN}:5
121 + >=dev-qt/qtquickcontrols2-${QTMIN}:5
122 + >=dev-qt/qtsvg-${QTMIN}:5
123 +"
124 +RDEPEND="${DEPEND}
125 + >=dev-qt/qtgraphicaleffects-${QTMIN}:5
126 +"
127 +
128 +PATCHES=( "${FILESDIR}"/${P}-PageRowGlobalToolBarUI-dont-animate-opacity.patch )
129 +
130 +src_configure() {
131 + local mycmakeargs=(
132 + -DBUILD_EXAMPLES=$(usex examples)
133 + )
134 +
135 + ecm_src_configure
136 +}