Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: app-arch/zstd/
Date: Fri, 31 Dec 2021 22:49:34
Message-Id: 1640990896.eea3dcd064899b8250f90972208a5a7b623829e9.sam@gentoo
1 commit: eea3dcd064899b8250f90972208a5a7b623829e9
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Fri Dec 31 22:37:23 2021 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Fri Dec 31 22:48:16 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eea3dcd0
7
8 app-arch/zstd: disable asm (exec'able stack) on !amd64
9
10 See upstream bug / RH bug for details but the
11 property is silently lost and it's an error
12 in the annotation upstream.
13
14 Bug: https://bugs.gentoo.org/829849
15 Signed-off-by: Sam James <sam <AT> gentoo.org>
16
17 app-arch/zstd/{zstd-1.5.1.ebuild => zstd-1.5.1-r1.ebuild} | 11 +++++++++++
18 1 file changed, 11 insertions(+)
19
20 diff --git a/app-arch/zstd/zstd-1.5.1.ebuild b/app-arch/zstd/zstd-1.5.1-r1.ebuild
21 similarity index 85%
22 rename from app-arch/zstd/zstd-1.5.1.ebuild
23 rename to app-arch/zstd/zstd-1.5.1-r1.ebuild
24 index ee5d6e6b7871..4e3f4fdad650 100644
25 --- a/app-arch/zstd/zstd-1.5.1.ebuild
26 +++ b/app-arch/zstd/zstd-1.5.1-r1.ebuild
27 @@ -28,6 +28,16 @@ src_prepare() {
28 }
29
30 mymake() {
31 + # We need to turn off asm for certain arches (!amd64) for now.
32 + # - bug #829849
33 + # - https://bugzilla.redhat.com/show_bug.cgi?id=2035802
34 + # - https://github.com/facebook/zstd/issues/2963
35 + local asm="ZSTD_NO_ASM=1"
36 +
37 + if use amd64 ; then
38 + asm=
39 + fi
40 +
41 emake \
42 CC="$(tc-getCC)" \
43 CXX="$(tc-getCXX)" \
44 @@ -35,6 +45,7 @@ mymake() {
45 PREFIX="${EPREFIX}/usr" \
46 LIBDIR="${EPREFIX}/usr/$(get_libdir)" \
47 V=1 \
48 + ${asm} \
49 "${@}"
50 }