Gentoo Archives: gentoo-commits

From: Jimi Huotari <chiitoo@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/qt:master commit in: dev-qt/qtwebengine/, dev-qt/qtwebengine/files/
Date: Tue, 26 Apr 2022 15:03:46
Message-Id: 1650985172.ce687067d9fd189ca0faab3c31dc5b8f4db0d00f.chiitoo@gentoo
1 commit: ce687067d9fd189ca0faab3c31dc5b8f4db0d00f
2 Author: Jimi Huotari <chiitoo <AT> gentoo <DOT> org>
3 AuthorDate: Tue Apr 26 14:59:32 2022 +0000
4 Commit: Jimi Huotari <chiitoo <AT> gentoo <DOT> org>
5 CommitDate: Tue Apr 26 14:59:32 2022 +0000
6 URL: https://gitweb.gentoo.org/proj/qt.git/commit/?id=ce687067
7
8 dev-qt/qtwebengine: fix 6.3.0 build with system-icu
9
10 Closes: https://bugs.gentoo.org/838742
11 Package-Manager: Portage-3.0.30, Repoman-3.0.3
12 Signed-off-by: Jimi Huotari <chiitoo <AT> gentoo.org>
13
14 .../files/qtwebengine-6.3.0-system-icu.patch | 38 ++++++++++++++++++++++
15 dev-qt/qtwebengine/qtwebengine-6.3.0.ebuild | 2 ++
16 2 files changed, 40 insertions(+)
17
18 diff --git a/dev-qt/qtwebengine/files/qtwebengine-6.3.0-system-icu.patch b/dev-qt/qtwebengine/files/qtwebengine-6.3.0-system-icu.patch
19 new file mode 100644
20 index 00000000..1cb94de2
21 --- /dev/null
22 +++ b/dev-qt/qtwebengine/files/qtwebengine-6.3.0-system-icu.patch
23 @@ -0,0 +1,38 @@
24 +From 75f0f4eb1e4f2823c39fe27137f78ac2c10bc293 Mon Sep 17 00:00:00 2001
25 +From: Kirill Burtsev <kirill.burtsev@××.io>
26 +Date: Thu, 31 Mar 2022 19:45:39 +0200
27 +Subject: [FIXUP] Fix compilation with system ICU
28 +
29 +As of chromium 92.0.4480.0 after a set of fixes ending with a
30 +https://chromium-review.googlesource.com/c/chromium/src/+/2830820
31 +the need to override UCHAR_TYPE was dropped with the result that
32 +codebase is ready for default 'char16_t'. Override was already dropped
33 +for 98-based, which already builds fine for system ICU 70.1
34 +
35 +Task-number: QTBUG-100495
36 +Change-Id: I0e6d422f77b77015840647b52247f51736dd8a41
37 +Reviewed-by: Allan Sandfeld Jensen <allan.jensen@××.io>
38 +---
39 + chromium/third_party/icu/BUILD.gn | 6 ------
40 + 1 file changed, 6 deletions(-)
41 +
42 +diff --git a/chromium/third_party/icu/BUILD.gn b/chromium/third_party/icu/BUILD.gn
43 +index d5b136168ef..269de02eaaa 100644
44 +--- a/src/3rdparty/chromium/third_party/icu/BUILD.gn
45 ++++ b/src/3rdparty/chromium/third_party/icu/BUILD.gn
46 +@@ -410,12 +410,6 @@ config("system_icu_config") {
47 + "USING_SYSTEM_ICU=1",
48 + "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC",
49 + ]
50 +-
51 +- if (is_win) {
52 +- defines += [ "UCHAR_TYPE=wchar_t" ]
53 +- } else {
54 +- defines += [ "UCHAR_TYPE=uint16_t" ]
55 +- }
56 + }
57 +
58 + if (use_system_icu) {
59 +--
60 +cgit v1.2.1
61 +
62
63 diff --git a/dev-qt/qtwebengine/qtwebengine-6.3.0.ebuild b/dev-qt/qtwebengine/qtwebengine-6.3.0.ebuild
64 index 3642199e..23eed817 100644
65 --- a/dev-qt/qtwebengine/qtwebengine-6.3.0.ebuild
66 +++ b/dev-qt/qtwebengine/qtwebengine-6.3.0.ebuild
67 @@ -87,6 +87,8 @@ DEPEND="${RDEPEND}
68 media-libs/libglvnd
69 "
70
71 +PATCHES=( "${FILESDIR}/${PN}-6.3.0-system-icu.patch" ) # https://bugs.gentoo.org/838742
72 +
73 python_check_deps() {
74 has_version "dev-python/html5lib[${PYTHON_USEDEP}]"
75 }