[gentoo-commits] gentoo-x86 commit in app-pda/gtkpod/files: gtkpod-2.1.2-bffr-overflow.patch

[Justin Lecher (jlec)]

jlec        12/11/02 11:37:11

  Added:                gtkpod-2.1.2-bffr-overflow.patch
  Log:
  app-pda/gtkpod: Fid for buffer overflow, #434220
  
  (Portage version: 2.2.0_alpha142/cvs/Linux x86_64, signed Manifest commit with key 8009D6F070EB7916)

Revision  Changes    Path
1.1                  app-pda/gtkpod/files/gtkpod-2.1.2-bffr-overflow.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-pda/gtkpod/files/gtkpod-2.1.2-bffr-overflow.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-pda/gtkpod/files/gtkpod-2.1.2-bffr-overflow.patch?rev=1.1&content-type=text/plain

Index: gtkpod-2.1.2-bffr-overflow.patch
===================================================================
 libs/atomic-parsley/AtomicParsley.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/atomic-parsley/AtomicParsley.cpp b/libs/atomic-parsley/AtomicParsley.cpp
index 8603885..9190df3 100644
--- a/libs/atomic-parsley/AtomicParsley.cpp
+++ b/libs/atomic-parsley/AtomicParsley.cpp
@@ -1887,7 +1887,7 @@ char* APar_ExtractDataAtom(int this_atom_number) {
 
             }
             else { //purl & egid would end up here too, but Apple switched it to a text string (0x00), so gets taken care above explicitly
-                char* result = (char*) malloc(sizeof(char) * 6);
+                char* result = (char*) malloc(sizeof(char) * 6 + 1);
                 sprintf(result, "hex 0x");
 
                 for (int hexx = 1; hexx <= (int) (thisAtom->AtomicLength - atom_header_size); ++hexx) {